From: Matthew Auld <matthew.auld@intel.com>
To: intel-gfx@lists.freedesktop.org
Subject: [PATCH 08/19] drm/i915: enable IPS bit for 64K pages
Date: Wed, 21 Jun 2017 21:33:34 +0100 [thread overview]
Message-ID: <20170621203345.26320-9-matthew.auld@intel.com> (raw)
In-Reply-To: <20170621203345.26320-1-matthew.auld@intel.com>
Before we can enable 64K pages through the IPS bit, we must first enable
it through MMIO, otherwise the page-walker will simply ignore it.
Signed-off-by: Matthew Auld <matthew.auld@intel.com>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
---
drivers/gpu/drm/i915/i915_gem.c | 11 +++++++++++
drivers/gpu/drm/i915/i915_reg.h | 3 +++
2 files changed, 14 insertions(+)
diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c
index d9bc8a07b0ca..c4a27b4f419c 100644
--- a/drivers/gpu/drm/i915/i915_gem.c
+++ b/drivers/gpu/drm/i915/i915_gem.c
@@ -4804,6 +4804,17 @@ int i915_gem_init_hw(struct drm_i915_private *dev_priv)
}
}
+ /* To support 64K PTE's we need to first enable the use of the
+ * Intermediate-Page-Size(IPS) bit of the PDE field via some magical
+ * mmio, otherwise the page-walker will simply ignore the IPS bit. This
+ * shouldn't be needed after GEN10.
+ */
+ if (HAS_PAGE_SIZE(dev_priv, I915_GTT_PAGE_SIZE_64K) &&
+ INTEL_GEN(dev_priv) <= 10)
+ I915_WRITE(GEN8_GAMW_ECO_DEV_RW_IA,
+ I915_READ(GEN8_GAMW_ECO_DEV_RW_IA) |
+ GAMW_ECO_ENABLE_64K_IPS_FIELD);
+
i915_gem_init_swizzling(dev_priv);
/*
diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
index c8647cfa81ba..f2ecc92bdd48 100644
--- a/drivers/gpu/drm/i915/i915_reg.h
+++ b/drivers/gpu/drm/i915/i915_reg.h
@@ -2190,6 +2190,9 @@ enum skl_disp_power_wells {
#define GEN9_GAMT_ECO_REG_RW_IA _MMIO(0x4ab0)
#define GAMT_ECO_ENABLE_IN_PLACE_DECOMPRESS (1<<18)
+#define GEN8_GAMW_ECO_DEV_RW_IA _MMIO(0x4080)
+#define GAMW_ECO_ENABLE_64K_IPS_FIELD 0xF
+
#define GAMT_CHKN_BIT_REG _MMIO(0x4ab8)
#define GAMT_CHKN_DISABLE_DYNAMIC_CREDIT_SHARING (1<<28)
--
2.9.4
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-06-21 20:34 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-21 20:33 [PATCH 00/19] huge gtt pages Matthew Auld
2017-06-21 20:33 ` [PATCH 01/19] drm/i915: introduce simple gemfs Matthew Auld
2017-06-21 21:19 ` Chris Wilson
2017-06-21 20:33 ` [PATCH 02/19] drm/i915/gemfs: enable THP Matthew Auld
2017-06-21 20:33 ` [PATCH 03/19] drm/i915: introduce page_size_mask to dev_info Matthew Auld
2017-06-21 20:33 ` [PATCH 04/19] drm/i915: introduce page_size members Matthew Auld
2017-06-21 21:26 ` Chris Wilson
2017-06-21 20:33 ` [PATCH 05/19] drm/i915: align the vma start to the largest gtt page size Matthew Auld
2017-06-21 21:35 ` Chris Wilson
2017-06-21 20:33 ` [PATCH 06/19] drm/i915: align 64K objects to 2M Matthew Auld
2017-06-21 21:37 ` Chris Wilson
2017-06-21 20:33 ` [PATCH 07/19] drm/i915: pass the vma to insert_entries Matthew Auld
2017-06-21 21:39 ` Chris Wilson
2017-06-21 20:33 ` Matthew Auld [this message]
2017-06-21 20:33 ` [PATCH 09/19] drm/i915: disable GTT cache for 2M/1G pages Matthew Auld
2017-06-21 21:41 ` Chris Wilson
2017-06-21 20:33 ` [PATCH 10/19] drm/i915: support 1G pages for the 48b PPGTT Matthew Auld
2017-06-21 21:49 ` Chris Wilson
2017-06-21 22:51 ` Chris Wilson
2017-06-22 11:07 ` Matthew Auld
2017-06-22 11:38 ` Chris Wilson
2017-06-21 20:33 ` [PATCH 11/19] drm/i915: support 2M " Matthew Auld
2017-06-21 20:33 ` [PATCH 12/19] drm/i915: support 64K " Matthew Auld
2017-06-21 21:55 ` Chris Wilson
2017-06-22 11:27 ` Matthew Auld
2017-06-21 20:33 ` [PATCH 13/19] drm/i915: accurate page size tracking for the ppgtt Matthew Auld
2017-06-21 21:57 ` Chris Wilson
2017-06-21 20:33 ` [PATCH 14/19] drm/i915/debugfs: include some gtt page size metrics Matthew Auld
2017-06-21 20:33 ` [PATCH 15/19] drm/i915/selftests: basic huge page tests Matthew Auld
2017-06-22 14:17 ` Chris Wilson
2017-06-22 14:21 ` Chris Wilson
2017-06-21 20:33 ` [PATCH 16/19] drm/i915/selftests: mix huge pages Matthew Auld
2017-06-21 20:33 ` [PATCH 17/19] drm/i915: enable platform support for 64K pages Matthew Auld
2017-06-21 20:33 ` [PATCH 18/19] drm/i915: enable platform support for 2M pages Matthew Auld
2017-06-21 20:33 ` [PATCH 19/19] drm/i915: enable platform support for 1G pages Matthew Auld
2017-06-21 21:05 ` ✓ Fi.CI.BAT: success for huge gtt pages (rev2) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170621203345.26320-9-matthew.auld@intel.com \
--to=matthew.auld@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.