From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boris Brezillon Subject: Re: [PATCH 4/4] drm/vc4: Remove dead vc4_event_pending(). Date: Wed, 21 Jun 2017 21:54:56 +0200 Message-ID: <20170621215456.2cab5525@bbrezillon> References: <20170621185002.28563-1-eric@anholt.net> <20170621185002.28563-4-eric@anholt.net> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail.free-electrons.com (mail.free-electrons.com [62.4.15.54]) by gabe.freedesktop.org (Postfix) with ESMTP id 4FB8E89C86 for ; Wed, 21 Jun 2017 19:55:00 +0000 (UTC) In-Reply-To: <20170621185002.28563-4-eric@anholt.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Eric Anholt Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org TGUgV2VkLCAyMSBKdW4gMjAxNyAxMTo1MDowMiAtMDcwMCwKRXJpYyBBbmhvbHQgPGVyaWNAYW5o b2x0Lm5ldD4gYSDDqWNyaXQgOgoKPiBJdCBpcyBubyBsb25nZXIgdXNlZCBhcyBvZiBjb21taXQg MzRjOGVhNDAwZmY2ICgiZHJtL3ZjNDogTWltaWMKPiBkcm1fYXRvbWljX2hlbHBlcl9jb21taXQo KSBiZWhhdmlvciIpCj4gCj4gU2lnbmVkLW9mZi1ieTogRXJpYyBBbmhvbHQgPGVyaWNAYW5ob2x0 Lm5ldD4KClJldmlld2VkLWJ5OiBCb3JpcyBCcmV6aWxsb24gPGJvcmlzLmJyZXppbGxvbkBmcmVl LWVsZWN0cm9ucy5jb20+Cgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vdmM0L3ZjNF9jcnRjLmMg fCA4IC0tLS0tLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS92YzQvdmM0X2Rydi5oICB8IDEgLQo+ICAy IGZpbGVzIGNoYW5nZWQsIDkgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMv Z3B1L2RybS92YzQvdmM0X2NydGMuYyBiL2RyaXZlcnMvZ3B1L2RybS92YzQvdmM0X2NydGMuYwo+ IGluZGV4IDMwYTFkZjExZTA2My4uZjIwYzAxNzU5YzBkIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMv Z3B1L2RybS92YzQvdmM0X2NydGMuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS92YzQvdmM0X2Ny dGMuYwo+IEBAIC02NzQsMTQgKzY3NCw2IEBAIHN0YXRpYyB2b2lkIHZjNF9kaXNhYmxlX3ZibGFu ayhzdHJ1Y3QgZHJtX2NydGMgKmNydGMpCj4gIAlDUlRDX1dSSVRFKFBWX0lOVEVOLCAwKTsKPiAg fQo+ICAKPiAtLyogTXVzdCBiZSBjYWxsZWQgd2l0aCB0aGUgZXZlbnQgbG9jayBoZWxkICovCj4g LWJvb2wgdmM0X2V2ZW50X3BlbmRpbmcoc3RydWN0IGRybV9jcnRjICpjcnRjKQo+IC17Cj4gLQlz dHJ1Y3QgdmM0X2NydGMgKnZjNF9jcnRjID0gdG9fdmM0X2NydGMoY3J0Yyk7Cj4gLQo+IC0JcmV0 dXJuICEhdmM0X2NydGMtPmV2ZW50Owo+IC19Cj4gLQo+ICBzdGF0aWMgdm9pZCB2YzRfY3J0Y19o YW5kbGVfcGFnZV9mbGlwKHN0cnVjdCB2YzRfY3J0YyAqdmM0X2NydGMpCj4gIHsKPiAgCXN0cnVj dCBkcm1fY3J0YyAqY3J0YyA9ICZ2YzRfY3J0Yy0+YmFzZTsKPiBkaWZmIC0tZ2l0IGEvZHJpdmVy cy9ncHUvZHJtL3ZjNC92YzRfZHJ2LmggYi9kcml2ZXJzL2dwdS9kcm0vdmM0L3ZjNF9kcnYuaAo+ IGluZGV4IGRmMjI2OThkNjJlZS4uMTA0Nzk1MzIxNmE4IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMv Z3B1L2RybS92YzQvdmM0X2Rydi5oCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL3ZjNC92YzRfZHJ2 LmgKPiBAQCAtNDkxLDcgKzQ5MSw2IEBAIGludCB2YzRfYm9fc3RhdHNfZGVidWdmcyhzdHJ1Y3Qg c2VxX2ZpbGUgKm0sIHZvaWQgKmFyZyk7Cj4gIAo+ICAvKiB2YzRfY3J0Yy5jICovCj4gIGV4dGVy biBzdHJ1Y3QgcGxhdGZvcm1fZHJpdmVyIHZjNF9jcnRjX2RyaXZlcjsKPiAtYm9vbCB2YzRfZXZl bnRfcGVuZGluZyhzdHJ1Y3QgZHJtX2NydGMgKmNydGMpOwo+ICBpbnQgdmM0X2NydGNfZGVidWdm c19yZWdzKHN0cnVjdCBzZXFfZmlsZSAqbSwgdm9pZCAqYXJnKTsKPiAgYm9vbCB2YzRfY3J0Y19n ZXRfc2Nhbm91dHBvcyhzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LCB1bnNpZ25lZCBpbnQgY3J0Y19p ZCwKPiAgCQkJICAgICBib29sIGluX3ZibGFua19pcnEsIGludCAqdnBvcywgaW50ICpocG9zLAoK X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751985AbdFUTzC convert rfc822-to-8bit (ORCPT ); Wed, 21 Jun 2017 15:55:02 -0400 Received: from mail.free-electrons.com ([62.4.15.54]:45464 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751083AbdFUTzB (ORCPT ); Wed, 21 Jun 2017 15:55:01 -0400 Date: Wed, 21 Jun 2017 21:54:56 +0200 From: Boris Brezillon To: Eric Anholt Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/4] drm/vc4: Remove dead vc4_event_pending(). Message-ID: <20170621215456.2cab5525@bbrezillon> In-Reply-To: <20170621185002.28563-4-eric@anholt.net> References: <20170621185002.28563-1-eric@anholt.net> <20170621185002.28563-4-eric@anholt.net> X-Mailer: Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le Wed, 21 Jun 2017 11:50:02 -0700, Eric Anholt a écrit : > It is no longer used as of commit 34c8ea400ff6 ("drm/vc4: Mimic > drm_atomic_helper_commit() behavior") > > Signed-off-by: Eric Anholt Reviewed-by: Boris Brezillon > --- > drivers/gpu/drm/vc4/vc4_crtc.c | 8 -------- > drivers/gpu/drm/vc4/vc4_drv.h | 1 - > 2 files changed, 9 deletions(-) > > diff --git a/drivers/gpu/drm/vc4/vc4_crtc.c b/drivers/gpu/drm/vc4/vc4_crtc.c > index 30a1df11e063..f20c01759c0d 100644 > --- a/drivers/gpu/drm/vc4/vc4_crtc.c > +++ b/drivers/gpu/drm/vc4/vc4_crtc.c > @@ -674,14 +674,6 @@ static void vc4_disable_vblank(struct drm_crtc *crtc) > CRTC_WRITE(PV_INTEN, 0); > } > > -/* Must be called with the event lock held */ > -bool vc4_event_pending(struct drm_crtc *crtc) > -{ > - struct vc4_crtc *vc4_crtc = to_vc4_crtc(crtc); > - > - return !!vc4_crtc->event; > -} > - > static void vc4_crtc_handle_page_flip(struct vc4_crtc *vc4_crtc) > { > struct drm_crtc *crtc = &vc4_crtc->base; > diff --git a/drivers/gpu/drm/vc4/vc4_drv.h b/drivers/gpu/drm/vc4/vc4_drv.h > index df22698d62ee..1047953216a8 100644 > --- a/drivers/gpu/drm/vc4/vc4_drv.h > +++ b/drivers/gpu/drm/vc4/vc4_drv.h > @@ -491,7 +491,6 @@ int vc4_bo_stats_debugfs(struct seq_file *m, void *arg); > > /* vc4_crtc.c */ > extern struct platform_driver vc4_crtc_driver; > -bool vc4_event_pending(struct drm_crtc *crtc); > int vc4_crtc_debugfs_regs(struct seq_file *m, void *arg); > bool vc4_crtc_get_scanoutpos(struct drm_device *dev, unsigned int crtc_id, > bool in_vblank_irq, int *vpos, int *hpos,