All of lore.kernel.org
 help / color / mirror / Atom feed
From: steve@steve.org.uk (Steve Kemp)
To: linux-security-module@vger.kernel.org
Subject: [PATCH] Moved module init-functions into the module.
Date: Thu, 22 Jun 2017 08:09:15 +0000	[thread overview]
Message-ID: <20170622080915.GA2936@steve.org.uk> (raw)
In-Reply-To: <CABawtvN4qFQ7BEB1xYBi1Vw8Sg1=xHMF2TVnnKVGcYXwerZLgQ@mail.gmail.com>

On Thu Jun 22, 2017 at 16:02:30 +0800, Ethan Zhao wrote:

>       Seems you moved the initialization of security module to
> late_initcall stage, that is not right.

  Thanks for the feedback.

>       For security modules, you should use security_initcall() macro to define
> the init functions.

  Literally just a change like this?

  -late_initcall(yama_add_hooks);
  +security_initcall(yama_add_hooks);

  I'll submit v2 with that shortly, thanks.

Steve
-- 
--
To unsubscribe from this list: send the line "unsubscribe linux-security-module" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: Steve Kemp <steve@steve.org.uk>
To: Ethan Zhao <ethan.kernel@gmail.com>
Cc: Steve Kemp <steve@steve.fi>,
	linux-security-module@vger.kernel.org,
	LKML <linux-kernel@vger.kernel.org>,
	Kees Cook <keescook@chromium.org>,
	James Morris <james.l.morris@oracle.com>,
	"Serge E. Hallyn" <serge@hallyn.com>
Subject: Re: [PATCH] Moved module init-functions into the module.
Date: Thu, 22 Jun 2017 08:09:15 +0000	[thread overview]
Message-ID: <20170622080915.GA2936@steve.org.uk> (raw)
In-Reply-To: <CABawtvN4qFQ7BEB1xYBi1Vw8Sg1=xHMF2TVnnKVGcYXwerZLgQ@mail.gmail.com>

On Thu Jun 22, 2017 at 16:02:30 +0800, Ethan Zhao wrote:

>       Seems you moved the initialization of security module to
> late_initcall stage, that is not right.

  Thanks for the feedback.

>       For security modules, you should use security_initcall() macro to define
> the init functions.

  Literally just a change like this?

  -late_initcall(yama_add_hooks);
  +security_initcall(yama_add_hooks);

  I'll submit v2 with that shortly, thanks.

Steve
-- 

  reply	other threads:[~2017-06-22  8:09 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-22  6:55 [PATCH] Moved module init-functions into the module Steve Kemp
2017-06-22  6:55 ` Steve Kemp
2017-06-22  8:02 ` Ethan Zhao
2017-06-22  8:02   ` Ethan Zhao
2017-06-22  8:09   ` Steve Kemp [this message]
2017-06-22  8:09     ` Steve Kemp

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170622080915.GA2936@steve.org.uk \
    --to=steve@steve.org.uk \
    --cc=linux-security-module@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.