From: "Marek Marczykowski-Górecki" <marmarek@invisiblethingslab.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Jan Beulich <JBeulich@suse.com>, xen-devel <xen-devel@lists.xen.org>
Subject: Re: xc_evtchn_status fails with EFAULT on HVM, the same on PV works
Date: Thu, 22 Jun 2017 10:23:51 +0200 [thread overview]
Message-ID: <20170622082351.GA19759@mail-itl> (raw)
In-Reply-To: <69bdbdcd-a285-fe1d-03b5-05fa0654b3e6@citrix.com>
[-- Attachment #1.1: Type: text/plain, Size: 1432 bytes --]
[resurrecting old thread...]
On Mon, Jan 16, 2017 at 11:41:55PM +0000, Andrew Cooper wrote:
> On 16/01/2017 23:06, Marek Marczykowski-Górecki wrote:
> > On Mon, Jan 16, 2017 at 05:17:59AM -0700, Jan Beulich wrote:
> >> 2) When the guest issues stac()/clac(), it indicates to Xen _its own_
> >> intended view, without affecting Xen's. That is, as soon as hypervisor
> >> context is being entered again, SMAP protection would be in effect
> >> again (albeit as per point 1 guarding only against accessing PV guest
> >> mappings).
> >>
> >> So the driver adjustment suggested by Andrew has an effect on only
> >> page walks done by Xen during copy_{to,from}_guest(), but not on
> >> actual memory accesses.
> > Ok, so indeed the kernel patch makes the most sense here. Is the change
> > in this shape (if works - I'll test it shortly) good to include
> > upstream, or is it "ugly hack"?
>
> If it works (which I suspect it will), then it will be the correct
> proper upstream fix, and will of course CC stable@.
Should I submit it?
> In the meantime until it percolates into downstream kernels, disabling
> SMAP for affected guests is probably the best stopgap solution.
How to disable SMAP for selected guests only?
--
Best Regards,
Marek Marczykowski-Górecki
Invisible Things Lab
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
[-- Attachment #2: Type: text/plain, Size: 127 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-06-22 8:23 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-13 17:31 xc_evtchn_status fails with EFAULT on HVM, the same on PV works Marek Marczykowski-Górecki
2017-01-13 17:38 ` Andrew Cooper
2017-01-13 18:03 ` Marek Marczykowski-Górecki
2017-01-13 18:15 ` Andrew Cooper
2017-01-13 18:32 ` Marek Marczykowski-Górecki
2017-01-13 18:37 ` Andrew Cooper
2017-01-13 18:59 ` Marek Marczykowski-Górecki
2017-01-13 19:27 ` Andrew Cooper
2017-01-13 19:40 ` Marek Marczykowski-Górecki
2017-01-13 19:54 ` Andrew Cooper
2017-01-13 20:32 ` Marek Marczykowski-Górecki
2017-01-14 1:47 ` Andrew Cooper
2017-01-14 2:52 ` Marek Marczykowski-Górecki
2017-01-16 12:17 ` Jan Beulich
2017-01-16 23:06 ` Marek Marczykowski-Górecki
2017-01-16 23:41 ` Andrew Cooper
2017-06-22 8:23 ` Marek Marczykowski-Górecki [this message]
2017-06-22 8:27 ` Andrew Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170622082351.GA19759@mail-itl \
--to=marmarek@invisiblethingslab.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.