diff for duplicates of <20170622101404.blfpqcryrbe35ha4@linux.intel.com> diff --git a/a/1.txt b/N1/1.txt index e38961e..8faeccc 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -103,7 +103,7 @@ in the responsiblity of the caller. > - 0, "attempting to read a pcr value"); > + rc = tpm2_pcr_read_tpm_buf(chip, pcr_idx, TPM2_ALG_SHA1, &buf, > + "attempting to read a pcr value"); -> if (rc = 0) { +> if (rc == 0) { > - buf = cmd.params.pcrread_out.digest; > - memcpy(res_buf, buf, TPM_DIGEST_SIZE); > + out = (struct tpm2_pcr_read_out *)&buf.data[TPM_HEADER_SIZE]; @@ -122,3 +122,7 @@ that makes reading the code harder. With some adjustments this is a welcome change. /Jarkko +-- +To unsubscribe from this list: send the line "unsubscribe linux-security-module" in +the body of a message to majordomo at vger.kernel.org +More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/a/content_digest b/N1/content_digest index f70e63f..93e926b 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,8 +1,8 @@ "ref\020170621142941.32674-1-roberto.sassu@huawei.com\0" "ref\020170621142941.32674-2-roberto.sassu@huawei.com\0" - "From\0Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>\0" - "Subject\0Re: [tpmdd-devel] [PATCH v3 1/6] tpm: use tpm_buf functions to perform a PCR read\0" - "Date\0Thu, 22 Jun 2017 10:14:04 +0000\0" + "From\0jarkko.sakkinen@linux.intel.com (Jarkko Sakkinen)\0" + "Subject\0[tpmdd-devel] [PATCH v3 1/6] tpm: use tpm_buf functions to perform a PCR read\0" + "Date\0Thu, 22 Jun 2017 12:14:04 +0200\0" "To\0linux-security-module@vger.kernel.org\0" "\00:1\0" "b\0" @@ -111,7 +111,7 @@ "> -\t\t\t 0, \"attempting to read a pcr value\");\n" "> +\trc = tpm2_pcr_read_tpm_buf(chip, pcr_idx, TPM2_ALG_SHA1, &buf,\n" "> +\t\t\t\t \"attempting to read a pcr value\");\n" - "> \tif (rc = 0) {\n" + "> \tif (rc == 0) {\n" "> -\t\tbuf = cmd.params.pcrread_out.digest;\n" "> -\t\tmemcpy(res_buf, buf, TPM_DIGEST_SIZE);\n" "> +\t\tout = (struct tpm2_pcr_read_out *)&buf.data[TPM_HEADER_SIZE];\n" @@ -129,6 +129,10 @@ "\n" "With some adjustments this is a welcome change.\n" "\n" - /Jarkko + "/Jarkko\n" + "--\n" + "To unsubscribe from this list: send the line \"unsubscribe linux-security-module\" in\n" + "the body of a message to majordomo at vger.kernel.org\n" + More majordomo info at http://vger.kernel.org/majordomo-info.html -eb0fdff544d5a70f705d89f8e067cea9c537136b3425974d3bf3388d4843e881 +bfb699e2910e54104fc3a36472633490ad4da76db04739702bea50b0c0d21c04
diff --git a/a/1.txt b/N2/1.txt index e38961e..cf98d25 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -103,7 +103,7 @@ in the responsiblity of the caller. > - 0, "attempting to read a pcr value"); > + rc = tpm2_pcr_read_tpm_buf(chip, pcr_idx, TPM2_ALG_SHA1, &buf, > + "attempting to read a pcr value"); -> if (rc = 0) { +> if (rc == 0) { > - buf = cmd.params.pcrread_out.digest; > - memcpy(res_buf, buf, TPM_DIGEST_SIZE); > + out = (struct tpm2_pcr_read_out *)&buf.data[TPM_HEADER_SIZE]; diff --git a/a/content_digest b/N2/content_digest index f70e63f..9b9bb66 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -2,8 +2,13 @@ "ref\020170621142941.32674-2-roberto.sassu@huawei.com\0" "From\0Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>\0" "Subject\0Re: [tpmdd-devel] [PATCH v3 1/6] tpm: use tpm_buf functions to perform a PCR read\0" - "Date\0Thu, 22 Jun 2017 10:14:04 +0000\0" - "To\0linux-security-module@vger.kernel.org\0" + "Date\0Thu, 22 Jun 2017 12:14:04 +0200\0" + "To\0Roberto Sassu <roberto.sassu@huawei.com>\0" + "Cc\0tpmdd-devel@lists.sourceforge.net" + linux-ima-devel@lists.sourceforge.net + linux-security-module@vger.kernel.org + keyrings@vger.kernel.org + " linux-kernel@vger.kernel.org\0" "\00:1\0" "b\0" "On Wed, Jun 21, 2017 at 04:29:36PM +0200, Roberto Sassu wrote:\n" @@ -111,7 +116,7 @@ "> -\t\t\t 0, \"attempting to read a pcr value\");\n" "> +\trc = tpm2_pcr_read_tpm_buf(chip, pcr_idx, TPM2_ALG_SHA1, &buf,\n" "> +\t\t\t\t \"attempting to read a pcr value\");\n" - "> \tif (rc = 0) {\n" + "> \tif (rc == 0) {\n" "> -\t\tbuf = cmd.params.pcrread_out.digest;\n" "> -\t\tmemcpy(res_buf, buf, TPM_DIGEST_SIZE);\n" "> +\t\tout = (struct tpm2_pcr_read_out *)&buf.data[TPM_HEADER_SIZE];\n" @@ -131,4 +136,4 @@ "\n" /Jarkko -eb0fdff544d5a70f705d89f8e067cea9c537136b3425974d3bf3388d4843e881 +25cba411d014e9da7c3a8d241a52b6a2cebe1deb0fa9626e2f94931da895cb43
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.