From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Lunn Subject: Re: [RFC PATCH net-next 1/3] ethtool: Add link down reason callback Date: Thu, 22 Jun 2017 15:34:04 +0200 Message-ID: <20170622133404.GB20038@lunn.ch> References: <1498050286-17141-1-git-send-email-galp@mellanox.com> <1498050286-17141-2-git-send-email-galp@mellanox.com> <20170621135809.GC27585@lunn.ch> <8e7ffead-350e-bd7f-c7ea-fe057969d0d3@mellanox.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: netdev@vger.kernel.org, "David S. Miller" , "John W. Linville" , Saeed Mahameed , Vidya Sagar Ravipati , Jiri Pirko , David Decotigny , kernel-team@fb.com To: Gal Pressman Return-path: Received: from vps0.lunn.ch ([178.209.37.122]:59990 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752918AbdFVNeJ (ORCPT ); Thu, 22 Jun 2017 09:34:09 -0400 Content-Disposition: inline In-Reply-To: <8e7ffead-350e-bd7f-c7ea-fe057969d0d3@mellanox.com> Sender: netdev-owner@vger.kernel.org List-ID: > The I2C bus that's connected to this module (interface). > We can add another reason for MDIO BUS errors or merge to one BUS error reason. > >> + ETHTOOL_LINK_UNSUPP_EEPROM, /* Unsupported EEPROM */ > > Which EEPROM? > > Module EEPROM. Which module? This is all very vague. Some of the Marvell 10G PHYs have an EEPROM to boot from, for example. Would that count? Or are you talking about the SFP 'EEPROM', which is not actually an EEPROM, in that it is not Electrically Erasable, not is it a ROM, since things like temperature changes with time. > >> + ETHTOOL_LINK_OVERTEMP, /* Over temperature */ > >> + ETHTOOL_LINK_PWR_BUDGET_EXC, /* Power budget exceeded */ > >> + ETHTOOL_LINK_MODULE_ADMIN_DOWN, /* Module admin down */ > > It seems like these last 6 are all SFP issues? How about putting SFP > > into the name? > > Might be a QSFP issue for example, we can put module in the name though. What is the generic name of SFP, SFP+ QSFP, SFF? Andrew