All of lore.kernel.org
 help / color / mirror / Atom feed
From: Logan Gunthorpe <logang@deltatee.com>
To: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org,
	linux-ntb@googlegroups.com, linux-alpha@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org, linux-crypto@vger.kernel.org,
	dri-devel@lists.freedesktop.org
Cc: Arnd Bergmann <arnd@arndb.de>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Stephen Bates <sbates@raithlin.com>,
	Logan Gunthorpe <logang@deltatee.com>, Jyri Sarha <jsarha@ti.com>,
	Tomi Valkeinen <tomi.valkeinen@ti.com>,
	David Airlie <airlied@linux.ie>
Subject: [PATCH 1/7] drm/tilcdc: don't use volatile with iowrite64
Date: Thu, 22 Jun 2017 10:48:11 -0600	[thread overview]
Message-ID: <20170622164817.25515-2-logang@deltatee.com> (raw)
In-Reply-To: <20170622164817.25515-1-logang@deltatee.com>

This is a prep patch for adding a universal iowrite64.

The patch is to prevent compiler warnings when we add iowrite64 that
would occur because there is an unnecessary volatile in this driver.

Signed-off-by: Logan Gunthorpe <logang@deltatee.com>
Cc: Jyri Sarha <jsarha@ti.com>
Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
Cc: David Airlie <airlied@linux.ie>
---
 drivers/gpu/drm/tilcdc/tilcdc_regs.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/tilcdc/tilcdc_regs.h b/drivers/gpu/drm/tilcdc/tilcdc_regs.h
index 9d528c0a67a4..e9ce725698a9 100644
--- a/drivers/gpu/drm/tilcdc/tilcdc_regs.h
+++ b/drivers/gpu/drm/tilcdc/tilcdc_regs.h
@@ -131,14 +131,14 @@ static inline void tilcdc_write(struct drm_device *dev, u32 reg, u32 data)
 static inline void tilcdc_write64(struct drm_device *dev, u32 reg, u64 data)
 {
 	struct tilcdc_drm_private *priv = dev->dev_private;
-	volatile void __iomem *addr = priv->mmio + reg;
+	void __iomem *addr = priv->mmio + reg;
 
 #ifdef iowrite64
 	iowrite64(data, addr);
 #else
 	__iowmb();
 	/* This compiles to strd (=64-bit write) on ARM7 */
-	*(volatile u64 __force *)addr = __cpu_to_le64(data);
+	*(u64 __force *)addr = __cpu_to_le64(data);
 #endif
 }
 
-- 
2.11.0


  reply	other threads:[~2017-06-22 16:48 UTC|newest]

Thread overview: 53+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-22 16:48 [PATCH 0/7] cleanup issues with io{read|write}64 Logan Gunthorpe
2017-06-22 16:48 ` Logan Gunthorpe [this message]
2017-06-26  8:54   ` [PATCH 1/7] drm/tilcdc: don't use volatile with iowrite64 Jyri Sarha
2017-06-26  8:54     ` Jyri Sarha
2017-06-26  8:54     ` Jyri Sarha
2017-06-26  8:54     ` Jyri Sarha
2017-06-22 16:48 ` [PATCH 2/7] iomap: implement ioread64 and iowrite64 Logan Gunthorpe
2017-06-26 20:43   ` Arnd Bergmann
2017-06-26 21:25     ` Logan Gunthorpe
2017-06-22 16:48 ` [PATCH 3/7] asm-generic/io.h: make ioread64 and iowrite64 universally available Logan Gunthorpe
2017-06-22 20:14   ` Alan Cox
2017-06-22 20:14     ` Alan Cox
2017-06-22 20:24     ` Logan Gunthorpe
2017-06-22 20:36       ` Alan Cox
2017-06-22 20:36         ` Alan Cox
2017-06-22 20:38         ` Logan Gunthorpe
2017-06-22 16:48 ` [PATCH 4/7] alpha: provide ioread64 and iowrite64 implementations Logan Gunthorpe
2017-06-22 17:29   ` Stephen  Bates
2017-06-22 17:29     ` Stephen  Bates
2017-06-22 17:30     ` Logan Gunthorpe
2017-06-22 20:08   ` Alan Cox
2017-06-22 20:09     ` Logan Gunthorpe
2017-06-22 21:03       ` Arnd Bergmann
2017-06-22 21:03         ` Arnd Bergmann
2017-06-22 21:10         ` Logan Gunthorpe
2017-06-22 21:20   ` Richard Henderson
2017-06-22 16:48 ` [PATCH 5/7] ntb: ntb_hw_intel: remove ioread64 and iowrite64 hacks Logan Gunthorpe
2017-06-22 17:17   ` Jiang, Dave
2017-06-22 17:17     ` Jiang, Dave
2017-06-22 17:17     ` Jiang, Dave
2017-06-22 16:48 ` [PATCH 6/7] drm/tilcdc: clean up ifdef hacks around iowrite64 Logan Gunthorpe
2017-06-26  8:55   ` Jyri Sarha
2017-06-26  8:55     ` Jyri Sarha
2017-06-26  8:55     ` Jyri Sarha
2017-06-26  8:55     ` Jyri Sarha
2017-06-26 16:26     ` Logan Gunthorpe
2017-06-27 20:40       ` Arnd Bergmann
2017-06-22 16:48 ` [PATCH 7/7] crypto: caam: cleanup CONFIG_64BIT ifdefs when using io{read|write}64 Logan Gunthorpe
2017-06-22 16:48   ` Logan Gunthorpe
2017-06-23  6:51   ` Horia Geantă
2017-06-23  6:51     ` Horia Geantă
2017-06-23  6:51     ` Horia Geantă
2017-06-23 17:59     ` Logan Gunthorpe
2017-06-23 17:59       ` Logan Gunthorpe
2017-06-23 17:59       ` Logan Gunthorpe
2017-06-24 11:57       ` [PATCH v2 " Horia Geantă
2017-06-24 11:57         ` Horia Geantă
2017-06-24 15:13         ` [PATCH] alpha: provide ioread64 and iowrite64 implementations Richard Henderson
2017-06-24 15:19           ` Logan Gunthorpe
2017-06-24 15:25             ` Richard Henderson
2017-06-24 15:32               ` Logan Gunthorpe
2017-06-24 16:14                 ` Richard Henderson
2017-06-24 17:17                   ` Logan Gunthorpe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170622164817.25515-2-logang@deltatee.com \
    --to=logang@deltatee.com \
    --cc=airlied@linux.ie \
    --cc=arnd@arndb.de \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jsarha@ti.com \
    --cc=linux-alpha@vger.kernel.org \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-ntb@googlegroups.com \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=sbates@raithlin.com \
    --cc=tomi.valkeinen@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.