From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1dO6wj-0001Et-Jk for mharc-qemu-trivial@gnu.org; Thu, 22 Jun 2017 14:35:13 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51061) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dO6wf-00018R-Ge for qemu-trivial@nongnu.org; Thu, 22 Jun 2017 14:35:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dO6we-0001Ch-N4 for qemu-trivial@nongnu.org; Thu, 22 Jun 2017 14:35:09 -0400 Received: from mx1.redhat.com ([209.132.183.28]:42276) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dO6wZ-00019P-JK; Thu, 22 Jun 2017 14:35:03 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 63D07C0587EB; Thu, 22 Jun 2017 18:35:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 63D07C0587EB Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=dgilbert@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 63D07C0587EB Received: from work-vm (ovpn-117-226.ams2.redhat.com [10.36.117.226]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A721565E83; Thu, 22 Jun 2017 18:35:00 +0000 (UTC) Date: Thu, 22 Jun 2017 19:34:58 +0100 From: "Dr. David Alan Gilbert" To: Peter Maydell Cc: Thomas Huth , Greg Kurz , QEMU Trivial , QEMU Developers , Juan Quintela Message-ID: <20170622183457.GG2100@work-vm> References: <149814756006.27338.8723356702388175951.stgit@bahia> <20170622184255.2d44e3bd@bahia.lab.toulouse-stg.fr.ibm.com> <87injo6jla.fsf@secure.mitica> <20170622172555.GE2100@work-vm> <20170622194649.6d251753@bahia.lab.toulouse-stg.fr.ibm.com> <20170622175012.GF2100@work-vm> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.8.2 (2017-04-18) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Thu, 22 Jun 2017 18:35:02 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] Separate function types from opaque types in include/qemu/typedefs.h X-BeenThere: qemu-trivial@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Jun 2017 18:35:10 -0000 * Peter Maydell (peter.maydell@linaro.org) wrote: > On 22 June 2017 at 19:08, Thomas Huth wrote: > > On 22.06.2017 19:50, Dr. David Alan Gilbert wrote: > >> Could do; I'm just not finding tiny header files with one or > >> two entries each that useful. > > Well, it means that the bulk of code that doesn't care about the > types doesn't get its compilation fractionally slowed by having > to parse the typedef anyway. In general I think we're drifting > towards "have each .c file get fewer things automatically" rather > than otherwise (eg more finely focused files rather than stuffing > everything into qemu-common.h). At the cost of things getting fractionally slower by including lots more tiny headers. I generally agree in the case where there's a useful chunk, but when it's down to one or two definitions I don't see the point. > > Do we really need these function typedefs at all? IMHO it's quite ugly > > to hide such things in a typedef unless it is really necessary (and in > > this case, it does not seem to be really necessary since it is only used > > in a few places). So what about simply removing the typedefs in this case? > > I find function typedefs much more readable than having the > function-types inline in function arguments and the like. > > This is all fairly rapidly heading into bikeshed territory > though -- in the final analysis I don't think it matters > much what we do. Agreed. Dave > thanks > -- PMM -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51047) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dO6wd-00015P-Od for qemu-devel@nongnu.org; Thu, 22 Jun 2017 14:35:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dO6wZ-00019T-Ph for qemu-devel@nongnu.org; Thu, 22 Jun 2017 14:35:07 -0400 Date: Thu, 22 Jun 2017 19:34:58 +0100 From: "Dr. David Alan Gilbert" Message-ID: <20170622183457.GG2100@work-vm> References: <149814756006.27338.8723356702388175951.stgit@bahia> <20170622184255.2d44e3bd@bahia.lab.toulouse-stg.fr.ibm.com> <87injo6jla.fsf@secure.mitica> <20170622172555.GE2100@work-vm> <20170622194649.6d251753@bahia.lab.toulouse-stg.fr.ibm.com> <20170622175012.GF2100@work-vm> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PATCH] Separate function types from opaque types in include/qemu/typedefs.h List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Thomas Huth , Greg Kurz , QEMU Trivial , QEMU Developers , Juan Quintela * Peter Maydell (peter.maydell@linaro.org) wrote: > On 22 June 2017 at 19:08, Thomas Huth wrote: > > On 22.06.2017 19:50, Dr. David Alan Gilbert wrote: > >> Could do; I'm just not finding tiny header files with one or > >> two entries each that useful. > > Well, it means that the bulk of code that doesn't care about the > types doesn't get its compilation fractionally slowed by having > to parse the typedef anyway. In general I think we're drifting > towards "have each .c file get fewer things automatically" rather > than otherwise (eg more finely focused files rather than stuffing > everything into qemu-common.h). At the cost of things getting fractionally slower by including lots more tiny headers. I generally agree in the case where there's a useful chunk, but when it's down to one or two definitions I don't see the point. > > Do we really need these function typedefs at all? IMHO it's quite ugly > > to hide such things in a typedef unless it is really necessary (and in > > this case, it does not seem to be really necessary since it is only used > > in a few places). So what about simply removing the typedefs in this case? > > I find function typedefs much more readable than having the > function-types inline in function arguments and the like. > > This is all fairly rapidly heading into bikeshed territory > though -- in the final analysis I don't think it matters > much what we do. Agreed. Dave > thanks > -- PMM -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK