From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [1/2] edac: pnd2_edac: add code comment for clarification From: "Gustavo A. R. Silva" Message-Id: <20170622192646.GA14339@embeddedgus> Date: Thu, 22 Jun 2017 14:26:46 -0500 To: Tony Luck , Borislav Petkov , Mauro Carvalho Chehab Cc: linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org, "Gustavo A. R. Silva" List-ID: QWRkIGNvZGUgY29tbWVudCB0byBtYWtlIGl0IGNsZWFyIHRoYXQgdGhlIGZhbGwtdGhyb3VnaCBp cyBpbnRlbnRpb25hbC4KCkFkZHJlc3Nlcy1Db3Zlcml0eS1JRDogMTQwMzcyOApTaWduZWQtb2Zm LWJ5OiBHdXN0YXZvIEEuIFIuIFNpbHZhIDxnYXJzaWx2YUBlbWJlZGRlZG9yLmNvbT4KLS0tCiBk cml2ZXJzL2VkYWMvcG5kMl9lZGFjLmMgfCAxICsKIDEgZmlsZSBjaGFuZ2VkLCAxIGluc2VydGlv bigrKQoKZGlmZiAtLWdpdCBhL2RyaXZlcnMvZWRhYy9wbmQyX2VkYWMuYyBiL2RyaXZlcnMvZWRh Yy9wbmQyX2VkYWMuYwppbmRleCAxY2FkNWE5Li5jNTFlYzczIDEwMDY0NAotLS0gYS9kcml2ZXJz L2VkYWMvcG5kMl9lZGFjLmMKKysrIGIvZHJpdmVycy9lZGFjL3BuZDJfZWRhYy5jCkBAIC0xNzQs NiArMTc0LDcgQEAgc3RhdGljIGludCBhcGxfcmRfcmVnKGludCBwb3J0LCBpbnQgb2ZmLCBpbnQg b3AsIHZvaWQgKmRhdGEsIHNpemVfdCBzeiwgY2hhciAqbmEKIAlzd2l0Y2ggKHN6KSB7CiAJY2Fz ZSA4OgogCQlyZXQgPSBzYmlfc2VuZChwb3J0LCBvZmYgKyA0LCBvcCwgKHUzMiAqKShkYXRhICsg NCkpOworCQkvKiBmYWxsIHRocm91Z2ggKi8KIAljYXNlIDQ6CiAJCXJldCA9IHNiaV9zZW5kKHBv cnQsIG9mZiwgb3AsICh1MzIgKilkYXRhKTsKIAkJcG5kMl9wcmludGsoS0VSTl9ERUJVRywgIiVz PSV4JTA4eCByZXQ9JWRcbiIsIG5hbWUsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753774AbdFVT0v (ORCPT ); Thu, 22 Jun 2017 15:26:51 -0400 Received: from gateway33.websitewelcome.com ([192.185.146.21]:11378 "EHLO gateway33.websitewelcome.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753421AbdFVT0u (ORCPT ); Thu, 22 Jun 2017 15:26:50 -0400 Date: Thu, 22 Jun 2017 14:26:46 -0500 From: "Gustavo A. R. Silva" To: Tony Luck , Borislav Petkov , Mauro Carvalho Chehab Cc: linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org, "Gustavo A. R. Silva" Subject: [PATCH 1/2] edac: pnd2_edac: add code comment for clarification Message-ID: <20170622192646.GA14339@embeddedgus> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.23 (2014-03-12) X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 189.152.189.231 X-Exim-ID: 1dO7kd-000M1E-EV X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: (embeddedgus) [189.152.189.231]:48732 X-Source-Auth: garsilva@embeddedor.com X-Email-Count: 5 X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Add code comment to make it clear that the fall-through is intentional. Addresses-Coverity-ID: 1403728 Signed-off-by: Gustavo A. R. Silva --- drivers/edac/pnd2_edac.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/edac/pnd2_edac.c b/drivers/edac/pnd2_edac.c index 1cad5a9..c51ec73 100644 --- a/drivers/edac/pnd2_edac.c +++ b/drivers/edac/pnd2_edac.c @@ -174,6 +174,7 @@ static int apl_rd_reg(int port, int off, int op, void *data, size_t sz, char *na switch (sz) { case 8: ret = sbi_send(port, off + 4, op, (u32 *)(data + 4)); + /* fall through */ case 4: ret = sbi_send(port, off, op, (u32 *)data); pnd2_printk(KERN_DEBUG, "%s=%x%08x ret=%d\n", name, -- 2.5.0