All of lore.kernel.org
 help / color / mirror / Atom feed
From: Brian Norris <computersforpeace@gmail.com>
To: Boris Brezillon <boris.brezillon@free-electrons.com>
Cc: Robert Jarzmik <robert.jarzmik@free.fr>,
	David Woodhouse <dwmw2@infradead.org>,
	Marek Vasut <marek.vasut@gmail.com>,
	Richard Weinberger <richard@nod.at>,
	Cyrille Pitchen <cyrille.pitchen@wedev4u.fr>,
	linux-mtd@lists.infradead.org,
	Kyungmin Park <kyungmin.park@samsung.com>
Subject: Re: [PATCH] mtd: Fallback to ->_read/write_oob() when ->_read/write() is missing
Date: Thu, 22 Jun 2017 14:26:06 -0700	[thread overview]
Message-ID: <20170622212606.GF14148@google.com> (raw)
In-Reply-To: <20170611204255.18622-1-boris.brezillon@free-electrons.com>

On Sun, Jun 11, 2017 at 10:42:55PM +0200, Boris Brezillon wrote:
> Some MTD sublayers/drivers are implementing ->_read/write_oob() and
> providing dummy wrappers for their ->_read/write() implementations.
> Let the core handle this case instead of duplicating the logic.
> 
> Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
> ---
> Note that the goldfish_nand driver (currently in staging) has not been
> updated because some the ops->len != mtd->writesize check done in
> goldfish_nand_read/write_oob() prevents us from using this function as
> a fallback for ->_read/write().
> 
> This behavior is buggy anyway, because the core expects drivers
> implementing ->_read_oob() to support reading more than ->writesize in
> a single call. Probably something we should fix.

Looks OK to me:

Acked-by: Brian Norris <computersforpeace@gmail.com>

This touches NAND drivers more than core MTD stuff, so feel free to take
it in your branch.

  parent reply	other threads:[~2017-06-22 21:26 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-11 20:42 [PATCH] mtd: Fallback to ->_read/write_oob() when ->_read/write() is missing Boris Brezillon
2017-06-12  6:24 ` Robert Jarzmik
2017-06-12  6:45   ` Boris Brezillon
2017-06-13  6:24     ` Robert Jarzmik
2017-06-22 21:26 ` Brian Norris [this message]
2017-06-24 20:12   ` Boris Brezillon
2017-06-25 15:01     ` Boris Brezillon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170622212606.GF14148@google.com \
    --to=computersforpeace@gmail.com \
    --cc=boris.brezillon@free-electrons.com \
    --cc=cyrille.pitchen@wedev4u.fr \
    --cc=dwmw2@infradead.org \
    --cc=kyungmin.park@samsung.com \
    --cc=linux-mtd@lists.infradead.org \
    --cc=marek.vasut@gmail.com \
    --cc=richard@nod.at \
    --cc=robert.jarzmik@free.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.