From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: edac: pnd2_edac: add code comment for clarification and update variable assignment From: "Gustavo A. R. Silva" Message-Id: <20170622220535.GA4896@embeddedgus> Date: Thu, 22 Jun 2017 17:05:35 -0500 To: Borislav Petkov , Tony Luck , Mauro Carvalho Chehab , Qiuxu Zhuo Cc: linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org, "Gustavo A. R. Silva" List-ID: QWRkIGNvZGUgY29tbWVudCB0byBtYWtlIGl0IGNsZWFyIHRoYXQgdGhlIGZhbGwtdGhyb3VnaCBp cyBpbnRlbnRpb25hbCBhbmQsCk9SIHJldCB3aXRoIGl0cyBwcmV2aW91cyB2YWx1ZSB0byBhdm9p ZCBvdmVyd3JpdGluZyBpdC4KCkNjOiBCb3Jpc2xhdiBQZXRrb3YgPGJwQGFsaWVuOC5kZT4KU2ln bmVkLW9mZi1ieTogR3VzdGF2byBBLiBSLiBTaWx2YSA8Z2Fyc2lsdmFAZW1iZWRkZWRvci5jb20+ Ci0tLQogZHJpdmVycy9lZGFjL3BuZDJfZWRhYy5jIHwgMyArKy0KIDEgZmlsZSBjaGFuZ2VkLCAy IGluc2VydGlvbnMoKyksIDEgZGVsZXRpb24oLSkKCmRpZmYgLS1naXQgYS9kcml2ZXJzL2VkYWMv cG5kMl9lZGFjLmMgYi9kcml2ZXJzL2VkYWMvcG5kMl9lZGFjLmMKaW5kZXggMWNhZDVhOS4uNjNj YjMyMyAxMDA2NDQKLS0tIGEvZHJpdmVycy9lZGFjL3BuZDJfZWRhYy5jCisrKyBiL2RyaXZlcnMv ZWRhYy9wbmQyX2VkYWMuYwpAQCAtMTc0LDggKzE3NCw5IEBAIHN0YXRpYyBpbnQgYXBsX3JkX3Jl ZyhpbnQgcG9ydCwgaW50IG9mZiwgaW50IG9wLCB2b2lkICpkYXRhLCBzaXplX3Qgc3osIGNoYXIg Km5hCiAJc3dpdGNoIChzeikgewogCWNhc2UgODoKIAkJcmV0ID0gc2JpX3NlbmQocG9ydCwgb2Zm ICsgNCwgb3AsICh1MzIgKikoZGF0YSArIDQpKTsKKwkJLyogZmFsbCB0aHJvdWdoICovCiAJY2Fz ZSA0OgotCQlyZXQgPSBzYmlfc2VuZChwb3J0LCBvZmYsIG9wLCAodTMyICopZGF0YSk7CisJCXJl dCB8PSBzYmlfc2VuZChwb3J0LCBvZmYsIG9wLCAodTMyICopZGF0YSk7CiAJCXBuZDJfcHJpbnRr KEtFUk5fREVCVUcsICIlcz0leCUwOHggcmV0PSVkXG4iLCBuYW1lLAogCQkJCQlzeiA9PSA4ID8g KigodTMyICopKGRhdGEgKyA0KSkgOiAwLCAqKCh1MzIgKilkYXRhKSwgcmV0KTsKIAkJYnJlYWs7 Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753655AbdFVWFp (ORCPT ); Thu, 22 Jun 2017 18:05:45 -0400 Received: from gateway34.websitewelcome.com ([192.185.148.194]:24354 "EHLO gateway34.websitewelcome.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751546AbdFVWFo (ORCPT ); Thu, 22 Jun 2017 18:05:44 -0400 Date: Thu, 22 Jun 2017 17:05:35 -0500 From: "Gustavo A. R. Silva" To: Borislav Petkov , Tony Luck , Mauro Carvalho Chehab , Qiuxu Zhuo Cc: linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org, "Gustavo A. R. Silva" Subject: [PATCH] edac: pnd2_edac: add code comment for clarification and update variable assignment Message-ID: <20170622220535.GA4896@embeddedgus> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170622164345.Horde.SwUuX9eHAPqyFo5pq1RUp09@gator4166.hostgator.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 189.152.192.143 X-Exim-ID: 1dOAEK-002I4m-6L X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: (embeddedgus) [189.152.192.143]:36288 X-Source-Auth: garsilva@embeddedor.com X-Email-Count: 6 X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Add code comment to make it clear that the fall-through is intentional and, OR ret with its previous value to avoid overwriting it. Cc: Borislav Petkov Signed-off-by: Gustavo A. R. Silva --- drivers/edac/pnd2_edac.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/edac/pnd2_edac.c b/drivers/edac/pnd2_edac.c index 1cad5a9..63cb323 100644 --- a/drivers/edac/pnd2_edac.c +++ b/drivers/edac/pnd2_edac.c @@ -174,8 +174,9 @@ static int apl_rd_reg(int port, int off, int op, void *data, size_t sz, char *na switch (sz) { case 8: ret = sbi_send(port, off + 4, op, (u32 *)(data + 4)); + /* fall through */ case 4: - ret = sbi_send(port, off, op, (u32 *)data); + ret |= sbi_send(port, off, op, (u32 *)data); pnd2_printk(KERN_DEBUG, "%s=%x%08x ret=%d\n", name, sz == 8 ? *((u32 *)(data + 4)) : 0, *((u32 *)data), ret); break; -- 2.5.0