From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boris Brezillon Subject: Re: [PATCH 1/7] drm/bridge: Support hotplugging panel-bridge. Date: Fri, 23 Jun 2017 09:32:55 +0200 Message-ID: <20170623093255.06f22df0@bbrezillon> References: <20170615204130.19255-1-eric@anholt.net> <20170615204130.19255-2-eric@anholt.net> <777ee1b1-e5ce-ea29-8a48-f792354a22d1@codeaurora.org> <871sqkouvr.fsf@eliezer.anholt.net> <8e148170-b626-b426-3c94-b93d2746f4ce@codeaurora.org> <871sqe7ei0.fsf@eliezer.anholt.net> <20170622112332.7ec7b65c@bbrezillon> <7ce4f741-309a-2eaa-381c-8033f089651a@samsung.com> <20170622144150.1663f649@bbrezillon> <004fe335-3f36-38e6-7a3e-0ad0623b29cf@samsung.com> <20170622153435.556fdaef@bbrezillon> <4a64ad72-1e3b-d9e9-4800-e543264fa8f7@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <4a64ad72-1e3b-d9e9-4800-e543264fa8f7@samsung.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Andrzej Hajda Cc: Mark Rutland , devicetree@vger.kernel.org, Linux Kernel Mailing List , "dri-devel@lists.freedesktop.org" , Philippe Cornu , Rob Herring , Thierry Reding , Laurent Pinchart List-Id: devicetree@vger.kernel.org T24gRnJpLCAyMyBKdW4gMjAxNyAwOToyMjoxNSArMDIwMApBbmRyemVqIEhhamRhIDxhLmhhamRh QHNhbXN1bmcuY29tPiB3cm90ZToKCj4gT24gMjIuMDYuMjAxNyAxNTozNCwgQm9yaXMgQnJlemls bG9uIHdyb3RlOgo+ID4gT24gVGh1LCAyMiBKdW4gMjAxNyAxNToxNjo0NyArMDIwMAo+ID4gQW5k cnplaiBIYWpkYSA8YS5oYWpkYUBzYW1zdW5nLmNvbT4gd3JvdGU6Cj4gPiAgCj4gPj4gT24gMjIu MDYuMjAxNyAxNDo0MSwgQm9yaXMgQnJlemlsbG9uIHdyb3RlOiAgCj4gPj4+IE9uIFRodSwgMjIg SnVuIDIwMTcgMTQ6Mjk6MDcgKzAyMDAKPiA+Pj4gQW5kcnplaiBIYWpkYSA8YS5oYWpkYUBzYW1z dW5nLmNvbT4gd3JvdGU6Cj4gPj4+ICAgIAo+ID4+Pj4gT24gMjIuMDYuMjAxNyAxMToyMywgQm9y aXMgQnJlemlsbG9uIHdyb3RlOiAgICAKPiA+Pj4+PiBPbiBUaHUsIDIyIEp1biAyMDE3IDEzOjQ3 OjQzICswNTMwCj4gPj4+Pj4gQXJjaGl0IFRhbmVqYSA8YXJjaGl0dEBjb2RlYXVyb3JhLm9yZz4g d3JvdGU6Cj4gPj4+Pj4gICAgICAKPiA+Pj4+Pj4gT24gMDYvMjIvMjAxNyAwMToyMCBQTSwgQmVu amFtaW4gR2FpZ25hcmQgd3JvdGU6ICAgICAgCj4gPj4+Pj4+PiAyMDE3LTA2LTIwIDE5OjMxIEdN VCswMjowMCBFcmljIEFuaG9sdCA8ZXJpY0BhbmhvbHQubmV0PjogICAgICAgIAo+ID4+Pj4+Pj4+ IEFyY2hpdCBUYW5lamEgPGFyY2hpdHRAY29kZWF1cm9yYS5vcmc+IHdyaXRlczoKPiA+Pj4+Pj4+ PiAgICAgICAgCj4gPj4+Pj4+Pj4+IE9uIDA2LzE2LzIwMTcgMDg6MTMgUE0sIEVyaWMgQW5ob2x0 IHdyb3RlOiAgICAgICAgCj4gPj4+Pj4+Pj4+PiBBcmNoaXQgVGFuZWphIDxhcmNoaXR0QGNvZGVh dXJvcmEub3JnPiB3cml0ZXM6Cj4gPj4+Pj4+Pj4+PiAgICAgICAgCj4gPj4+Pj4+Pj4+Pj4gT24g MDYvMTYvMjAxNyAwMjoxMSBBTSwgRXJpYyBBbmhvbHQgd3JvdGU6ICAgICAgICAKPiA+Pj4+Pj4+ Pj4+Pj4gSWYgdGhlIHBhbmVsLWJyaWRnZSBpcyBiZWluZyBzZXQgdXAgYWZ0ZXIgdGhlIGRybV9t b2RlX2NvbmZpZ19yZXNldCgpLAo+ID4+Pj4+Pj4+Pj4+PiB0aGVuIHRoZSBjb25uZWN0b3IncyBz dGF0ZSB3b3VsZCBuZXZlciBnZXQgaW5pdGlhbGl6ZWQsIGFuZCB3ZSdkCj4gPj4+Pj4+Pj4+Pj4+ IGRlcmVmZXJlbmNlIHRoZSBOVUxMIGluIHRoZSBob3RwbHVnIHBhdGguICBXZSBhbHNvIG5lZWQg dG8gcmVnaXN0ZXIKPiA+Pj4+Pj4+Pj4+Pj4gdGhlIGNvbm5lY3Rvciwgc28gdGhhdCB1c2Vyc3Bh Y2UgY2FuIGdldCBhdCBpdC4KPiA+Pj4+Pj4+Pj4+Pj4gICAgICAgIAo+ID4+Pj4+Pj4+Pj4+IFNo b3VsZG4ndCB0aGUgS01TIGRyaXZlciBtYWtlIHN1cmUgdGhlIHBhbmVsLWJyaWRnZSBpcyBzZXQg dXAgYmVmb3JlCj4gPj4+Pj4+Pj4+Pj4gZHJtX21vZGVfY29uZmlnX3Jlc2V0PyBJcyBpdCB0aGUg Y2FzZSB3aGVuIHdlJ3JlIGluc2VydGluZyB0aGUKPiA+Pj4+Pj4+Pj4+PiBwYW5lbC1icmlkZ2Ug ZHJpdmVyIGFzIGEgbW9kdWxlPwo+ID4+Pj4+Pj4+Pj4+Cj4gPj4+Pj4+Pj4+Pj4KPiA+Pj4+Pj4+ Pj4+PiBBbGwgdGhlIGNvbm5lY3RvcnMgdGhhdCBoYXZlIGJlZW4gYWRkZWQgYXJlIHJlZ2lzdGVy ZWQgYXV0b21hdGljYWxseQo+ID4+Pj4+Pj4+Pj4+IHdoZW4gZHJtX2Rldl9yZWdpc3RlcigpIGlz IGNhbGxlZCBieSB0aGUgS01TIGRyaXZlci4gUmVnaXN0ZXJpbmcgYQo+ID4+Pj4+Pj4+Pj4+IGNv bm5lY3RvciBpbiB0aGUgbWlkZGxlIG9mIHNldHRpbmcgdXAgb3VyIGRyaXZlciBpcyBwcm9uZSB0 byByYWNlCj4gPj4+Pj4+Pj4+Pj4gY29uZGl0aW9ucyBpZiB0aGUgdXNlcnNwYWNlIGRlY2lkZXMg dG8gdXNlIHRoZW0gaW1tZWRpYXRlbHkuICAgICAgICAKPiA+Pj4+Pj4+Pj4+IFllYWgsIHRoaXMg aXMgZml4aW5nIGluaXRpYWxpemluZyBwYW5lbF9icmlkZ2UgYXQgRFNJIGhvc3RfYXR0YWNoIHRp bWUsCj4gPj4+Pj4+Pj4+PiB3aGljaCBpbiB0aGUgY2FzZSBvZiBhIHBhbmVsIG1vZHVsZSB0aGF0 IGNyZWF0ZXMgdGhlIERTSSBkZXZpY2UKPiA+Pj4+Pj4+Pj4+IChhZHY3NTMzLXN0eWxlLCBsaWtl IHlvdSBzYWlkIEkgc2hvdWxkIHVzZSBhcyBhIHJlZmVyZW5jZSkgd2lsbCBiZSBhZnRlcgo+ID4+ Pj4+Pj4+Pj4gZHJtX21vZGVfY29uZmlnX3Jlc2V0KCkgYW5kIGRybV9kZXZfcmVnaXN0ZXIoKS4g ICAgICAgIAo+ID4+Pj4+Pj4+PiBPa2F5LiBJbiB0aGUgY2FzZSBvZiB0aGUgbXNtIGttcyBkcml2 ZXIsIHdlIGRlZmVyIHByb2JlIHVudGlsIHRoZQo+ID4+Pj4+Pj4+PiBhZHY3NTMzIG1vZHVsZSBp cyBpbnNlcnRlZCwgb25seSB0aGVuIHdlIHByb2NlZWQgdG8gZHJtX21vZGVfY29uZmlnX3Jlc2V0 KCkKPiA+Pj4+Pj4+Pj4gYW5kIGRybV9kZXZfcmVnaXN0ZXIoKS4gSSBhc3N1bWVkIHRoaXMgd2Fz IHRoZSBnZW5lcmFsIHByYWN0aWNlIGZvbGxvd2VkIGJ5Cj4gPj4+Pj4+Pj4+IG1vc3Qga21zIGRy aXZlcnMuIEkuLGUgdGhlIGttcyBkcml2ZXIgZGVmZXJzIHByb2JlIHVudGlsIGFsbCBjb25uZWN0 b3IKPiA+Pj4+Pj4+Pj4gcmVsYXRlZCBtb2R1bGVzIGFyZSBpbnNlcnRlZCwgYW5kIG9ubHkgdGhl biBwcm9jZWVkIHRvIGNyZWF0ZSBhIGRybSBkZXZpY2UuICAgICAgICAKPiA+Pj4+Pj4+PiBUaGUg cHJvYmxlbSwgdGhvdWdoLCBpcyB0aGUgcGFuZWwgZHJpdmVyIG5lZWRzIHRoZSBNSVBJIERTSSBo b3N0IHRvCj4gPj4+Pj4+Pj4gZXhpc3QgdG8gY2FsbCBtaXBpX2RzaV9kZXZpY2VfcmVnaXN0ZXJf ZnVsbCgpIGR1cmluZyB0aGUgcHJvYmUgcHJvY2Vzcy4KPiA+Pj4+Pj4+PiBUaGUgYWR2NzUzMyBk cml2ZXIgZ2V0cyBhcm91bmQgdGhpcyBieSByZWdpc3RlcmluZyB0aGUgRFNJIGRldmljZSBpbiB0 aGUKPiA+Pj4+Pj4+PiBicmlkZ2UgYXR0YWNoIHN0ZXAsIGJ1dCBkcm1fcGFuZWwgZG9lc24ndCBo YXZlIGFuIGF0dGFjaCBzdGVwLiAgICAgICAgCj4gPj4+Pj4+IEknbSBub3Qgc3VyZSBob3cgd2Ug Y2FuIGdldCBhcm91bmQgdGhpcy4gV2UgaGFkIGRpc2N1c3Npb24gYWJvdXQgdGhpcyBvbiBpcmMK PiA+Pj4+Pj4gcmVjZW50bHksIGJ1dCBjb3VsZG4ndCBjb21lIHVwIHdpdGggYSBnb29kIGNvbmNs dXNpb24uIFdlIGNvdWxkIGNvbWUgdXAgd2l0aCBhCj4gPj4+Pj4+IHBhbmVsX2F0dGFjaCgpIGNh bGxiYWNrIHRvIG1ha2UgaXQgc2ltaWxhciB0byBicmlkZ2VzLCBidXQgdGhhdCdzIGp1c3QgdXMg YXZvaWRpbmcKPiA+Pj4+Pj4gdGhlIHJlYWwgaXNzdWUuICAgICAgCj4gPj4+Pj4gSG93IGFib3V0 IG1ha2luZyBEU0kgZGV2IHJlZ2lzdHJhdGlvbiBmdWxseSBhc3luY2hyb25vdXMsIHRoYXQgaXMs IERTSQo+ID4+Pj4+IGRldnMgZGVjbGFyZWQgaW4gdGhlIERUIHVuZGVyIHRoZSBEU0kgaG9zdCBu b2RlIHdpbGwgYmUKPiA+Pj4+PiByZWdpc3RlcmVkL2F0dGFjaGVkIGF0IHByb2JlIHRpbWUsIGFu ZCBkZXZzIHVzaW5nIGFub3RoZXIgY29udHJvbCBidXMKPiA+Pj4+PiAobGlrZSB0aGUgYWR2NzUz MyBjb250cm9sbGVyIG92ZXIgaTJjKSB3aWxsIGJlIHJlZ2lzdGVyZWQgYWZ0ZXJ3YXJkcy4KPiA+ Pj4+Pgo+ID4+Pj4+IFRoYXQgaW1wbGllcyBtb3ZpbmcgdGhlIGRybV9icmlnZSByZWdpc3RyYXRp b24gbG9naWMgb3V0c2lkZSBvZiB0aGUgRFNJCj4gPj4+Pj4gaG9zdCAtPnByb2JlKCkgcGF0aC4g VGhlIGlkZWEgd291bGQgYmUgdG8gY2hlY2sgaWYgYWxsIGRldnMgY29ubmVjdGVkCj4gPj4+Pj4g dG8gdGhlIERTSSBidXMgYXJlIHJlYWR5IGF0IGRzaV9ob3N0LT5hdHRhY2goKSB0aW1lLiBJZiB0 aGV5IGFyZSwgd2UKPiA+Pj4+PiBjYW4gZmluYWxseSByZWdpc3RlciB0aGUgWFhYIC0+IERTSSBi cmlkZ2UuIElmIHRoZXkncmUgbm90IChiZWNhdXNlCj4gPj4+Pj4gc29tZSBkZXZzIGNvbm5lY3Rl ZCB0byB0aGUgRFNJIGJ1cyBoYXZlIG5vdCBiZWVuIHByb2JlZCB5ZXQpLCB0aGVuIHdlCj4gPj4+ Pj4gZG8gbm90IHJlZ2lzdGVyIHRoZSBkcm1fYnJpZGdlIGFuZCB3YWl0IGZvciB0aGUgbmV4dCBk c2lfaG9zdC0+YXR0YWNoKCkKPiA+Pj4+PiBldmVudC4gICAgICAKPiA+Pj4+IEkgZ3Vlc3MgeW91 IGFzc3VtZXMgdGhhdCBkc2ktaG9zdCBrbm93cyBhbGwgZGV2cyBjb25uZWN0ZWQgdG8gaXQsIHRo YW5rcyB0bzoKPiA+Pj4+IC0gc3Vibm9kZXMgb2YgdGhlIGhvc3QgLSBpZS4gZGV2aWNlcyBjb250 cm9sbGVkIHZpYSBkc2kgYnVzLAo+ID4+Pj4gLSBncmFwaCBsaW5rcyBmcm9tIGhvc3QgcG9ydHMv ZW5kcG9pbnRzIC0gaWUuIGRldmljZXMgY29udHJvbGxlZCBieQo+ID4+Pj4gb3RoZXIgYnVzZXMs IGZvciBleGFtcGxlIGFkdjc1MzMuICAgIAo+ID4+PiBZZXAsIGJ1dCBJIHRoaW5rIHRoYXQncyBh bHJlYWR5IGEgcmVxdWlyZW1lbnQgd2hlbiBwb3B1bGF0aW5nIGRldmljZXMKPiA+Pj4gd2l0aCB0 aGUgT0YgZ3JhcGggbWV0aG9kIChpZiBvbmUgb2YgdGhlIERTSSBvdXRwdXQgZW5kcG9pbnQgZG9l cyBub3QKPiA+Pj4gaGF2ZSBhIGRybV9icmlkZ2UvcGFuZWwgYXR0YWNoZWQgdG8gaXQsIHRoZSBE U0kgaG9zdCBkcml2ZXIgcmV0dXJucwo+ID4+PiAtRVBST0JFX0RFRkVSKS4KPiA+Pj4gICAgCj4g Pj4+PiBJIHdvdWxkIHNlcGFyYXRlIGJvdGggYWJzdHJhY3Rpb25zIHRvIG1ha2UgaXQgbW9yZSBj bGVhcjoKPiA+Pj4+IDEuIE1JUEkgYnVzIHNob3VsZCBiZSByZWdpc3RlcmVkIGVhcmx5IC0gdG8g YWxsb3cgY3JlYXRlL2JpbmQgZGV2aWNlcyBvbiBpdCwgICAgCj4gPj4+IEV4YWN0bHkuCj4gPj4+ ICAgIAo+ID4+Pj4gMi4gZHJtX2JyaWRnZSBzaG91bGQgYmUgcmVnaXN0ZXJlZCBvbmx5IGlmIGFs bCByZXF1aXJlZCBzaW5rcwo+ID4+Pj4gKGJyaWRnZXMvcGFuZWxzKSBhcmUgcmVnaXN0ZXJlZC4g ICAgCj4gPj4+IFRoYXQncyB0cnVlLCB1bnRpbCB3ZSBmaW5kIGEgc29sdXRpb24gdG8gc3VwcG9y dCBhZGQgRFJNIGJyaWRnZSBob3RwbHVnLgo+ID4+PiAgICAKPiA+Pj4+IEZpcnN0IHBvaW50IHNl ZW1zIE9LLCBJIGFtIG5vdCBzdXJlIGFib3V0IHRoZSAybmQgb25lIC0gaWYgdXNlZAo+ID4+Pj4g Y29uc2lzdGVudGx5LCBpdCB3b3VsZCByZXF1aXJlIGJ1aWxkaW5nIHBpcGVsaW5lIGZyb20gc2lu ayB0byBzb3VyY2UuICAgIAo+ID4+PiBZZXMuICAgIAo+ID4+IFNpbmNlIGRybV9icmlkZ2VfYXR0 YWNoIHJlcXVpcmVzIGVuY29kZXIgdG8gYmUgbm90IG51bGwgcGlwZWxpbmUKPiA+PiBjcmVhdGlv biB3b3VsZCBiZSBwYWluZnVsOgo+ID4+IDEuIEV2ZXJ5IGRyaXZlciBtdXN0IGNhbGwgZHJtX29m X2ZpbmRfcGFuZWxfb3JfYnJpZGdlIG9uIHNpbmsocykgYmVmb3JlCj4gPj4gcmVnaXN0ZXJpbmcg YnJpZGdlIGFuZCBjYWNoZSB0aGUgcmVzdWx0IGZvciBsYXRlciB1c2UuICAKPiA+IFNob3VsZG4n dCBiZSBoYXJkIHRvIGRvIHNpbmNlIGRzaV9ob3N0LT5hdHRhY2goKSBpcyBjYWxsZWQgZWFjaCB0 aW1lIGEKPiA+IHNpbmsgaXMgYWRkZWQgKGFuZCByZWFkeSB0byB1c2UpLiBBbGwgeW91IG5lZWQg dG8gZG8gaXMgcmV0cmlldmUgdGhlCj4gPiBicmlkZ2UgcG9pbnRlciBhbmQgcHV0IGl0IGluIGEg bGlzdCBlbWJlZGRlZCBpbiB0aGUgRFNJIGhvc3QgcHJpdgo+ID4gc3RydWN0LiBPbmNlIHlvdSBo YXZlIGFsbCBzaW5rcyBhZGRlZCB0byB0aGlzIGxpc3QgKGNhbiBiZSBjaGVja2VkIGJ5Cj4gPiBj b3VudGluZyB0aGUgbnVtYmVyIG9mIGVuZHBvaW50cyBhbmQgRFNJIGRldnMgYXQgcHJvYmUgdGlt ZSksIHlvdSBjYW4KPiA+IHJlZ2lzdGVyIHRoZSBEU0kgYnJpZGdlIGFuZCB3YWl0IGZvciBzb21l b25lIHRvIGNhbGwgLT5hdHRhY2goKSBvbiBpdC4KPiA+Cj4gPiBJbiB0aGUgLT5hdHRhY2goKSBo b29rIG9mIHRoZSBEU0kgYnJpZGdlLCB5b3UnbGwgaGF2ZSB0byBhdHRhY2ggYWxsCj4gPiBzaW5r cyBzdG9yZWQgaW4gdGhlIGxpc3QgdG8gdGhlIERTSSBicmlkZ2UuIE5vdGUgdGhhdCByaWdodCBu b3cgeW91IGhhdmUKPiA+IGEgMToxIHJlbGF0aW9uc2hpcCwgd2hpY2ggcHJldmVudHMgeW91IGZy b20gaGF2aW5nIG9uZSBEU0kgYnJpZGdlIHRoYXQKPiA+IGNhbiBhdHRhY2ggdG8gZGlmZmVyZW50 IGJyaWRnZXMgYXZhaWxhYmxlIG9uIHRoZSBEU0kgYnVzIChlLmcuIERTSSAtPgo+ID4gSERNSSBi cmlkZ2Ugb24gY2hhbm5lbCAwIGFuZCBEU0kgLT4gTFZEUyBicmlkZ2Ugb24gY2hhbm5lbCAxKS4K PiA+ICAKPiA+PiAyLiBBZnRlciBlbmNvZGVyIGZpbmRzIGRpcmVjdGx5IGNvbm5lY3RlZCBicmlk Z2UsIGl0IGNhbiBhdHRhY2ggaXQuICAKPiA+IEkgZG9uJ3QgZ2V0IHRoYXQgb25lLiAgCj4gCj4g SWYgeW91IGhhdmUgcGlwZWxpbmU6Cj4gCj4gY3J0YyAtPiBlbmNvZGVyIC0+IGJyaWRnZTEgLT4g YnJpZGdlMiAtPiBwYW5lbAo+IAo+IGVuY29kZXIga25vd3Mgb25seSBhYm91dCBicmlkZ2UxLCBh bmQgbXVzdCB3YWl0IHRpbGwgaXQgaXMgcmVnaXN0ZXJlZCwKPiBiZWZvcmUgYXR0YWNoaW5nIGl0 LAo+IGFuZCBhc3N1bWluZyBicmlkZ2UgbXVzdCB3YWl0IGZvciBpdHMgc2lua3MgYmVmb3JlIHJl Z2lzdHJhdGlvbiB0aGUKPiB3aG9sZSBwaXBlbGluZSBjb25zdHJ1Y3Rpb24gd2lsbCBsb29rIGxp a2U6Cj4gCj4gMC4gZW5jb2RlciB3YWl0cyBmb3IgYnJpZGdlMSwgYnJpZGdlMSB3YWl0cyBmb3Ig YnJpZGdlMiwgYnJpZGdlMiB3YWl0cwo+IGZvciBwYW5lbCwgdXN1YWxseSBieSBkZWZlcnJpbmcu Cj4gMS4gcGFuZWwgaXMgcmVnaXN0ZXJlZC4KPiAyLiBicmlkZ2UyIGZpbmRzIHBhbmVsIGFuZCBp cyByZWdpc3RlcmVkLgo+IDMuIGJyaWRnZTEgZmluZHMgYnJpZGdlMiBhbmQgaXMgcmVnaXN0ZXJl ZC4KPiA0LiBlbmNvZGVyIGZpbmRzIGJyaWRnZTEgYW5kIGF0dGFjaCBpdCB0byBlbmNvZGVyLAo+ IDRhLiBicmlkZ2UxLT5hdHRhY2goKSBhdHRhY2ggYnJpZGdlMiB0byBlbmNvZGVyIGFmdGVyIGJy aWRnZTEKPiA0Yi4gYnJpZGdlMi0+YXR0YWNoKCkgYXR0YWNoIHBhbmVsIHRvIGJyaWRnZTIKPiAK PiBUaGlzIGlzIHdoeSBpdCBzZWVtcyBmb3IgbWUgcXVpdGUgY29tcGxpY2F0ZWQuCgpCdXQgdGhh dCdzIGFscmVhZHkgd2hhdCBoYXBwZW5zIGluIG1vc3QgZHJpdmVycyB0b2RheSAocHJvYmFibHkg YmVjYXVzZQp0aGluZ3Mgd2VyZSBkZXNpZ25lZCBiZWZvcmUgY29ubmVjdG9yIGhvdHBsdWcgd2Fz IHN1cHBvcnRlZCkuIEkgYWdyZWUsCml0J3MgZmFyIGZyb20gaWRlYWwsIGJ1dCB1bnRpbCB3ZSBn ZXQgZnVsbC1ob3RwbHVnIHN1cHBvcnQsIHdlJ2xsIGhhdmUKdG8gcmVseSBvbiBzdWNoIGhhY2tz LgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRl dmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8v bGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753615AbdFWHc7 (ORCPT ); Fri, 23 Jun 2017 03:32:59 -0400 Received: from mail.free-electrons.com ([62.4.15.54]:33882 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752066AbdFWHc5 (ORCPT ); Fri, 23 Jun 2017 03:32:57 -0400 Date: Fri, 23 Jun 2017 09:32:55 +0200 From: Boris Brezillon To: Andrzej Hajda Cc: Archit Taneja , Laurent Pinchart , Mark Rutland , devicetree@vger.kernel.org, Linux Kernel Mailing List , "dri-devel@lists.freedesktop.org" , Philippe Cornu , Rob Herring , Thierry Reding Subject: Re: [PATCH 1/7] drm/bridge: Support hotplugging panel-bridge. Message-ID: <20170623093255.06f22df0@bbrezillon> In-Reply-To: <4a64ad72-1e3b-d9e9-4800-e543264fa8f7@samsung.com> References: <20170615204130.19255-1-eric@anholt.net> <20170615204130.19255-2-eric@anholt.net> <777ee1b1-e5ce-ea29-8a48-f792354a22d1@codeaurora.org> <871sqkouvr.fsf@eliezer.anholt.net> <8e148170-b626-b426-3c94-b93d2746f4ce@codeaurora.org> <871sqe7ei0.fsf@eliezer.anholt.net> <20170622112332.7ec7b65c@bbrezillon> <7ce4f741-309a-2eaa-381c-8033f089651a@samsung.com> <20170622144150.1663f649@bbrezillon> <004fe335-3f36-38e6-7a3e-0ad0623b29cf@samsung.com> <20170622153435.556fdaef@bbrezillon> <4a64ad72-1e3b-d9e9-4800-e543264fa8f7@samsung.com> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 23 Jun 2017 09:22:15 +0200 Andrzej Hajda wrote: > On 22.06.2017 15:34, Boris Brezillon wrote: > > On Thu, 22 Jun 2017 15:16:47 +0200 > > Andrzej Hajda wrote: > > > >> On 22.06.2017 14:41, Boris Brezillon wrote: > >>> On Thu, 22 Jun 2017 14:29:07 +0200 > >>> Andrzej Hajda wrote: > >>> > >>>> On 22.06.2017 11:23, Boris Brezillon wrote: > >>>>> On Thu, 22 Jun 2017 13:47:43 +0530 > >>>>> Archit Taneja wrote: > >>>>> > >>>>>> On 06/22/2017 01:20 PM, Benjamin Gaignard wrote: > >>>>>>> 2017-06-20 19:31 GMT+02:00 Eric Anholt : > >>>>>>>> Archit Taneja writes: > >>>>>>>> > >>>>>>>>> On 06/16/2017 08:13 PM, Eric Anholt wrote: > >>>>>>>>>> Archit Taneja writes: > >>>>>>>>>> > >>>>>>>>>>> On 06/16/2017 02:11 AM, Eric Anholt wrote: > >>>>>>>>>>>> If the panel-bridge is being set up after the drm_mode_config_reset(), > >>>>>>>>>>>> then the connector's state would never get initialized, and we'd > >>>>>>>>>>>> dereference the NULL in the hotplug path. We also need to register > >>>>>>>>>>>> the connector, so that userspace can get at it. > >>>>>>>>>>>> > >>>>>>>>>>> Shouldn't the KMS driver make sure the panel-bridge is set up before > >>>>>>>>>>> drm_mode_config_reset? Is it the case when we're inserting the > >>>>>>>>>>> panel-bridge driver as a module? > >>>>>>>>>>> > >>>>>>>>>>> > >>>>>>>>>>> All the connectors that have been added are registered automatically > >>>>>>>>>>> when drm_dev_register() is called by the KMS driver. Registering a > >>>>>>>>>>> connector in the middle of setting up our driver is prone to race > >>>>>>>>>>> conditions if the userspace decides to use them immediately. > >>>>>>>>>> Yeah, this is fixing initializing panel_bridge at DSI host_attach time, > >>>>>>>>>> which in the case of a panel module that creates the DSI device > >>>>>>>>>> (adv7533-style, like you said I should use as a reference) will be after > >>>>>>>>>> drm_mode_config_reset() and drm_dev_register(). > >>>>>>>>> Okay. In the case of the msm kms driver, we defer probe until the > >>>>>>>>> adv7533 module is inserted, only then we proceed to drm_mode_config_reset() > >>>>>>>>> and drm_dev_register(). I assumed this was the general practice followed by > >>>>>>>>> most kms drivers. I.,e the kms driver defers probe until all connector > >>>>>>>>> related modules are inserted, and only then proceed to create a drm device. > >>>>>>>> The problem, though, is the panel driver needs the MIPI DSI host to > >>>>>>>> exist to call mipi_dsi_device_register_full() during the probe process. > >>>>>>>> The adv7533 driver gets around this by registering the DSI device in the > >>>>>>>> bridge attach step, but drm_panel doesn't have an attach step. > >>>>>> I'm not sure how we can get around this. We had discussion about this on irc > >>>>>> recently, but couldn't come up with a good conclusion. We could come up with a > >>>>>> panel_attach() callback to make it similar to bridges, but that's just us avoiding > >>>>>> the real issue. > >>>>> How about making DSI dev registration fully asynchronous, that is, DSI > >>>>> devs declared in the DT under the DSI host node will be > >>>>> registered/attached at probe time, and devs using another control bus > >>>>> (like the adv7533 controller over i2c) will be registered afterwards. > >>>>> > >>>>> That implies moving the drm_brige registration logic outside of the DSI > >>>>> host ->probe() path. The idea would be to check if all devs connected > >>>>> to the DSI bus are ready at dsi_host->attach() time. If they are, we > >>>>> can finally register the XXX -> DSI bridge. If they're not (because > >>>>> some devs connected to the DSI bus have not been probed yet), then we > >>>>> do not register the drm_bridge and wait for the next dsi_host->attach() > >>>>> event. > >>>> I guess you assumes that dsi-host knows all devs connected to it, thanks to: > >>>> - subnodes of the host - ie. devices controlled via dsi bus, > >>>> - graph links from host ports/endpoints - ie. devices controlled by > >>>> other buses, for example adv7533. > >>> Yep, but I think that's already a requirement when populating devices > >>> with the OF graph method (if one of the DSI output endpoint does not > >>> have a drm_bridge/panel attached to it, the DSI host driver returns > >>> -EPROBE_DEFER). > >>> > >>>> I would separate both abstractions to make it more clear: > >>>> 1. MIPI bus should be registered early - to allow create/bind devices on it, > >>> Exactly. > >>> > >>>> 2. drm_bridge should be registered only if all required sinks > >>>> (bridges/panels) are registered. > >>> That's true, until we find a solution to support add DRM bridge hotplug. > >>> > >>>> First point seems OK, I am not sure about the 2nd one - if used > >>>> consistently, it would require building pipeline from sink to source. > >>> Yes. > >> Since drm_bridge_attach requires encoder to be not null pipeline > >> creation would be painful: > >> 1. Every driver must call drm_of_find_panel_or_bridge on sink(s) before > >> registering bridge and cache the result for later use. > > Shouldn't be hard to do since dsi_host->attach() is called each time a > > sink is added (and ready to use). All you need to do is retrieve the > > bridge pointer and put it in a list embedded in the DSI host priv > > struct. Once you have all sinks added to this list (can be checked by > > counting the number of endpoints and DSI devs at probe time), you can > > register the DSI bridge and wait for someone to call ->attach() on it. > > > > In the ->attach() hook of the DSI bridge, you'll have to attach all > > sinks stored in the list to the DSI bridge. Note that right now you have > > a 1:1 relationship, which prevents you from having one DSI bridge that > > can attach to different bridges available on the DSI bus (e.g. DSI -> > > HDMI bridge on channel 0 and DSI -> LVDS bridge on channel 1). > > > >> 2. After encoder finds directly connected bridge, it can attach it. > > I don't get that one. > > If you have pipeline: > > crtc -> encoder -> bridge1 -> bridge2 -> panel > > encoder knows only about bridge1, and must wait till it is registered, > before attaching it, > and assuming bridge must wait for its sinks before registration the > whole pipeline construction will look like: > > 0. encoder waits for bridge1, bridge1 waits for bridge2, bridge2 waits > for panel, usually by deferring. > 1. panel is registered. > 2. bridge2 finds panel and is registered. > 3. bridge1 finds bridge2 and is registered. > 4. encoder finds bridge1 and attach it to encoder, > 4a. bridge1->attach() attach bridge2 to encoder after bridge1 > 4b. bridge2->attach() attach panel to bridge2 > > This is why it seems for me quite complicated. But that's already what happens in most drivers today (probably because things were designed before connector hotplug was supported). I agree, it's far from ideal, but until we get full-hotplug support, we'll have to rely on such hacks.