diff for duplicates of <20170623103752.auujqgr3toppalgm@linux.intel.com> diff --git a/a/1.txt b/N1/1.txt index f165b09..4388c13 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -47,7 +47,7 @@ Please just do a function that takes crypto ID. > + > + for (i = 0; i < ARRAY_SIZE(chip->active_banks) && > + chip->active_banks[i].alg_id != TPM2_ALG_ERROR; i++) -> + if (chip->active_banks[i].alg_id = algo) +> + if (chip->active_banks[i].alg_id == algo) > + return chip->active_banks[i].digest_size; > + > + /* Callers should have checked which algorithms the TPM supports, @@ -81,11 +81,11 @@ Please just do a function that takes crypto ID. > + u32 first_digest_size; > + int i, j; > + -> + if (count = 0) +> + if (count == 0) > + return -EINVAL; > > chip = tpm_chip_find_get(chip_num); -> if (chip = NULL) +> if (chip == NULL) > return -ENODEV; > > + first_digest_size = tpm_get_digest_size(chip, digests[0].alg_id); @@ -100,7 +100,7 @@ Please just do a function that takes crypto ID. > + u32 cur_digest_size = first_digest_size; > + > + for (j = 0; j < count; j++) { -> + if (digests[j].alg_id = bank->alg_id) { +> + if (digests[j].alg_id == bank->alg_id) { > + cur_digest = digests[j].digest; > + cur_digest_size = bank->digest_size; > + break; @@ -238,5 +238,9 @@ Please just do a function that takes crypto ID. > engaging tech sites, Slashdot.org! http://sdm.link/slashdot > _______________________________________________ > tpmdd-devel mailing list -> tpmdd-devel@lists.sourceforge.net +> tpmdd-devel at lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/tpmdd-devel +-- +To unsubscribe from this list: send the line "unsubscribe linux-security-module" in +the body of a message to majordomo at vger.kernel.org +More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/a/content_digest b/N1/content_digest index d509dd4..639302b 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,8 +1,8 @@ "ref\020170621142941.32674-1-roberto.sassu@huawei.com\0" "ref\020170621142941.32674-7-roberto.sassu@huawei.com\0" - "From\0Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>\0" - "Subject\0Re: [tpmdd-devel] [PATCH v3 6/6] tpm: pass multiple digests to tpm_pcr_extend()\0" - "Date\0Fri, 23 Jun 2017 10:37:52 +0000\0" + "From\0jarkko.sakkinen@linux.intel.com (Jarkko Sakkinen)\0" + "Subject\0[tpmdd-devel] [PATCH v3 6/6] tpm: pass multiple digests to tpm_pcr_extend()\0" + "Date\0Fri, 23 Jun 2017 12:37:52 +0200\0" "To\0linux-security-module@vger.kernel.org\0" "\00:1\0" "b\0" @@ -55,7 +55,7 @@ "> +\n" "> +\tfor (i = 0; i < ARRAY_SIZE(chip->active_banks) &&\n" "> +\t chip->active_banks[i].alg_id != TPM2_ALG_ERROR; i++)\n" - "> +\t\tif (chip->active_banks[i].alg_id = algo)\n" + "> +\t\tif (chip->active_banks[i].alg_id == algo)\n" "> +\t\t\treturn chip->active_banks[i].digest_size;\n" "> +\n" "> +\t/* Callers should have checked which algorithms the TPM supports,\n" @@ -89,11 +89,11 @@ "> +\tu32 first_digest_size;\n" "> +\tint i, j;\n" "> +\n" - "> +\tif (count = 0)\n" + "> +\tif (count == 0)\n" "> +\t\treturn -EINVAL;\n" "> \n" "> \tchip = tpm_chip_find_get(chip_num);\n" - "> \tif (chip = NULL)\n" + "> \tif (chip == NULL)\n" "> \t\treturn -ENODEV;\n" "> \n" "> +\tfirst_digest_size = tpm_get_digest_size(chip, digests[0].alg_id);\n" @@ -108,7 +108,7 @@ "> +\t\t\tu32 cur_digest_size = first_digest_size;\n" "> +\n" "> +\t\t\tfor (j = 0; j < count; j++) {\n" - "> +\t\t\t\tif (digests[j].alg_id = bank->alg_id) {\n" + "> +\t\t\t\tif (digests[j].alg_id == bank->alg_id) {\n" "> +\t\t\t\t\tcur_digest = digests[j].digest;\n" "> +\t\t\t\t\tcur_digest_size = bank->digest_size;\n" "> +\t\t\t\t\tbreak;\n" @@ -246,7 +246,11 @@ "> engaging tech sites, Slashdot.org! http://sdm.link/slashdot\n" "> _______________________________________________\n" "> tpmdd-devel mailing list\n" - "> tpmdd-devel@lists.sourceforge.net\n" - > https://lists.sourceforge.net/lists/listinfo/tpmdd-devel + "> tpmdd-devel at lists.sourceforge.net\n" + "> https://lists.sourceforge.net/lists/listinfo/tpmdd-devel\n" + "--\n" + "To unsubscribe from this list: send the line \"unsubscribe linux-security-module\" in\n" + "the body of a message to majordomo at vger.kernel.org\n" + More majordomo info at http://vger.kernel.org/majordomo-info.html -f4de520b92848c6be72f190e879f1224a800d9d304f96a7c4b65f75f114e115d +228d1af3f1925869f6033f8170020bc999ab2e2f8e0c044794f12bdc8e33a22f
diff --git a/a/1.txt b/N2/1.txt index f165b09..93241db 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -18,7 +18,7 @@ There is not well defined order before you are in the mainline. > with one element, containing the same SHA1 digest they were passing before > this patch. > -> Signed-off-by: Roberto Sassu <roberto.sassu@huawei.com> +> Signed-off-by: Roberto Sassu <roberto.sassu-hv44wF8Li93QT0dZR+AlfA@public.gmane.org> Please just do a function that takes crypto ID. @@ -47,7 +47,7 @@ Please just do a function that takes crypto ID. > + > + for (i = 0; i < ARRAY_SIZE(chip->active_banks) && > + chip->active_banks[i].alg_id != TPM2_ALG_ERROR; i++) -> + if (chip->active_banks[i].alg_id = algo) +> + if (chip->active_banks[i].alg_id == algo) > + return chip->active_banks[i].digest_size; > + > + /* Callers should have checked which algorithms the TPM supports, @@ -81,11 +81,11 @@ Please just do a function that takes crypto ID. > + u32 first_digest_size; > + int i, j; > + -> + if (count = 0) +> + if (count == 0) > + return -EINVAL; > > chip = tpm_chip_find_get(chip_num); -> if (chip = NULL) +> if (chip == NULL) > return -ENODEV; > > + first_digest_size = tpm_get_digest_size(chip, digests[0].alg_id); @@ -100,7 +100,7 @@ Please just do a function that takes crypto ID. > + u32 cur_digest_size = first_digest_size; > + > + for (j = 0; j < count; j++) { -> + if (digests[j].alg_id = bank->alg_id) { +> + if (digests[j].alg_id == bank->alg_id) { > + cur_digest = digests[j].digest; > + cur_digest_size = bank->digest_size; > + break; @@ -238,5 +238,9 @@ Please just do a function that takes crypto ID. > engaging tech sites, Slashdot.org! http://sdm.link/slashdot > _______________________________________________ > tpmdd-devel mailing list -> tpmdd-devel@lists.sourceforge.net +> tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org > https://lists.sourceforge.net/lists/listinfo/tpmdd-devel + +------------------------------------------------------------------------------ +Check out the vibrant tech community on one of the world's most +engaging tech sites, Slashdot.org! http://sdm.link/slashdot diff --git a/a/content_digest b/N2/content_digest index d509dd4..df83615 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -1,9 +1,15 @@ "ref\020170621142941.32674-1-roberto.sassu@huawei.com\0" "ref\020170621142941.32674-7-roberto.sassu@huawei.com\0" - "From\0Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>\0" - "Subject\0Re: [tpmdd-devel] [PATCH v3 6/6] tpm: pass multiple digests to tpm_pcr_extend()\0" - "Date\0Fri, 23 Jun 2017 10:37:52 +0000\0" - "To\0linux-security-module@vger.kernel.org\0" + "ref\020170621142941.32674-7-roberto.sassu-hv44wF8Li93QT0dZR+AlfA@public.gmane.org\0" + "From\0Jarkko Sakkinen <jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>\0" + "Subject\0Re: [PATCH v3 6/6] tpm: pass multiple digests to tpm_pcr_extend()\0" + "Date\0Fri, 23 Jun 2017 12:37:52 +0200\0" + "To\0Roberto Sassu <roberto.sassu-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>\0" + "Cc\0linux-ima-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org" + linux-security-module-u79uwXL29TY76Z2rM5mHXA@public.gmane.org + tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org + keyrings-u79uwXL29TY76Z2rM5mHXA@public.gmane.org + " linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org\0" "\00:1\0" "b\0" "On Wed, Jun 21, 2017 at 04:29:41PM +0200, Roberto Sassu wrote:\n" @@ -26,7 +32,7 @@ "> with one element, containing the same SHA1 digest they were passing before\n" "> this patch.\n" "> \n" - "> Signed-off-by: Roberto Sassu <roberto.sassu@huawei.com>\n" + "> Signed-off-by: Roberto Sassu <roberto.sassu-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>\n" "\n" "Please just do a function that takes crypto ID.\n" "\n" @@ -55,7 +61,7 @@ "> +\n" "> +\tfor (i = 0; i < ARRAY_SIZE(chip->active_banks) &&\n" "> +\t chip->active_banks[i].alg_id != TPM2_ALG_ERROR; i++)\n" - "> +\t\tif (chip->active_banks[i].alg_id = algo)\n" + "> +\t\tif (chip->active_banks[i].alg_id == algo)\n" "> +\t\t\treturn chip->active_banks[i].digest_size;\n" "> +\n" "> +\t/* Callers should have checked which algorithms the TPM supports,\n" @@ -89,11 +95,11 @@ "> +\tu32 first_digest_size;\n" "> +\tint i, j;\n" "> +\n" - "> +\tif (count = 0)\n" + "> +\tif (count == 0)\n" "> +\t\treturn -EINVAL;\n" "> \n" "> \tchip = tpm_chip_find_get(chip_num);\n" - "> \tif (chip = NULL)\n" + "> \tif (chip == NULL)\n" "> \t\treturn -ENODEV;\n" "> \n" "> +\tfirst_digest_size = tpm_get_digest_size(chip, digests[0].alg_id);\n" @@ -108,7 +114,7 @@ "> +\t\t\tu32 cur_digest_size = first_digest_size;\n" "> +\n" "> +\t\t\tfor (j = 0; j < count; j++) {\n" - "> +\t\t\t\tif (digests[j].alg_id = bank->alg_id) {\n" + "> +\t\t\t\tif (digests[j].alg_id == bank->alg_id) {\n" "> +\t\t\t\t\tcur_digest = digests[j].digest;\n" "> +\t\t\t\t\tcur_digest_size = bank->digest_size;\n" "> +\t\t\t\t\tbreak;\n" @@ -246,7 +252,11 @@ "> engaging tech sites, Slashdot.org! http://sdm.link/slashdot\n" "> _______________________________________________\n" "> tpmdd-devel mailing list\n" - "> tpmdd-devel@lists.sourceforge.net\n" - > https://lists.sourceforge.net/lists/listinfo/tpmdd-devel + "> tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org\n" + "> https://lists.sourceforge.net/lists/listinfo/tpmdd-devel\n" + "\n" + "------------------------------------------------------------------------------\n" + "Check out the vibrant tech community on one of the world's most\n" + engaging tech sites, Slashdot.org! http://sdm.link/slashdot -f4de520b92848c6be72f190e879f1224a800d9d304f96a7c4b65f75f114e115d +87fcfe9ac1a699ca9b03e4211eae4268eaeb45afe2e40184cb45f2dd223d5734
diff --git a/a/1.txt b/N3/1.txt index f165b09..c72067f 100644 --- a/a/1.txt +++ b/N3/1.txt @@ -47,7 +47,7 @@ Please just do a function that takes crypto ID. > + > + for (i = 0; i < ARRAY_SIZE(chip->active_banks) && > + chip->active_banks[i].alg_id != TPM2_ALG_ERROR; i++) -> + if (chip->active_banks[i].alg_id = algo) +> + if (chip->active_banks[i].alg_id == algo) > + return chip->active_banks[i].digest_size; > + > + /* Callers should have checked which algorithms the TPM supports, @@ -81,11 +81,11 @@ Please just do a function that takes crypto ID. > + u32 first_digest_size; > + int i, j; > + -> + if (count = 0) +> + if (count == 0) > + return -EINVAL; > > chip = tpm_chip_find_get(chip_num); -> if (chip = NULL) +> if (chip == NULL) > return -ENODEV; > > + first_digest_size = tpm_get_digest_size(chip, digests[0].alg_id); @@ -100,7 +100,7 @@ Please just do a function that takes crypto ID. > + u32 cur_digest_size = first_digest_size; > + > + for (j = 0; j < count; j++) { -> + if (digests[j].alg_id = bank->alg_id) { +> + if (digests[j].alg_id == bank->alg_id) { > + cur_digest = digests[j].digest; > + cur_digest_size = bank->digest_size; > + break; diff --git a/a/content_digest b/N3/content_digest index d509dd4..77c2f62 100644 --- a/a/content_digest +++ b/N3/content_digest @@ -2,8 +2,13 @@ "ref\020170621142941.32674-7-roberto.sassu@huawei.com\0" "From\0Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>\0" "Subject\0Re: [tpmdd-devel] [PATCH v3 6/6] tpm: pass multiple digests to tpm_pcr_extend()\0" - "Date\0Fri, 23 Jun 2017 10:37:52 +0000\0" - "To\0linux-security-module@vger.kernel.org\0" + "Date\0Fri, 23 Jun 2017 12:37:52 +0200\0" + "To\0Roberto Sassu <roberto.sassu@huawei.com>\0" + "Cc\0tpmdd-devel@lists.sourceforge.net" + linux-ima-devel@lists.sourceforge.net + linux-security-module@vger.kernel.org + keyrings@vger.kernel.org + " linux-kernel@vger.kernel.org\0" "\00:1\0" "b\0" "On Wed, Jun 21, 2017 at 04:29:41PM +0200, Roberto Sassu wrote:\n" @@ -55,7 +60,7 @@ "> +\n" "> +\tfor (i = 0; i < ARRAY_SIZE(chip->active_banks) &&\n" "> +\t chip->active_banks[i].alg_id != TPM2_ALG_ERROR; i++)\n" - "> +\t\tif (chip->active_banks[i].alg_id = algo)\n" + "> +\t\tif (chip->active_banks[i].alg_id == algo)\n" "> +\t\t\treturn chip->active_banks[i].digest_size;\n" "> +\n" "> +\t/* Callers should have checked which algorithms the TPM supports,\n" @@ -89,11 +94,11 @@ "> +\tu32 first_digest_size;\n" "> +\tint i, j;\n" "> +\n" - "> +\tif (count = 0)\n" + "> +\tif (count == 0)\n" "> +\t\treturn -EINVAL;\n" "> \n" "> \tchip = tpm_chip_find_get(chip_num);\n" - "> \tif (chip = NULL)\n" + "> \tif (chip == NULL)\n" "> \t\treturn -ENODEV;\n" "> \n" "> +\tfirst_digest_size = tpm_get_digest_size(chip, digests[0].alg_id);\n" @@ -108,7 +113,7 @@ "> +\t\t\tu32 cur_digest_size = first_digest_size;\n" "> +\n" "> +\t\t\tfor (j = 0; j < count; j++) {\n" - "> +\t\t\t\tif (digests[j].alg_id = bank->alg_id) {\n" + "> +\t\t\t\tif (digests[j].alg_id == bank->alg_id) {\n" "> +\t\t\t\t\tcur_digest = digests[j].digest;\n" "> +\t\t\t\t\tcur_digest_size = bank->digest_size;\n" "> +\t\t\t\t\tbreak;\n" @@ -249,4 +254,4 @@ "> tpmdd-devel@lists.sourceforge.net\n" > https://lists.sourceforge.net/lists/listinfo/tpmdd-devel -f4de520b92848c6be72f190e879f1224a800d9d304f96a7c4b65f75f114e115d +e2f459dc8f9d60282b7218d3fd6ccaa4ceb15b829b67c996e7a068a713298c8e
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.