From: Stephen Hemminger <stephen@networkplumber.org>
To: Daniel Verkamp <daniel.verkamp@intel.com>
Cc: dev@dpdk.org
Subject: Re: [PATCH] pci: pad vendor and device ID to 4 digits
Date: Fri, 23 Jun 2017 10:44:51 -0700 [thread overview]
Message-ID: <20170623104451.41f6877a@xeon-e3> (raw)
In-Reply-To: <20170623172941.14423-1-daniel.verkamp@intel.com>
On Fri, 23 Jun 2017 10:29:41 -0700
Daniel Verkamp <daniel.verkamp@intel.com> wrote:
> Some PCI vendor and device IDs have leading zeros.
>
> Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com>
> ---
> lib/librte_eal/common/eal_common_pci.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/lib/librte_eal/common/eal_common_pci.c b/lib/librte_eal/common/eal_common_pci.c
> index 78b097e..c23421f 100644
> --- a/lib/librte_eal/common/eal_common_pci.c
> +++ b/lib/librte_eal/common/eal_common_pci.c
> @@ -203,7 +203,7 @@ rte_pci_probe_one_driver(struct rte_pci_driver *dr,
> return 1;
> }
>
> - RTE_LOG(INFO, EAL, " probe driver: %x:%x %s\n", dev->id.vendor_id,
> + RTE_LOG(INFO, EAL, " probe driver: %04x:%04x %s\n", dev->id.vendor_id,
> dev->id.device_id, dr->driver.name);
>
> if (dr->drv_flags & RTE_PCI_DRV_NEED_MAPPING) {
> @@ -253,7 +253,7 @@ rte_pci_detach_dev(struct rte_pci_device *dev)
> loc->domain, loc->bus, loc->devid,
> loc->function, dev->device.numa_node);
>
> - RTE_LOG(DEBUG, EAL, " remove driver: %x:%x %s\n", dev->id.vendor_id,
> + RTE_LOG(DEBUG, EAL, " remove driver: %04x:%04x %s\n", dev->id.vendor_id,
> dev->id.device_id, dr->driver.name);
>
> if (dr->remove && (dr->remove(dev) < 0))
> @@ -427,7 +427,7 @@ pci_dump_one_device(FILE *f, struct rte_pci_device *dev)
>
> fprintf(f, PCI_PRI_FMT, dev->addr.domain, dev->addr.bus,
> dev->addr.devid, dev->addr.function);
> - fprintf(f, " - vendor:%x device:%x\n", dev->id.vendor_id,
> + fprintf(f, " - vendor:%04x device:%04x\n", dev->id.vendor_id,
> dev->id.device_id);
>
> for (i = 0; i != sizeof(dev->mem_resource) /
It would be better to use a format consistent with PCI_PRI_FMT, as in:
RTE_LOG(DEBUG, EAL, " remove driver: %.4" PRIx16 ":%.4" PRIx16 " %s\n",
Maybe introduce PCI_VENDOR_FMT
#define PCI_VENDOR_FMT "%.4" PRIx16 ":%.4" PRIx16
next prev parent reply other threads:[~2017-06-23 17:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-23 17:29 [PATCH] pci: pad vendor and device ID to 4 digits Daniel Verkamp
2017-06-23 17:44 ` Stephen Hemminger [this message]
2017-06-23 18:20 ` [PATCH v2] " Daniel Verkamp
2017-07-05 13:16 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170623104451.41f6877a@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=daniel.verkamp@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.