From: Oleg Nesterov <oleg@redhat.com>
To: tip-bot for Michal Hocko <tipbot@zytor.com>
Cc: linux-tip-commits@vger.kernel.org, torvalds@linux-foundation.org,
mingo@kernel.org, hpa@zytor.com, jkosina@suse.cz,
mhocko@suse.com, tglx@linutronix.de, davej@codemonkey.org.uk,
peterz@infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [tip:x86/mm] x86/mmap, ASLR: Do not treat unlimited-stack tasks as legacy mmap
Date: Fri, 23 Jun 2017 16:54:41 +0200 [thread overview]
Message-ID: <20170623145441.GB9388@redhat.com> (raw)
In-Reply-To: <tip-86b110d2ae6365ce91cabd37588bc8611770421a@git.kernel.org>
On 06/23, tip-bot for Michal Hocko wrote:
>
> We added a heuristics to treat applications with RLIMIT_STACK configured
> to unlimited as legacy. This means:
To me this also means a minor security problem. The comment above
PER_CLEAR_ON_SETID says "must be cleared upon setuid or setgid exec",
but if you do "ulimit -s unlimited" before suid exec then
ADDR_COMPAT_LAYOUT set by security checks will be ignored.
> So let's try and remove this assumption - hopefully nothing breaks.
Agreed.
Oleg.
next prev parent reply other threads:[~2017-06-23 14:54 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-14 8:22 [RFC PATCH] mmap, aslr: do not enforce legacy mmap on unlimited stacks Michal Hocko
2017-06-14 8:22 ` Michal Hocko
2017-06-23 8:46 ` Michal Hocko
2017-06-23 8:46 ` Michal Hocko
2017-06-23 14:02 ` [tip:x86/mm] x86/mmap, ASLR: Do not treat unlimited-stack tasks as legacy mmap tip-bot for Michal Hocko
2017-06-23 14:54 ` Oleg Nesterov [this message]
2017-06-27 8:00 ` Jiri Kosina
2017-06-27 14:22 ` Oleg Nesterov
2017-06-28 9:40 ` Jiri Kosina
2017-06-23 20:35 ` Jiri Kosina
2017-06-24 6:43 ` tip-bot for Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170623145441.GB9388@redhat.com \
--to=oleg@redhat.com \
--cc=davej@codemonkey.org.uk \
--cc=hpa@zytor.com \
--cc=jkosina@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mhocko@suse.com \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=tipbot@zytor.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.