All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Bill O'Donnell" <billodo@redhat.com>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: Eric Sandeen <sandeen@redhat.com>, fstests <fstests@vger.kernel.org>
Subject: Re: [PATCH] generic/401: Test mountpoint not subdir for filetype support
Date: Fri, 23 Jun 2017 12:20:32 -0500	[thread overview]
Message-ID: <20170623172032.GA1198@redhat.com> (raw)
In-Reply-To: <63bb7dca-e407-abea-e432-2e946a8fd435@sandeen.net>

On Fri, Jun 23, 2017 at 11:12:41AM -0500, Eric Sandeen wrote:
> With pending changes for xfs_info/xfs_growfs, the tool
> now requires an actual mount point to work properly.
> 
> Change this test to test $SCRATCH_MNT not the subdir
> beneath it.
> 
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>

Reviewed-by: Bill O'Donnell <billodo@redhat.com>

> ---
> 
> Sorry, forgot [PATCH], adding to make sure Eryu sees it.
> 
> diff --git a/tests/generic/401 b/tests/generic/401
> index 04bd1a5..74f2bea 100755
> --- a/tests/generic/401
> +++ b/tests/generic/401
> @@ -79,7 +79,7 @@ mknod $testdir/p p
>  src/t_dir_type $testdir d | grep -F '.' | sort
>  
>  # Test that either all file types are unknown or all are correct
> -if _supports_filetype $testdir; then
> +if _supports_filetype $SCRATCH_MNT; then
>  	# print real file types
>  	src/t_dir_type $testdir | grep -vF '.' | sort
>  else
> 
> --
> To unsubscribe from this list: send the line "unsubscribe fstests" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2017-06-23 17:20 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-23 15:58 generic/401: Test mountpoint not subdir for filetype support Eric Sandeen
2017-06-23 16:12 ` [PATCH] " Eric Sandeen
2017-06-23 17:20   ` Bill O'Donnell [this message]
2017-06-26  3:59   ` Eryu Guan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170623172032.GA1198@redhat.com \
    --to=billodo@redhat.com \
    --cc=fstests@vger.kernel.org \
    --cc=sandeen@redhat.com \
    --cc=sandeen@sandeen.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.