All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Biggers <ebiggers3@gmail.com>
To: Theodore Ts'o <tytso@mit.edu>
Cc: Ext4 Developers List <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH -v2] mke2fs: fix hugefile creation so the hugefile(s) are contiguous
Date: Fri, 23 Jun 2017 12:19:25 -0700	[thread overview]
Message-ID: <20170623191925.GC84943@gmail.com> (raw)
In-Reply-To: <20170623000009.27984-1-tytso@mit.edu>

Hi Ted,

On Thu, Jun 22, 2017 at 08:00:09PM -0400, Theodore Ts'o wrote:
>  .I make_hugefiles
>  This boolean relation enables the creation of pre-allocated files as
> -part of formatting the file system.
> +part of formatting the file system.  If the file system is configured so
> +that the block group descriptors are located at beginning file system
> +space (by using the packed_meta_blocks option), the data blocks of the
> +huge files will be contiguous, with the extent tree blocks allocated
> +near the beginning of the file system space.

It's not quite that simple.  The presence of backup superblocks can also cause a
discontinuity.  If I remove 'num_backup_sb = 0' from mke2fs.conf, I see:

	PHYSICAL DISCONTINUITY between extents:
		  2  2 219 220 1073545216  1073577983 1073676288  1073709055  32768 
		  2  2 220 220 1073577984  1073610398 1073709409  1073741823  32415 

Also, for packed_meta_blocks to take effect, flex_bg must be enabled.  This is
documented in mke2fs(8) but not in mke2fs.conf(5).

There could be other issues as well; those are just the ones I found.

Perhaps there should be an option hugefiles_contiguous which makes the mke2fs
command fail if the hugefiles can't be allocated contiguously?

Eric

  parent reply	other threads:[~2017-06-23 19:19 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-23  0:00 [PATCH -v2] mke2fs: fix hugefile creation so the hugefile(s) are contiguous Theodore Ts'o
2017-06-23 17:56 ` Tahsin Erdogan
2017-06-23 19:19 ` Eric Biggers [this message]
2017-06-23 21:19   ` Theodore Ts'o

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170623191925.GC84943@gmail.com \
    --to=ebiggers3@gmail.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.