From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mailout4.zoneedit.com (mailout4.zoneedit.com [64.68.198.17]) by mail.openembedded.org (Postfix) with ESMTP id 4E1A4781F9 for ; Fri, 23 Jun 2017 21:15:01 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by mailout4.zoneedit.com (Postfix) with ESMTP id 29694208FB; Fri, 23 Jun 2017 21:15:03 +0000 (UTC) Received: from mailout4.zoneedit.com ([127.0.0.1]) by localhost (zmo03-pco.easydns.vpn [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id kK_546HeoxEt; Fri, 23 Jun 2017 21:15:03 +0000 (UTC) Received: from mail.denix.org (pool-100-15-85-143.washdc.fios.verizon.net [100.15.85.143]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mailout4.zoneedit.com (Postfix) with ESMTPSA id E489020072; Fri, 23 Jun 2017 21:14:59 +0000 (UTC) Received: by mail.denix.org (Postfix, from userid 1000) id 6AF83162513; Fri, 23 Jun 2017 17:14:59 -0400 (EDT) Date: Fri, 23 Jun 2017 17:14:59 -0400 From: Denys Dmytriyenko To: Khem Raj Message-ID: <20170623211459.GA28053@denix.org> References: <20170623202324.69194-1-amery@hanoverdisplays.com> <20170623202324.69194-3-amery@hanoverdisplays.com> <20170623205258.GZ28053@denix.org> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) Cc: openembeded-devel , Denys Dmytriyenko Subject: Re: [meta-oe][morty][PATCH 2/6] devmem2: use different filename to avoid checksum conflicts X-BeenThere: openembedded-devel@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Using the OpenEmbedded metadata to build Distributions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Jun 2017 21:15:05 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Jun 23, 2017 at 02:08:06PM -0700, Khem Raj wrote: > On Fri, Jun 23, 2017 at 1:52 PM, Denys Dmytriyenko wrote: > > On Fri, Jun 23, 2017 at 01:46:28PM -0700, Khem Raj wrote: > >> On Fri, Jun 23, 2017 at 1:23 PM, Alejandro Mery > >> wrote: > >> > From: Denys Dmytriyenko > >> > > >> > The newly resurrected devmem2.c file besides having a new location, also > >> > updates its header, producing different checksums, which would conflict > >> > with any previously cached or mirrored instances. To avoid such conflicts, > >> > use a different filename in fetch(). Rename it back to original name at > >> > unpack() for devmem2-fixups-2.patch to succeed w/o modifications. > >> > > >> > WARNING: devmem2-1.0-r7 do_fetch: Fetcher failure for URL: 'http://www.free-electrons.com/pub/mirror/devmem2.c'. Checksum mismatch! > >> > File: '/OE/master/downloads/devmem2.c' has md5 checksum be12c0132a1ae118cbf5e79d98427c1d when e23f236e94be4c429aa1ceac0f01544b was expected > >> > File: '/OE/master/downloads/devmem2.c' has sha256 checksum ec382c90af3ef2f49695ff14a4d6521e58ac482c4e29d6c9ebca8768f699c191 when 3b15515693bae1ebd14d914e46d388edfec2175829ea1576a7a0c8606ebbe639 was expected > >> > If this change is expected (e.g. you have upgraded to a new version without updating the checksums) then you can use these lines within the recipe: > >> > SRC_URI[md5sum] = "be12c0132a1ae118cbf5e79d98427c1d" > >> > SRC_URI[sha256sum] = "ec382c90af3ef2f49695ff14a4d6521e58ac482c4e29d6c9ebca8768f699c191" > >> > Otherwise you should retry the download and/or check with upstream to determine if the file has become corrupted or otherwise unexpectedly modified. > >> > > >> > WARNING: devmem2-1.0-r7 do_fetch: Renaming /OE/sources/devmem2.c to /OE/sources/devmem2.c_bad-checksum_be12c0132a1ae118cbf5e79d98427c1d > >> > > >> > Signed-off-by: Denys Dmytriyenko > >> > Signed-off-by: Martin Jansa > >> > --- > >> > meta-oe/recipes-support/devmem2/devmem2.bb | 6 +++++- > >> > 1 file changed, 5 insertions(+), 1 deletion(-) > >> > > >> > diff --git a/meta-oe/recipes-support/devmem2/devmem2.bb b/meta-oe/recipes-support/devmem2/devmem2.bb > >> > index c42eb5e0b..c86eb2e4b 100644 > >> > --- a/meta-oe/recipes-support/devmem2/devmem2.bb > >> > +++ b/meta-oe/recipes-support/devmem2/devmem2.bb > >> > @@ -3,12 +3,16 @@ LICENSE = "GPLv2+" > >> > LIC_FILES_CHKSUM = "file://devmem2.c;endline=38;md5=a9eb9f3890384519f435aedf986297cf" > >> > PR = "r7" > >> > > >> > -SRC_URI = "http://www.free-electrons.com/pub/mirror/devmem2.c \ > >> > +SRC_URI = "http://www.free-electrons.com/pub/mirror/devmem2.c;downloadfilename=devmem2-new.c \ > >> > file://devmem2-fixups-2.patch;apply=yes;striplevel=0" > >> > S = "${WORKDIR}" > >> > > >> > >> can we explore use of downloadfilename= parameter of http/ftp fetcher > > > > Sure, here are the corresponding sources where it's handled: > > http://cgit.openembedded.org/bitbake/tree/lib/bb/fetch2/wget.py#n65 > > > > ah this is rightly being used, I somehow thought it was not used but > that actually the change above. > > > >> > CFLAGS += "-DFORCE_STRICT_ALIGNMENT" > >> > > >> > +python do_unpack_append() { > >> > + os.rename("devmem2-new.c", "devmem2.c") > >> > +} > >> > + > > perhaps we do not need to rename it we can say do > > ${CC} -o devmem2 devmem2-new.c ${CFLAGS} ${LDFLAGS} This is the fourth or fifth time this is being suggested. We should merge it already, as I'm getting tired of explaining it... :) http://lists.openembedded.org/pipermail/openembedded-devel/2017-June/113042.html > >> > do_compile() { > >> > ${CC} -o devmem2 devmem2.c ${CFLAGS} ${LDFLAGS} > >> > } > >> > -- > >> > 2.13.0 > >> > > >> > -- > >> > _______________________________________________ > >> > Openembedded-devel mailing list > >> > Openembedded-devel@lists.openembedded.org > >> > http://lists.openembedded.org/mailman/listinfo/openembedded-devel > >> -- > >> _______________________________________________ > >> Openembedded-devel mailing list > >> Openembedded-devel@lists.openembedded.org > >> http://lists.openembedded.org/mailman/listinfo/openembedded-devel >