diff for duplicates of <20170624183741.23461441@kernel.org> diff --git a/a/1.txt b/N1/1.txt index 79ed440..8e9c566 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,7 +1,7 @@ On Fri, 23 Jun 2017 16:04:04 -0700 -Ismail Kose <Ismail.Kose@maximintegrated.com> wrote: +Ismail Kose <Ismail.Kose-zxKO94PEStzToO697jQleEEOCMrvLtNR@public.gmane.org> wrote: -> From: "Ismail H. Kose" <ihkose@gmail.com> +> From: "Ismail H. Kose" <ihkose-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> > > Add iio driver for DS4422/DS4424 chips that support two/four channel 7-bit > Sink/Source Current DAC. @@ -11,7 +11,7 @@ Ismail Kose <Ismail.Kose@maximintegrated.com> wrote: > Datasheet publicly available at: > https://datasheets.maximintegrated.com/en/ds/DS4422-DS4424.pdf > -> Signed-off-by: Ismail Kose <Ismail.Kose@maximintegrated.com> +> Signed-off-by: Ismail Kose <Ismail.Kose-zxKO94PEStzToO697jQleEEOCMrvLtNR@public.gmane.org> Various bits and pieces inline. In places I think you have tried to make the driver too generic. Rule of thumb is that we'll only add complexity when necessary. In particular the devicetree @@ -974,9 +974,9 @@ nitpick: blank line here. > +module_i2c_driver(ds4424_driver); > + > +MODULE_DESCRIPTION("Maxim DS4424 DAC Driver"); -> +MODULE_AUTHOR("Ismail H. Kose <ismail.kose@maximintegrated.com>"); -> +MODULE_AUTHOR("Vishal Sood <vishal.sood@maximintegrated.com>"); -> +MODULE_AUTHOR("David Jung <david.jung@maximintegrated.com>"); +> +MODULE_AUTHOR("Ismail H. Kose <ismail.kose-zxKO94PEStzToO697jQleEEOCMrvLtNR@public.gmane.org>"); +> +MODULE_AUTHOR("Vishal Sood <vishal.sood-zxKO94PEStzToO697jQleEEOCMrvLtNR@public.gmane.org>"); +> +MODULE_AUTHOR("David Jung <david.jung-zxKO94PEStzToO697jQleEEOCMrvLtNR@public.gmane.org>"); > +MODULE_LICENSE("GPL v2"); > diff --git a/include/linux/iio/dac/ds4424.h b/include/linux/iio/dac/ds4424.h > new file mode 100644 diff --git a/a/content_digest b/N1/content_digest index d5c6fde..b3075e0 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,30 +1,31 @@ "ref\020170623230404.2283-1-Ismail.Kose@maximintegrated.com\0" - "From\0Jonathan Cameron <jic23@kernel.org>\0" + "ref\020170623230404.2283-1-Ismail.Kose-zxKO94PEStzToO697jQleEEOCMrvLtNR@public.gmane.org\0" + "From\0Jonathan Cameron <jic23-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>\0" "Subject\0Re: [PATCH] iio: dac: DS4424: add Maxim DS4422/DS4424 DAC driver support\0" "Date\0Sat, 24 Jun 2017 18:37:41 +0100\0" - "To\0Ismail Kose <Ismail.Kose@maximintegrated.com>\0" - "Cc\0knaack.h@gmx.de" - lars@metafoo.de - pmeerw@pmeerw.net - robh+dt@kernel.org - mark.rutland@arm.com - vilhelm.gray@gmail.com - linus.walleij@linaro.org - jeff.dagenais@gmail.com - fabrice.gasnier@st.com - gwenhael.goavec-merou@trabucayre.com - peda@axentia.se - maxime.roussinbelanger@gmail.com - ihkose@gmail.com - linux-iio@vger.kernel.org - devicetree@vger.kernel.org - " linux-kernel@vger.kernel.org\0" + "To\0Ismail Kose <Ismail.Kose-zxKO94PEStzToO697jQleEEOCMrvLtNR@public.gmane.org>\0" + "Cc\0knaack.h-Mmb7MZpHnFY@public.gmane.org" + lars-Qo5EllUWu/uELgA04lAiVw@public.gmane.org + pmeerw-jW+XmwGofnusTnJN9+BGXg@public.gmane.org + robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org + mark.rutland-5wv7dgnIgG8@public.gmane.org + vilhelm.gray-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org + linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org + jeff.dagenais-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org + fabrice.gasnier-qxv4g6HH51o@public.gmane.org + gwenhael.goavec-merou-W7CSdorvuhNZroRs9YW3xA@public.gmane.org + peda-koto5C5qi+TLoDKTGw+V6w@public.gmane.org + maxime.roussinbelanger-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org + ihkose-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org + linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org + devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org + " linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org\0" "\00:1\0" "b\0" "On Fri, 23 Jun 2017 16:04:04 -0700\n" - "Ismail Kose <Ismail.Kose@maximintegrated.com> wrote:\n" + "Ismail Kose <Ismail.Kose-zxKO94PEStzToO697jQleEEOCMrvLtNR@public.gmane.org> wrote:\n" "\n" - "> From: \"Ismail H. Kose\" <ihkose@gmail.com>\n" + "> From: \"Ismail H. Kose\" <ihkose-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>\n" "> \n" "> Add iio driver for DS4422/DS4424 chips that support two/four channel 7-bit\n" "> Sink/Source Current DAC.\n" @@ -34,7 +35,7 @@ "> Datasheet publicly available at:\n" "> https://datasheets.maximintegrated.com/en/ds/DS4422-DS4424.pdf\n" "> \n" - "> Signed-off-by: Ismail Kose <Ismail.Kose@maximintegrated.com>\n" + "> Signed-off-by: Ismail Kose <Ismail.Kose-zxKO94PEStzToO697jQleEEOCMrvLtNR@public.gmane.org>\n" "Various bits and pieces inline. In places I think you have tried\n" "to make the driver too generic. Rule of thumb is that we'll only\n" "add complexity when necessary. In particular the devicetree\n" @@ -997,9 +998,9 @@ "> +module_i2c_driver(ds4424_driver);\n" "> +\n" "> +MODULE_DESCRIPTION(\"Maxim DS4424 DAC Driver\");\n" - "> +MODULE_AUTHOR(\"Ismail H. Kose <ismail.kose@maximintegrated.com>\");\n" - "> +MODULE_AUTHOR(\"Vishal Sood <vishal.sood@maximintegrated.com>\");\n" - "> +MODULE_AUTHOR(\"David Jung <david.jung@maximintegrated.com>\");\n" + "> +MODULE_AUTHOR(\"Ismail H. Kose <ismail.kose-zxKO94PEStzToO697jQleEEOCMrvLtNR@public.gmane.org>\");\n" + "> +MODULE_AUTHOR(\"Vishal Sood <vishal.sood-zxKO94PEStzToO697jQleEEOCMrvLtNR@public.gmane.org>\");\n" + "> +MODULE_AUTHOR(\"David Jung <david.jung-zxKO94PEStzToO697jQleEEOCMrvLtNR@public.gmane.org>\");\n" "> +MODULE_LICENSE(\"GPL v2\");\n" "> diff --git a/include/linux/iio/dac/ds4424.h b/include/linux/iio/dac/ds4424.h\n" "> new file mode 100644\n" @@ -1040,4 +1041,4 @@ "> +};\n" > +#endif /* IIO_DAC_DS4424_H_ */ -538b562f13d4e9ecb0c03ec786ae8e4a8111549af13b30dac5c85c1c1fe39c8e +f5d1afc715ccf57d67c314e36726516386b1f381a5d28504c9294b10f1985d5a
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.