From: Jonathan Cameron <jic23@kernel.org>
To: Lorenzo Bianconi <lorenzo.bianconi83@gmail.com>
Cc: gregor.boirie@parrot.com, linux-iio@vger.kernel.org,
lorenzo.bianconi@st.com
Subject: Re: [PATCH] iio: pressure: st_pressure_core: disable multiread by default for LPS22HB
Date: Sat, 24 Jun 2017 20:46:17 +0100 [thread overview]
Message-ID: <20170624204617.2a9c5450@kernel.org> (raw)
In-Reply-To: <20170622174643.13259-1-lorenzo.bianconi@st.com>
On Thu, 22 Jun 2017 19:46:43 +0200
Lorenzo Bianconi <lorenzo.bianconi83@gmail.com> wrote:
> Set multiread variable to false for LPS22HB pressure sensor since
> it is already enabled in CTRL_REG2. Previous configuration does not
> cause any issue in I2C communication since SUB Msb has no meaning
> whereas it breaks register address in SPI communication
>
> Fixes: e039e2f5b4da (iio:st_pressure:initial lps22hb sensor support)
> Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi@st.com>
Applied to the fixes-togreg branch of iio.git and marked for stable.
This will probably only go upstream after the merge window now.
Jonathan
> ---
> drivers/iio/pressure/st_pressure_core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/pressure/st_pressure_core.c b/drivers/iio/pressure/st_pressure_core.c
> index aa61ec15c139..f1bce05ffa13 100644
> --- a/drivers/iio/pressure/st_pressure_core.c
> +++ b/drivers/iio/pressure/st_pressure_core.c
> @@ -456,7 +456,7 @@ static const struct st_sensor_settings st_press_sensors_settings[] = {
> .mask_od = 0x40,
> .addr_stat_drdy = ST_SENSORS_DEFAULT_STAT_ADDR,
> },
> - .multi_read_bit = true,
> + .multi_read_bit = false,
> .bootime = 2,
> },
> };
prev parent reply other threads:[~2017-06-24 19:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-22 17:46 [PATCH] iio: pressure: st_pressure_core: disable multiread by default for LPS22HB Lorenzo Bianconi
2017-06-24 19:46 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170624204617.2a9c5450@kernel.org \
--to=jic23@kernel.org \
--cc=gregor.boirie@parrot.com \
--cc=linux-iio@vger.kernel.org \
--cc=lorenzo.bianconi83@gmail.com \
--cc=lorenzo.bianconi@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.