From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Henri Roosen <henri.roosen@ginzinger.com>
Cc: linux-remoteproc@vger.kernel.org,
Ohad Ben-Cohen <ohad@wizery.com>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] rpmsg: virtio_rpmsg_bus: fix announce for devices without endpoint
Date: Sun, 25 Jun 2017 14:35:29 -0700 [thread overview]
Message-ID: <20170625213529.GF26155@builder> (raw)
In-Reply-To: <1496403351-32280-1-git-send-email-henri.roosen@ginzinger.com>
On Fri 02 Jun 04:35 PDT 2017, Henri Roosen wrote:
> A device might not have an endpoint assigned. This patch checks if
> rpdev->ept has a value before dereferencing or using it.
>
Applied, thanks.
> Signed-off-by: Henri Roosen <henri.roosen@ginzinger.com>
> ---
> drivers/rpmsg/virtio_rpmsg_bus.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/rpmsg/virtio_rpmsg_bus.c b/drivers/rpmsg/virtio_rpmsg_bus.c
> index 5e66e081..3c582f2 100644
> --- a/drivers/rpmsg/virtio_rpmsg_bus.c
> +++ b/drivers/rpmsg/virtio_rpmsg_bus.c
> @@ -314,7 +314,7 @@ static int virtio_rpmsg_announce_create(struct rpmsg_device *rpdev)
> int err = 0;
>
> /* need to tell remote processor's name service about this channel ? */
> - if (rpdev->announce &&
> + if (rpdev->announce && rpdev->ept &&
> virtio_has_feature(vrp->vdev, VIRTIO_RPMSG_F_NS)) {
> struct rpmsg_ns_msg nsm;
>
> @@ -338,7 +338,7 @@ static int virtio_rpmsg_announce_destroy(struct rpmsg_device *rpdev)
> int err = 0;
>
> /* tell remote processor's name service we're removing this channel */
> - if (rpdev->announce &&
> + if (rpdev->announce && rpdev->ept &&
> virtio_has_feature(vrp->vdev, VIRTIO_RPMSG_F_NS)) {
> struct rpmsg_ns_msg nsm;
>
> --
> 2.1.4
>
prev parent reply other threads:[~2017-06-25 21:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-02 11:35 [PATCH] rpmsg: virtio_rpmsg_bus: fix announce for devices without endpoint Henri Roosen
2017-06-02 11:35 ` Henri Roosen
2017-06-25 21:35 ` Bjorn Andersson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170625213529.GF26155@builder \
--to=bjorn.andersson@linaro.org \
--cc=henri.roosen@ginzinger.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=ohad@wizery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.