From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48890) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dPK7e-0005xA-CB for qemu-devel@nongnu.org; Sun, 25 Jun 2017 22:51:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dPK7Z-0007C7-I4 for qemu-devel@nongnu.org; Sun, 25 Jun 2017 22:51:30 -0400 Received: from mx1.redhat.com ([209.132.183.28]:44740) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dPK7Z-0007As-Bg for qemu-devel@nongnu.org; Sun, 25 Jun 2017 22:51:25 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 514E180F7B for ; Mon, 26 Jun 2017 02:51:24 +0000 (UTC) Date: Mon, 26 Jun 2017 10:51:19 +0800 From: Peter Xu Message-ID: <20170626025119.GI3936@pxdev.xzpeter.org> References: <1498193206-18007-1-git-send-email-peterx@redhat.com> <1498193206-18007-6-git-send-email-peterx@redhat.com> <20170623221901.GF10776@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20170623221901.GF10776@localhost.localdomain> Subject: Re: [Qemu-devel] [PATCH v5 05/10] migration: move global_state.optional out List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost Cc: qemu-devel@nongnu.org, Laurent Vivier , Juan Quintela , "Dr . David Alan Gilbert" , Markus Armbruster On Fri, Jun 23, 2017 at 07:19:01PM -0300, Eduardo Habkost wrote: > On Fri, Jun 23, 2017 at 12:46:41PM +0800, Peter Xu wrote: > > Put it into MigrationState then we can use the properties to specify > > whether to enable storing global state. > > > > Removing global_state_set_optional() since now we can use HW_COMPAT_2_3 > > for x86/power, and AccelClass.global_props for Xen. > > > > Reviewed-by: Juan Quintela > > Signed-off-by: Peter Xu > > --- > > hw/i386/pc_piix.c | 1 - > > hw/ppc/spapr.c | 1 - > > hw/xen/xen-common.c | 11 ++++++++++- > > include/hw/compat.h | 4 ++++ > > include/migration/global_state.h | 1 - > > migration/global_state.c | 9 ++------- > > migration/migration.c | 7 +++++++ > > migration/migration.h | 6 ++++++ > > 8 files changed, 29 insertions(+), 11 deletions(-) > > > [...] > > diff --git a/hw/xen/xen-common.c b/hw/xen/xen-common.c > > index d3fa705..9163a0a 100644 > > --- a/hw/xen/xen-common.c > > +++ b/hw/xen/xen-common.c > > @@ -139,19 +139,28 @@ static int xen_init(MachineState *ms) > > } > > qemu_add_vm_change_state_handler(xen_change_state_handler, NULL); > > > > - global_state_set_optional(); > > savevm_skip_configuration(); > > savevm_skip_section_footers(); > > > > return 0; > > } > > > > +GlobalProperty xen_compat_props[] = { > > This can be static. Yep. > > > + { > > + .driver = "migration", > > + .property = "store-global-state", > > + .value = "off", > > + }, > > + { .driver = NULL, .property = NULL, .value = NULL }, > > Normally this is written as: > > { /* end of list */ }, Let me switch. > > > +}; > > + > [...] > > I didn't review the rest yet, but it seems to be good. Thanks! -- Peter Xu