All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mike Snitzer <snitzer@redhat.com>
To: Zdenek Kabelac <zkabelac@redhat.com>
Cc: Heinz Mauelshagen <heinzm@redhat.com>, Eric Ren <zren@suse.com>,
	neilb@suse.com, jtang@suse.com, dm-devel@redhat.com,
	agk@redhat.com
Subject: Re: dm mirror: fix crash caused by NULL-pointer dereference
Date: Mon, 26 Jun 2017 09:43:35 -0400	[thread overview]
Message-ID: <20170626134335.GA31446@redhat.com> (raw)
In-Reply-To: <c01457b7-2178-30c0-ab59-8b059560d598@redhat.com>

On Mon, Jun 26 2017 at  7:49am -0400,
Zdenek Kabelac <zkabelac@redhat.com> wrote:

> Dne 26.6.2017 v 12:55 Eric Ren napsal(a):
> >Hi Zdenek,
> >
> >
> >On 06/26/2017 05:46 PM, Zdenek Kabelac wrote:
> >>Dne 26.6.2017 v 11:08 Eric Ren napsal(a):
> >>>
> >>[... snip...]
> >>
> >>Hi
> >>
> >>Which kernel version is this ?
> >>
> >>I'd thought we've already fixed this BZ for old mirrors:
> >>https://bugzilla.redhat.com/show_bug.cgi?id=1382382
> >>
> >>There similar BZ for md-raid based mirrors (--type raid1)
> >>https://bugzilla.redhat.com/show_bug.cgi?id=1416099
> >My base kernel version is 4.4.68, but with this 2 latest fixes applied:
> >
> >"""
> >Revert "dm mirror: use all available legs on multiple failures"
> 
> Ohh  - I've -rc6 - while this  'revert' patch went to 4.12-rc7.
> 
> I'm now starting to wonder why?
> 
> It's been a real fix for a real issue - and 'revert' message states
> there is no such problem ??
> 
> I'm confused....
> 
> Mike  - have you tried the sequence from BZ  ?

Jon (cc'd) tested it and found that the original issue wasn't
reproducible.  But that the commit in question was the source of crashes
(likely due to needing the fix from this thread).

We can revisit for 4.13 -- but I'll defer to Heinz.

Eric, please share your results from testing the latest 4.12-rc7.

Mike

  reply	other threads:[~2017-06-26 13:43 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-26  9:08 [PATCH] dm mirror: fix crash caused by NULL-pointer dereference Eric Ren
2017-06-26  9:14 ` Johannes Thumshirn
2017-06-26 10:42   ` Eric Ren
2017-06-26  9:46 ` Zdenek Kabelac
2017-06-26 10:55   ` Eric Ren
2017-06-26 11:49     ` Zdenek Kabelac
2017-06-26 13:43       ` Mike Snitzer [this message]
2017-06-26 13:56         ` Eric Ren
2017-06-27  5:47         ` Eric Ren
2017-06-26 13:47     ` [PATCH] " Eric Ren
2017-06-26 14:37       ` Mike Snitzer
2017-06-26 15:27         ` Eric Ren
2017-06-27  1:46           ` Eric Ren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170626134335.GA31446@redhat.com \
    --to=snitzer@redhat.com \
    --cc=agk@redhat.com \
    --cc=dm-devel@redhat.com \
    --cc=heinzm@redhat.com \
    --cc=jtang@suse.com \
    --cc=neilb@suse.com \
    --cc=zkabelac@redhat.com \
    --cc=zren@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.