Re: [meta-qt5] [PATCH] qttools: DEPENDS on icu

[Denys Dmytriyenko <denis@denix.org>]

I believe this was meant to be sent to the list, not just me directly...

On Mon, Jun 26, 2017 at 05:00:14AM +0200, Ming Liu wrote:
> Hi,
> 
> Please revert it, I probably made a mistake, I encountered this issue in
> morty branch, then I checked the qttools-5.7 source, and found there is
> code referring ICU, so I thought the issue is also impacting the upstream,
> which it seems is not according to Denys, sorry for the inconvenience I
> brought.
> 
> //Ming Liu
> 
> 2017-06-23 23:46 GMT+02:00 Denys Dmytriyenko <denis@denix.org>:
> 
> > Thanks.
> >
> > On Fri, Jun 23, 2017 at 11:41:05PM +0200, Martin Jansa wrote:
> > > Yes, I've seen both e-mails. I'm waiting for response from author, then
> > > I'll revert it in master and pyro branches.
> > >
> > > On Fri, Jun 23, 2017 at 11:19 PM, Denys Dmytriyenko <denis@denix.org>
> > wrote:
> > >
> > > > Martin,
> > > >
> > > > Were you able to look into this yet? I didn't copy you directly at
> > first,
> > > > so
> > > > not sure if you missed it...
> > > >
> > > >
> > > > On Thu, Jun 22, 2017 at 03:18:49PM -0400, Denys Dmytriyenko wrote:
> > > > > On Tue, Jun 20, 2017 at 06:28:32AM +0200, liu.ming50@gmail.com
> > wrote:
> > > > > > From: Ming Liu <peter.x.liu@external.atlascopco.com>
> > > > > >
> > > > > > This fixes a following QA issue:
> > > > > > | QA Issue: nativesdk-qtbase-tools rdepends on
> > nativesdk-libicui18n,
> > > > but it isn't a build dependency.
> > > > > > | QA Issue: nativesdk-qtbase-tools rdepends on nativesdk-libicuuc,
> > but
> > > > it isn't a build dependency.
> > > > > > | QA Issue: nativesdk-qtbase-tools rdepends on
> > nativesdk-libicudata,
> > > > but it isn't a build dependency.
> > > > >
> > > > > It seems there's inconsistency here between errors above referring to
> > > > > nativesdk-qtbase-tools and the change below made to qttools instead
> > of
> > > > > qtbase!
> > > > >
> > > > > I wonder if this fix was not included by the author:
> > > > >
> > > > > https://github.com/meta-qt5/meta-qt5/commit/
> > > > ff073f04109900fc07bf81e2f1df63c626caf342
> > > > >
> > > > > Just to double-check, I just built nativesdk-qttools using meta-qt5
> > w/o
> > > > this
> > > > > patch and I don't see the above QA errors.
> > > > >
> > > > > --
> > > > > Denys
> > > > >
> > > > >
> > > > > > Signed-off-by: Ming Liu <peter.x.liu@external.atlascopco.com>
> > > > > > ---
> > > > > >  recipes-qt/qt5/qttools_git.bb | 2 +-
> > > > > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > > > >
> > > > > > diff --git a/recipes-qt/qt5/qttools_git.bb b/recipes-qt/qt5/
> > > > qttools_git.bb
> > > > > > index 5c0f51c..1108390 100644
> > > > > > --- a/recipes-qt/qt5/qttools_git.bb
> > > > > > +++ b/recipes-qt/qt5/qttools_git.bb
> > > > > > @@ -16,7 +16,7 @@ LIC_FILES_CHKSUM = " \
> > > > > >
> > > > > >  inherit ptest
> > > > > >
> > > > > > -DEPENDS += "qtbase qtdeclarative qtxmlpatterns"
> > > > > > +DEPENDS += "qtbase qtdeclarative qtxmlpatterns icu"
> > > > > >
> > > > > >  SRC_URI += " \
> > > > > >      file://run-ptest \
> > > > > > --
> > > > > > 2.7.4
> > > > > >
> > > > > > --
> > > > > > _______________________________________________
> > > > > > Openembedded-devel mailing list
> > > > > > Openembedded-devel@lists.openembedded.org
> > > > > > http://lists.openembedded.org/mailman/listinfo/openembedded-devel
> > > > > --
> > > > > _______________________________________________
> > > > > Openembedded-devel mailing list
> > > > > Openembedded-devel@lists.openembedded.org
> > > > > http://lists.openembedded.org/mailman/listinfo/openembedded-devel
> > > >
> >