From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Manasi Navare <manasi.d.navare@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH v3 2/2] drm/i915/dp: Remove -1/+1 from t11_t12 for Gen9_LP/CNP case
Date: Mon, 26 Jun 2017 19:41:28 +0300 [thread overview]
Message-ID: <20170626164128.GL12629@intel.com> (raw)
In-Reply-To: <1498159524-10772-2-git-send-email-manasi.d.navare@intel.com>
On Thu, Jun 22, 2017 at 12:25:24PM -0700, Manasi Navare wrote:
> Now the VBT.seq->t11_t12 value adds 100ms to both Gen9_LP
> as well as non Gen9_LP cases so no need to special case
> and do -1 during HW readout and +1 during pp_div write
> for Gen9_LP/CNP case.
>
> Signed-off-by: Manasi Navare <manasi.d.navare@intel.com>
> Suggested-by: Ville Syrjala <ville.syrjala@linux.intel.com>
> Cc: Ville Syrjala <ville.syrjala@linux.intel.com>
> Cc: Clint Taylor <clinton.a.taylor@intel.com>
lgtm
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> drivers/gpu/drm/i915/intel_dp.c | 10 +++-------
> 1 file changed, 3 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
> index be9e17a..67bc8a7a 100644
> --- a/drivers/gpu/drm/i915/intel_dp.c
> +++ b/drivers/gpu/drm/i915/intel_dp.c
> @@ -5178,12 +5178,8 @@ intel_pps_readout_hw_state(struct drm_i915_private *dev_priv,
> PANEL_POWER_DOWN_DELAY_SHIFT;
>
> if (IS_GEN9_LP(dev_priv) || HAS_PCH_CNP(dev_priv)) {
> - u16 tmp = (pp_ctl & BXT_POWER_CYCLE_DELAY_MASK) >>
> - BXT_POWER_CYCLE_DELAY_SHIFT;
> - if (tmp > 0)
> - seq->t11_t12 = (tmp - 1) * 1000;
> - else
> - seq->t11_t12 = 0;
> + seq->t11_t12 = ((pp_ctl & BXT_POWER_CYCLE_DELAY_MASK) >>
> + BXT_POWER_CYCLE_DELAY_SHIFT) * 1000;
> } else {
> seq->t11_t12 = ((pp_div & PANEL_POWER_CYCLE_DELAY_MASK) >>
> PANEL_POWER_CYCLE_DELAY_SHIFT) * 1000;
> @@ -5342,7 +5338,7 @@ intel_dp_init_panel_power_sequencer_registers(struct drm_device *dev,
> if (IS_GEN9_LP(dev_priv) || HAS_PCH_CNP(dev_priv)) {
> pp_div = I915_READ(regs.pp_ctrl);
> pp_div &= ~BXT_POWER_CYCLE_DELAY_MASK;
> - pp_div |= (DIV_ROUND_UP((seq->t11_t12 + 1), 1000)
> + pp_div |= (DIV_ROUND_UP(seq->t11_t12, 1000)
> << BXT_POWER_CYCLE_DELAY_SHIFT);
> } else {
> pp_div = ((100 * div)/2 - 1) << PP_REFERENCE_DIVIDER_SHIFT;
> --
> 2.1.4
--
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-06-26 16:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-22 19:25 [PATCH v3 1/2] drm/i915/dp: Fix the t11_t12 panel power cycle delay from VBT read Manasi Navare
2017-06-22 19:25 ` [PATCH v3 2/2] drm/i915/dp: Remove -1/+1 from t11_t12 for Gen9_LP/CNP case Manasi Navare
2017-06-26 16:41 ` Ville Syrjälä [this message]
2017-06-22 19:51 ` ✗ Fi.CI.BAT: failure for series starting with [v3,1/2] drm/i915/dp: Fix the t11_t12 panel power cycle delay from VBT read Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170626164128.GL12629@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=manasi.d.navare@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.