From: kbuild test robot <lkp@intel.com>
To: "Guillermo O. Freschi" <kedrot@gmail.com>
Cc: kbuild-all@01.org, Aditya Shankar <aditya.shankar@microchip.com>,
Ganesh Krishna <ganesh.krishna@microchip.com>,
linux-wireless@vger.kernel.org,
"Guillermo O. Freschi" <kedrot@gmail.com>
Subject: Re: [PATCH] drivers: staging: wilc1000/host_interface.c Fix sparse warning: right shift by bigger than source value
Date: Mon, 26 Jun 2017 18:27:04 +0800 [thread overview]
Message-ID: <201706261820.VGWDXS2c%fengguang.wu@intel.com> (raw)
In-Reply-To: <20170625144051.28873-1-kedrot@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 2134 bytes --]
Hi Guillermo,
[auto build test WARNING on staging/staging-testing]
[also build test WARNING on next-20170626]
[cannot apply to v4.12-rc7]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Guillermo-O-Freschi/drivers-staging-wilc1000-host_interface-c-Fix-sparse-warning-right-shift-by-bigger-than-source-value/20170626-173132
config: x86_64-randconfig-x007-201726 (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64
All warnings (new ones prefixed by >>):
drivers/staging/wilc1000/host_interface.c: In function 'Handle_SetMulticastFilter':
>> drivers/staging/wilc1000/host_interface.c:2420:2: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
u32 enabled = strHostIfSetMulti->enabled;
^~~
vim +2420 drivers/staging/wilc1000/host_interface.c
2404 static void Handle_SetMulticastFilter(struct wilc_vif *vif,
2405 struct set_multicast *strHostIfSetMulti)
2406 {
2407 s32 result = 0;
2408 struct wid wid;
2409 u8 *pu8CurrByte;
2410
2411 wid.id = (u16)WID_SETUP_MULTICAST_FILTER;
2412 wid.type = WID_BIN;
2413 wid.size = sizeof(struct set_multicast) + ((strHostIfSetMulti->cnt) * ETH_ALEN);
2414 wid.val = kmalloc(wid.size, GFP_KERNEL);
2415 if (!wid.val)
2416 goto ERRORHANDLER;
2417
2418 pu8CurrByte = wid.val;
2419
> 2420 u32 enabled = strHostIfSetMulti->enabled;
2421 *pu8CurrByte++ = (enabled & 0xFF);
2422 *pu8CurrByte++ = ((enabled >> 8) & 0xFF);
2423 *pu8CurrByte++ = ((enabled >> 16) & 0xFF);
2424 *pu8CurrByte++ = ((enabled >> 24) & 0xFF);
2425
2426 *pu8CurrByte++ = (strHostIfSetMulti->cnt & 0xFF);
2427 *pu8CurrByte++ = ((strHostIfSetMulti->cnt >> 8) & 0xFF);
2428 *pu8CurrByte++ = ((strHostIfSetMulti->cnt >> 16) & 0xFF);
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 28132 bytes --]
next prev parent reply other threads:[~2017-06-26 10:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-25 14:40 [PATCH] drivers: staging: wilc1000/host_interface.c Fix sparse warning: right shift by bigger than source value Guillermo O. Freschi
2017-06-26 10:27 ` kbuild test robot [this message]
2017-06-26 11:29 ` [PATCH v2] " Guillermo O. Freschi
2017-06-26 11:47 ` Guillermo O. Freschi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201706261820.VGWDXS2c%fengguang.wu@intel.com \
--to=lkp@intel.com \
--cc=aditya.shankar@microchip.com \
--cc=ganesh.krishna@microchip.com \
--cc=kbuild-all@01.org \
--cc=kedrot@gmail.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.