From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lelnx194.ext.ti.com (lelnx194.ext.ti.com [198.47.27.80]) by arago-project.org (Postfix) with ESMTPS id 0B069529D6 for ; Mon, 26 Jun 2017 18:46:38 +0000 (UTC) Received: from dflxv15.itg.ti.com ([128.247.5.124]) by lelnx194.ext.ti.com (8.15.1/8.15.1) with ESMTP id v5QIkcsS029607 for ; Mon, 26 Jun 2017 13:46:38 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ti.com; s=ti-com-17Q1; t=1498502798; bh=I9XaWY8N7d+21GY8MNCHVJ22z0JDQJAtVpBXbRRNy+g=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=w33kzDUX2Ah/DSF+6XvB5DlzwICcAWXp0A591CgQWS78Y0v4IBYDc/fjKdH9sZpUA cXqxmy8LfBCgpCcvHAIr90dCt3F9rseebTbyY//XzdAmsaksF8VicPg68Cl6IPBVan Zu3h4Mpb1IJ/MmfR5sZP4V2ztwz+hXm5E+Nc03sE= Received: from DFLE72.ent.ti.com (dfle72.ent.ti.com [128.247.5.109]) by dflxv15.itg.ti.com (8.14.3/8.13.8) with ESMTP id v5QIkcYI000571 for ; Mon, 26 Jun 2017 13:46:38 -0500 Received: from dflp32.itg.ti.com (10.64.6.15) by DFLE72.ent.ti.com (128.247.5.109) with Microsoft SMTP Server id 14.3.294.0; Mon, 26 Jun 2017 13:46:38 -0500 Received: from localhost (ileax41-snat.itg.ti.com [10.172.224.153]) by dflp32.itg.ti.com (8.14.3/8.13.8) with ESMTP id v5QIkctF024574; Mon, 26 Jun 2017 13:46:38 -0500 Date: Mon, 26 Jun 2017 14:46:36 -0400 From: Denys Dmytriyenko To: Sam Nelson Message-ID: <20170626184636.GC14665@edge> References: <1498498997-30316-1-git-send-email-sam.nelson@ti.com> MIME-Version: 1.0 In-Reply-To: <1498498997-30316-1-git-send-email-sam.nelson@ti.com> User-Agent: Mutt/1.5.20 (2009-06-14) Cc: meta-arago@arago-project.org Subject: Re: [morty/master][PATCH v3 1/2] big-data-ipc-demo: Add ipc examples for big data buffer exchange X-BeenThere: meta-arago@arago-project.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Arago metadata layer for TI SDKs - OE-Core/Yocto compatible List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Jun 2017 18:46:39 -0000 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline Thanks, Sam, looks reasonable. Few non-critical comments - let me know if you want to fix them and re-submit, or I can merge as is and if needed, address them later as a follow up. On Mon, Jun 26, 2017 at 01:43:16PM -0400, Sam Nelson wrote: > Adds example with host running linux > Demonstrates transfer of Big data buffers between A15 host and DSP core > > Signed-off-by: Sam Nelson > > --- > Change from previous version of patch > - Expand to am57xx-evm to omap-a15 > - Remove ti-staging.inc > --- > --- > .../big-data-ipc-demo-linux_git.bb | 41 ++++++++++++++++++++++ > .../big-data-ipc-demo/big-data-ipc-demo.inc | 39 ++++++++++++++++++++ > 2 files changed, 80 insertions(+) > create mode 100644 meta-arago-extras/recipes-apps/big-data-ipc-demo/big-data-ipc-demo-linux_git.bb > create mode 100644 meta-arago-extras/recipes-apps/big-data-ipc-demo/big-data-ipc-demo.inc > > diff --git a/meta-arago-extras/recipes-apps/big-data-ipc-demo/big-data-ipc-demo-linux_git.bb b/meta-arago-extras/recipes-apps/big-data-ipc-demo/big-data-ipc-demo-linux_git.bb > new file mode 100644 > index 0000000..0734177 > --- /dev/null > +++ b/meta-arago-extras/recipes-apps/big-data-ipc-demo/big-data-ipc-demo-linux_git.bb > @@ -0,0 +1,41 @@ > +SUMMARY = "TI Big data IPC: Host linux examples" > + > +require recipes-ti/includes/ti-paths.inc > +require big-data-ipc-demo.inc > + > +DEPENDS = "ti-ipc \ > + ti-xdctools \ > + ti-sysbios \ > + ti-ipc-rtos \ > + cmem \ > +" > + > +EXTRA_OEMAKE = "\ > + PLATFORM=${PLATFORM} \ > + XDC_INSTALL_DIR="${XDC_INSTALL_DIR}" \ > + BIOS_INSTALL_DIR="${SYSBIOS_INSTALL_DIR}" \ > + IPC_INSTALL_DIR="${IPC_INSTALL_DIR}" \ > + LINUX_SYSROOT_DIR="${STAGING_INCDIR}" \ > + ${IPC_TARGETS} \ > + JOBS="${PARALLEL_MAKE}" \ > +" > + > +do_create_srcipk_prepend() { > + rm -rf host_bios > +} > + > +do_compile() { > + if [ "${PLATFORM}" != "UNKNOWN" ]; then > + oe_runmake host_linux > + fi > +} I don't think checking PLATFORM above and below is necessary - you set strict COMPATIBLE_MACHINE filter and set all possible variants of PLATFORM var below. Even if something is not defined, let if fail with UNKNOWN setting, instead of succeeding and not building anything... > +do_install() { > + if [ "${PLATFORM}" != "UNKNOWN" ]; then > + oe_runmake EXEC_DIR="${D}${bindir}" install_linux_bin > + fi > +} > + > +PACKAGES =+ "${PN}-firmware" > +FILES_${PN}-firmware += "${bindir}/simple_buffer_example/release/server_dsp.xe66" > +INSANE_SKIP_${PN}-firmware += "arch" > diff --git a/meta-arago-extras/recipes-apps/big-data-ipc-demo/big-data-ipc-demo.inc b/meta-arago-extras/recipes-apps/big-data-ipc-demo/big-data-ipc-demo.inc > new file mode 100644 > index 0000000..c3f8f38 > --- /dev/null > +++ b/meta-arago-extras/recipes-apps/big-data-ipc-demo/big-data-ipc-demo.inc > @@ -0,0 +1,39 @@ > +LICENSE = "BSD-3-Clause" > +LIC_FILES_CHKSUM = "file://makefile;beginline=1;endline=31;md5=2f2ea348b98d5cc7807ece7adcc2c43a" > + > +COMPATIBLE_MACHINE = "omap-a15|keystone" > +PACKAGE_ARCH = "${MACHINE_ARCH}" > + > +BIG_DATA_IPC_GIT_URI = "git://git.ti.com/processor-sdk/big-data-ipc-examples.git" > +BIG_DATA_IPC_GIT_PROTOCOL = "git" > +BIG_DATA_IPC_GIT_BRANCH = "master" > + > +# Below commit ID corresponds to "DEV.BIG_DATA_IPC.01.01.00.00" > +BIG_DATA_IPC_SRCREV = "5907bff5a29fe2ba8719ae8c3c5d62b20b7b6bc9" > + > +BRANCH = "${BIG_DATA_IPC_GIT_BRANCH}" > +SRC_URI = "${BIG_DATA_IPC_GIT_URI};protocol=${BIG_DATA_IPC_GIT_PROTOCOL};branch=${BRANCH}" > + > +SRCREV = "${BIG_DATA_IPC_SRCREV}" > +PV = "01.01.00.00" Kind of strange split - usually common pieces are in .inc and version-specific are in .bb file. Here you set SRCREV and PV in .inc file... Any reason? > +S = "${WORKDIR}/git" > + > +PLATFORM = "UNKNOWN" > +PLATFORM_omap-a15 = "DRA7XX" > +PLATFORM_k2hk-evm = "TCI6636" > +PLATFORM_k2l-evm = "TCI6630" > +PLATFORM_k2e = "66AK2E" > +PLATFORM_k2g = "66AK2G" > + > +IPC_TARGETS = "" > +IPC_TARGETS_omap-a15 = "\ > + gnu.targets.arm.A15F="${GCC_ARM_NONE_TOOLCHAIN}" \ > + ti.targets.elf.C66="${STAGING_DIR_NATIVE}/usr/share/ti/cgt-c6x" \ > + ti.targets.arm.elf.M4="${M4_TOOLCHAIN_INSTALL_DIR}" \ > +" > + > +IPC_TARGETS_keystone = " \ > + gnu.targets.arm.A15F="${GCC_ARM_NONE_TOOLCHAIN}" \ > + ti.targets.elf.C66="${STAGING_DIR_NATIVE}/usr/share/ti/cgt-c6x" \ > +" > -- > 1.9.1 > > _______________________________________________ > meta-arago mailing list > meta-arago@arago-project.org > http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago