Re: [PATCH] drm/i915: Print pwm device-name when using pwm for backlight control

From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Hans de Goede <hdegoede@redhat.com>
Cc: Daniel Vetter <daniel.vetter@intel.com>,
	intel-gfx <intel-gfx@lists.freedesktop.org>,
	dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Print pwm device-name when using pwm for backlight control
Date: Tue, 27 Jun 2017 12:52:49 +0300	[thread overview]
Message-ID: <20170627095249.GM12629@intel.com> (raw)
In-Reply-To: <20170623074244.6901-1-hdegoede@redhat.com>

On Fri, Jun 23, 2017 at 09:42:44AM +0200, Hans de Goede wrote:
> On Bay Trail devices either the Crystal Cove PMIC's pwm or the LPSS'
> pwm is used to control the backlight. Other drivers take core of
> providing a backlight_pwm alias through pwm_add_table, but it is
> still useful to know which pwm device actually ends up being used
> for debugging backlight issues, so add a DRM_INFO logging the
> pwm device-name.
> 
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> ---
>  drivers/gpu/drm/i915/intel_panel.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/gpu/drm/i915/intel_panel.c b/drivers/gpu/drm/i915/intel_panel.c
> index cb50c527401f..7936a64af393 100644
> --- a/drivers/gpu/drm/i915/intel_panel.c
> +++ b/drivers/gpu/drm/i915/intel_panel.c
> @@ -1670,6 +1670,9 @@ static int pwm_setup_backlight(struct intel_connector *connector,
>  				 CRC_PMIC_PWM_PERIOD_NS);
>  	panel->backlight.enabled = panel->backlight.level != 0;
>  
> +	DRM_INFO("Using %s pwm-device for backlight control\n",
> +		 dev_name(panel->backlight.pwm->chip->dev));

Is DRM_DEBUG_KMS() not enough?

> +
>  	return 0;
>  }
>  
> -- 
> 2.13.0

-- 
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx