Re: [Qemu-devel] [PULL v1 0/7] MMIO Exec pull request

["Edgar E. Iglesias" <edgar.iglesias@gmail.com>]

On Fri, Jun 23, 2017 at 11:54:52AM +0100, Peter Maydell wrote:
> On 14 June 2017 at 18:45, Edgar E. Iglesias <edgar.iglesias@gmail.com> wrote:
> > From: "Edgar E. Iglesias" <edgar.iglesias@xilinx.com>
> >
> > Hi,
> >
> > Paolo suggested offline that we send a pull request for this series.
> > Here it is, I've run it through my testsuite + tested the LQSPI testcase
> > on Zynq.
> >
> > Cheers,
> > Edgar
> >
> > The following changes since commit 3f0602927b120a480b35dcf58cf6f95435b3ae91:
> >
> >   Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20170613' into staging (2017-06-13 15:49:07 +0100)
> >
> > are available in the git repository at:
> >
> >   git@github.com:edgarigl/qemu.git tags/edgar/mmio-exec.for-upstream
> >
> > for you to fetch changes up to 63ef40dd6bc6cfdae5fa67ccac1cb11e7a5161b0:
> >
> >   xilinx_spips: allow mmio execution (2017-06-14 17:31:08 +0200)
> >
> > ----------------------------------------------------------------
> > mmio-exec.for-upstream
> >
> > ----------------------------------------------------------------
> > KONRAD Frederic (7):
> >       cputlb: cleanup get_page_addr_code to use VICTIM_TLB_HIT
> >       cputlb: move get_page_addr_code
> >       cputlb: fix the way get_page_addr_code fills the tlb
> >       qdev: add MemoryRegion property
> >       introduce mmio_interface
> >       exec: allow to get a pointer for some mmio memory region
> >       xilinx_spips: allow mmio execution
> 
> Hi Edgar -- since these patches have come via your tree they should
> have your signed-off-by line, not just Fred's. They also seem to
> still have all the V1->V2->V3 revision notes in the commit logs.

OK thanks, I'll fix both things for v2.


> 
> I'd be happier with a reviewed-by: from somebody for the exec:
> patch, if possible...

We must have lost mine. Anyway, I've had another review and it looks
good to me. Of course the more eyes the better...

I'll post a v2 in a moment.

Best regards,
Edgar