From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Mateusz Jurczyk <mjurczyk@google.com>
Cc: Jozsef Kadlecsik <kadlec@blackhole.kfki.hu>,
Florian Westphal <fw@strlen.de>,
"David S. Miller" <davem@davemloft.net>,
netfilter-devel@vger.kernel.org, coreteam@netfilter.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] netfilter: nfnetlink: Improve input length sanitization in nfnetlink_rcv
Date: Tue, 27 Jun 2017 17:58:25 +0200 [thread overview]
Message-ID: <20170627155825.GA4885@salvia> (raw)
In-Reply-To: <20170607135038.1592-1-mjurczyk@google.com>
On Wed, Jun 07, 2017 at 03:50:38PM +0200, Mateusz Jurczyk wrote:
> Verify that the length of the socket buffer is sufficient to cover the
> nlmsghdr structure before accessing the nlh->nlmsg_len field for further
> input sanitization. If the client only supplies 1-3 bytes of data in
> sk_buff, then nlh->nlmsg_len remains partially uninitialized and
> contains leftover memory from the corresponding kernel allocation.
> Operating on such data may result in indeterminate evaluation of the
> nlmsg_len < NLMSG_HDRLEN expression.
>
> The bug was discovered by a runtime instrumentation designed to detect
> use of uninitialized memory in the kernel. The patch prevents this and
> other similar tools (e.g. KMSAN) from flagging this behavior in the future.
Applied, thanks.
next prev parent reply other threads:[~2017-06-27 15:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-07 12:35 [PATCH] netfilter: nfnetlink: Improve input length sanitization in nfnetlink_rcv Mateusz Jurczyk
2017-06-07 13:23 ` Eric Dumazet
2017-06-07 13:50 ` [PATCH v2] " Mateusz Jurczyk
2017-06-27 15:58 ` Pablo Neira Ayuso [this message]
2017-06-27 17:05 ` Pablo Neira Ayuso
2017-06-29 16:22 ` Pablo Neira Ayuso
2017-06-30 15:19 ` Mateusz Jurczyk
2017-07-17 11:31 ` [netfilter-core] " Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170627155825.GA4885@salvia \
--to=pablo@netfilter.org \
--cc=coreteam@netfilter.org \
--cc=davem@davemloft.net \
--cc=fw@strlen.de \
--cc=kadlec@blackhole.kfki.hu \
--cc=linux-kernel@vger.kernel.org \
--cc=mjurczyk@google.com \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.