From: Ralf Baechle <ralf@linux-mips.org>
To: Karl Beldan <karl.beldan@gmail.com>
Cc: linux-mips@linux-mips.org, linux-kernel@vger.kernel.org,
Karl Beldan <karl.beldan+oss@gmail.com>,
stable@vger.kernel.org, Jonas Gorski <jogo@openwrt.org>
Subject: Re: [RESEND PATCH] MIPS: head: Reorder instructions missing a delay slot
Date: Tue, 27 Jun 2017 23:40:18 +0200 [thread overview]
Message-ID: <20170627214018.GD10090@linux-mips.org> (raw)
In-Reply-To: <20170627192216.29364-1-karl.beldan+oss@gmail.com>
On Tue, Jun 27, 2017 at 07:22:16PM +0000, Karl Beldan wrote:
> In this sequence the 'move' is assumed in the delay slot of the 'beq',
> but head.S is in reorder mode and the former gets pushed one 'nop'
> farther by the assembler.
>
> The corrected behavior made booting with an UHI supplied dtb erratic.
Excellent catch, patch applied!
Thanks Karl,
Ralf
prev parent reply other threads:[~2017-06-27 21:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-27 19:22 [RESEND PATCH] MIPS: head: Reorder instructions missing a delay slot Karl Beldan
2017-06-27 20:31 ` James Hogan
2017-06-27 20:31 ` James Hogan
2017-06-27 21:40 ` Ralf Baechle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170627214018.GD10090@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=jogo@openwrt.org \
--cc=karl.beldan+oss@gmail.com \
--cc=karl.beldan@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.