Re: [Qemu-devel] [PATCH v6 04/10] migration: let MigrationState be a qdev

[Peter Xu <peterx@redhat.com>]

On Tue, Jun 27, 2017 at 11:47:18AM -0300, Eduardo Habkost wrote:
> On Tue, Jun 27, 2017 at 12:10:13PM +0800, Peter Xu wrote:
> [...]
> > +
> > +static const TypeInfo migration_type = {
> > +    .name = TYPE_MIGRATION,
> > +    .parent = TYPE_DEVICE,
> 
> As TYPE_MIGRATION isn't really a device and we're using TYPE_DEVICE just
> to reuse the global property system, maybe we should add a comment here
> explaining that?
> 
> It would also be interesting to explain the TYPE_DEVICE features we do
> not use.  e.g.: the device is not created using qdev_create(), it is
> never attached to any bus, and it is never realized.
> 
> (But I don't think this should require a series respin.  The comment may
> be sent as a follow-up patch.)

Sure. Let me prepare another patch for it upon the series. Thanks,

-- 
Peter Xu