From: Wolfram Sang <wsa@the-dreams.de>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Chris Packham <chris.packham@alliedtelesis.co.nz>,
Rob Herring <robh+dt@kernel.org>,
linux-i2c <linux-i2c@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 3/5] i2c: pca-platform: add devicetree awareness
Date: Wed, 28 Jun 2017 11:42:51 +0200 [thread overview]
Message-ID: <20170628094251.vm3c36pto7p777i2@ninjato> (raw)
In-Reply-To: <CAHp75VeFUZzj00i9oSSanudPVzd61XFRkQ9Uz72r05EqdHNdxg@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 687 bytes --]
> > /* If irq is 0, we do polling. */
> > + if (irq < 0)
> > + irq = 0;
>
> This does not belong to what is written in commit message. Looks like
> a separate fix.
True, this needs explanation.
> > + of_property_read_u32_index(np, "clock-frequency", 0,
> > + &i2c->algo_data.i2c_clock);
>
> And what prevents you to use device_property_read_*() here and get rid
> of OFstuff?
device_* functions are not super much known yet. Even I tend to forget
them occasionally like here. We can fix it incrementally, too. But I
agree, it would be nice to have it right from the beginning.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2017-06-28 9:42 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-20 1:18 [PATCH v2 0/5] i2c: pca-platform: updates Chris Packham
2017-06-20 1:18 ` [PATCH v2 1/5] dt-bindings: add bindings for i2c-pca-platform Chris Packham
[not found] ` <20170620011837.14010-2-chris.packham-6g8wRflRTwXFdCa3tKVlE6U/zSkkHjvu@public.gmane.org>
2017-06-22 8:22 ` Wolfram Sang
2017-06-22 8:22 ` Wolfram Sang
2017-06-22 21:20 ` Chris Packham
[not found] ` <e121e9ad4afe49008e34b5b4a76b22c6-5g7mGxlPNYb6GjIOKuZY+ItlCAj8ZROq@public.gmane.org>
2017-06-23 8:17 ` Wolfram Sang
2017-06-23 8:17 ` Wolfram Sang
2017-06-23 21:41 ` Rob Herring
2017-06-20 1:18 ` [PATCH v2 2/5] i2c: pca-platform: add devicetree awareness Chris Packham
[not found] ` <20170620011837.14010-1-chris.packham-6g8wRflRTwXFdCa3tKVlE6U/zSkkHjvu@public.gmane.org>
2017-06-20 1:18 ` [PATCH v2 3/5] i2c: pca-platform: use gpio_is_valid Chris Packham
2017-06-20 1:18 ` Chris Packham
2017-06-20 1:18 ` [PATCH v2 4/5] i2c: pca-platform: use device managed allocations Chris Packham
2017-06-20 1:18 ` Chris Packham
2017-06-20 1:18 ` [PATCH v2 5/5] i2c: pca-platform: use dev_warn/dev_info instead of printk Chris Packham
2017-06-20 1:18 ` Chris Packham
2017-06-26 0:44 ` [PATCH v3 0/5] i2c: pca-platform: updates Chris Packham
2017-06-26 0:44 ` [PATCH v3 1/5] dt-bindings: add bindings for i2c-pca-platform Chris Packham
[not found] ` <20170626004434.2757-2-chris.packham-6g8wRflRTwXFdCa3tKVlE6U/zSkkHjvu@public.gmane.org>
2017-06-26 14:06 ` Rob Herring
2017-06-26 14:06 ` Rob Herring
2017-06-27 19:53 ` Wolfram Sang
2017-06-26 0:44 ` [PATCH v3 2/5] i2c: pca-platform: switch to struct gpio_desc Chris Packham
2017-06-27 19:53 ` Wolfram Sang
2017-06-28 9:25 ` Andy Shevchenko
2017-06-28 21:25 ` Chris Packham
2017-06-28 22:18 ` Wolfram Sang
2017-06-26 0:44 ` [PATCH v3 3/5] i2c: pca-platform: add devicetree awareness Chris Packham
2017-06-27 19:55 ` Wolfram Sang
2017-06-28 9:20 ` Andy Shevchenko
2017-06-28 9:42 ` Wolfram Sang [this message]
2017-06-28 21:15 ` Chris Packham
2017-06-26 0:44 ` [PATCH v3 4/5] i2c: pca-platform: use device managed allocations Chris Packham
2017-06-27 19:55 ` Wolfram Sang
2017-06-28 9:23 ` Andy Shevchenko
2017-06-28 9:38 ` Wolfram Sang
2017-06-28 10:54 ` Andy Shevchenko
2017-06-28 21:03 ` Chris Packham
2017-06-26 0:44 ` [PATCH v3 5/5] i2c: pca-platform: use dev_warn/dev_info instead of printk Chris Packham
2017-06-27 19:55 ` Wolfram Sang
2017-06-28 9:28 ` Andy Shevchenko
2017-06-28 9:37 ` Wolfram Sang
2017-06-28 10:57 ` Andy Shevchenko
2017-06-28 12:01 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170628094251.vm3c36pto7p777i2@ninjato \
--to=wsa@the-dreams.de \
--cc=andy.shevchenko@gmail.com \
--cc=chris.packham@alliedtelesis.co.nz \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.