All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Simo Koskinen <koskisoft@gmail.com>
Cc: wporter82@gmail.com, dilekuzulmez@gmail.com,
	bankarsandhya512@gmail.com, colin.king@canonical.com,
	quexint@gmail.com, sergio.paracuellos@gmail.com,
	jrickertkc@gmail.com, julia.lawall@lip6.fr,
	namrataashettar@gmail.com, arushisinghal19971997@gmail.com,
	baijiaju1990@163.com, aquannie@gmail.com,
	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rts5208 : Fixing coding style warnings
Date: Wed, 28 Jun 2017 14:58:09 +0200	[thread overview]
Message-ID: <20170628125809.GA30378@kroah.com> (raw)
In-Reply-To: <1498654212-19521-1-git-send-email-koskisoft@gmail.com>

On Wed, Jun 28, 2017 at 02:50:12PM +0200, Simo Koskinen wrote:
> Fixed following warnings found by checkpatch.pl script:
> 
> WARNING: Prefer using '"%s...", __func__' to using 'xxxx',
> this function's name, in a string
> 
> Signed-off-by: Simo Koskinen <koskisoft@gmail.com>

Is this different from a previous patch?  If so, you need to properly
version your patch, as the documentation descripts how to do.

> ---
>  drivers/staging/rts5208/rtsx.c      |  2 --
>  drivers/staging/rts5208/rtsx_chip.c |  4 ++--
>  drivers/staging/rts5208/sd.c        |  8 ++++----
>  drivers/staging/rts5208/spi.c       |  8 ++++----
>  drivers/staging/rts5208/xd.c        | 11 ++++++-----
>  5 files changed, 16 insertions(+), 17 deletions(-)
> 
> diff --git a/drivers/staging/rts5208/rtsx.c b/drivers/staging/rts5208/rtsx.c
> index b8177f5..c7ae702 100644
> --- a/drivers/staging/rts5208/rtsx.c
> +++ b/drivers/staging/rts5208/rtsx.c
> @@ -1009,8 +1009,6 @@ static void rtsx_remove(struct pci_dev *pci)
>  {
>  	struct rtsx_dev *dev = pci_get_drvdata(pci);
>  
> -	dev_info(&pci->dev, "rtsx_remove() called\n");
> -

This change does not match up with the changelog text :(

  reply	other threads:[~2017-06-28 12:58 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-28  9:15 [PATCH] staging: rts5208 : Fixing coding style warnings Simo Koskinen
2017-06-28 12:00 ` Greg KH
2017-06-28 12:50   ` Simo Koskinen
2017-06-28 12:58     ` Greg KH [this message]
2017-06-28 12:58     ` Frans Klaver

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170628125809.GA30378@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=aquannie@gmail.com \
    --cc=arushisinghal19971997@gmail.com \
    --cc=baijiaju1990@163.com \
    --cc=bankarsandhya512@gmail.com \
    --cc=colin.king@canonical.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=dilekuzulmez@gmail.com \
    --cc=jrickertkc@gmail.com \
    --cc=julia.lawall@lip6.fr \
    --cc=koskisoft@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=namrataashettar@gmail.com \
    --cc=quexint@gmail.com \
    --cc=sergio.paracuellos@gmail.com \
    --cc=wporter82@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.