From: Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Jason Gunthorpe
<jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
Cc: Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH rdma-next 2/4] RDMA/netlink: Advertise IB subnet prefix
Date: Wed, 28 Jun 2017 19:21:42 +0300 [thread overview]
Message-ID: <20170628162142.GL1248@mtr-leonro.local> (raw)
In-Reply-To: <20170628161236.GC28839-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 532 bytes --]
On Wed, Jun 28, 2017 at 10:12:36AM -0600, Jason Gunthorpe wrote:
> On Wed, Jun 28, 2017 at 07:10:20PM +0300, Leon Romanovsky wrote:
> > > Since the GUID is in host order I recommend making the subnet_prefix
> > > in host order too.
> > >
> > > At the very least, the comments beside anything not in host order
> > > should be 'be64' not u64
> >
> > Those comments represent netlink types. It doesn't have be64.
>
> Then don't send b64 down netlink as a netlink u64 type?
Agree, conversion to u64 is the right way to do.
>
> Jason
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2017-06-28 16:21 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-28 13:34 [PATCH rdma-next 0/4] Another round of exported properties for RDMAtool Leon Romanovsky
[not found] ` <20170628133445.16550-1-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2017-06-28 13:34 ` [PATCH rdma-next 1/4] RDMA/netlink: Export guid and sys_image_guid Leon Romanovsky
[not found] ` <20170628133445.16550-2-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2017-06-28 16:00 ` Jason Gunthorpe
[not found] ` <20170628160025.GA14375-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2017-06-28 16:12 ` Leon Romanovsky
2017-06-28 13:34 ` [PATCH rdma-next 2/4] RDMA/netlink: Advertise IB subnet prefix Leon Romanovsky
[not found] ` <20170628133445.16550-3-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2017-06-28 16:02 ` Jason Gunthorpe
[not found] ` <20170628160251.GB14375-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2017-06-28 16:10 ` Leon Romanovsky
[not found] ` <20170628161020.GI1248-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2017-06-28 16:12 ` Jason Gunthorpe
[not found] ` <20170628161236.GC28839-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2017-06-28 16:21 ` Leon Romanovsky [this message]
2017-06-28 13:34 ` [PATCH rdma-next 3/4] RDMA/netink: Export lids and sm_lids Leon Romanovsky
[not found] ` <20170628133445.16550-4-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2017-06-28 16:05 ` Jason Gunthorpe
[not found] ` <20170628160513.GC14375-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2017-06-28 16:16 ` Leon Romanovsky
[not found] ` <20170628161616.GK1248-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2017-06-28 16:19 ` Jason Gunthorpe
[not found] ` <20170628161903.GA28996-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2017-06-28 16:24 ` Leon Romanovsky
2017-06-28 13:34 ` [PATCH rdma-next 4/4] RDMA/netlink: Export LID mask counter (LMC) Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170628162142.GL1248@mtr-leonro.local \
--to=leon-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
--cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.