From: "Daniel P. Berrange" <berrange@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Khem Raj <raj.khem@gmail.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Kamil Rytarowski <kamil@netbsd.org>,
Riku Voipio <riku.voipio@iki.fi>,
QEMU Developers <qemu-devel@nongnu.org>,
Laurent Vivier <laurent@vivier.eu>
Subject: Re: [Qemu-devel] [PATCH] replace struct ucontext with ucontext_t type
Date: Thu, 29 Jun 2017 14:18:07 +0100 [thread overview]
Message-ID: <20170629131807.GD32167@redhat.com> (raw)
In-Reply-To: <CAFEAcA-N3Ve8GmX6Yq+Kbng8vExe3CzDT_2_07JML8QC2xVwDA@mail.gmail.com>
On Thu, Jun 29, 2017 at 10:05:13AM +0100, Peter Maydell wrote:
> On 28 June 2017 at 21:44, Khem Raj <raj.khem@gmail.com> wrote:
> > The ucontext_t type had a tag struct ucontext until now
> > but newer glibc will drop it so we need to adjust and use
> > the exposed type instead
>
> If true this seems like a bug in glibc to break
> existing working programs, and it should be fixed there...
The glib commit message indicates it is intentional change, in order
to get POSIX compliance:
https://sourceware.org/git/?p=glibc.git;a=commit;h=251287734e89a52da3db682a8241eb6bccc050c9
NB, other parts of QEMU like the coroutine code are already
using the 'ucontext_t' typedef, so attaining consistency across
files is good regardless of the glibc change.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2017-06-29 13:18 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-28 20:44 [Qemu-devel] [PATCH] replace struct ucontext with ucontext_t type Khem Raj
2017-06-29 8:02 ` Laurent Vivier
2017-06-29 13:12 ` Khem Raj
2017-06-29 9:05 ` Peter Maydell
2017-06-29 13:12 ` Markus Armbruster
2017-06-29 13:10 ` Kamil Rytarowski
2017-06-29 13:18 ` Daniel P. Berrange [this message]
2017-07-19 1:06 ` Eric Blake
2017-07-20 9:59 ` Peter Maydell
2017-06-29 14:09 ` Laurent Vivier
2017-07-19 1:07 ` Eric Blake
2017-07-06 23:49 ` no-reply
2017-07-07 0:02 ` Fam Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170629131807.GD32167@redhat.com \
--to=berrange@redhat.com \
--cc=kamil@netbsd.org \
--cc=laurent@vivier.eu \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=raj.khem@gmail.com \
--cc=riku.voipio@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.