From: Greg KH <gregkh@linuxfoundation.org>
To: Arvind Yadav <arvind.yadav.cs@gmail.com>
Cc: lkp@intel.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: ccree: constify dev_pm_ops structures.
Date: Thu, 29 Jun 2017 16:17:45 +0200 [thread overview]
Message-ID: <20170629141745.GA29512@kroah.com> (raw)
In-Reply-To: <e741c93aa6104c884ab727a13f113afe171a6668.1498728426.git.arvind.yadav.cs@gmail.com>
On Thu, Jun 29, 2017 at 03:00:28PM +0530, Arvind Yadav wrote:
> dev_pm_ops are not supposed to change at runtime. All functions
> working with dev_pm_ops provided by <linux/device.h> work with const
> dev_pm_ops. So mark the non-const structs as const.
>
> File size before:
> text data bss dec hex filename
> 3800 488 0 4288 10c0 drivers/staging/ccree/ssi_driver.o
>
> File size After adding 'const':
> text data bss dec hex filename
> 4010 288 0 4298 10ca drivers/staging/ccree/ssi_driver.o
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
> ---
> drivers/staging/ccree/ssi_driver.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
No longer applies to my staging-testing branch at all due to other
changes happening there. Please rebase and resend.
thanks,
greg k-h
next prev parent reply other threads:[~2017-06-29 14:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-29 9:30 [PATCH] staging: ccree: constify dev_pm_ops structures Arvind Yadav
2017-06-29 14:17 ` Greg KH [this message]
-- strict thread matches above, loose matches on Subject: below --
2017-08-08 9:23 Arvind Yadav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170629141745.GA29512@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=arvind.yadav.cs@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.