From mboxrd@z Thu Jan 1 00:00:00 1970 From: clabbe.montjoie@gmail.com (Corentin Labbe) Date: Thu, 29 Jun 2017 19:02:38 +0200 Subject: [PATCH 1/6] net: stmmac: support future possible different internal phy mode In-Reply-To: <20170629.122349.2265868886957558079.davem@davemloft.net> References: <20170627092806.28181-1-clabbe.montjoie@gmail.com> <20170629.122349.2265868886957558079.davem@davemloft.net> Message-ID: <20170629170238.GA2606@Red> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thu, Jun 29, 2017 at 12:23:49PM -0400, David Miller wrote: > From: Corentin Labbe > Date: Tue, 27 Jun 2017 11:28:01 +0200 > > > The current way to find if the phy is internal is to compare DT phy-mode > > and emac_variant/internal_phy. > > But it will negate a possible future SoC where an external PHY use the > > same phy mode than the internal one. > > > > By using phy-mode = "internal" we permit to have an external PHY with > > the same mode than the internal one. > > > > Reported-by: Andr? Przywara > > Signed-off-by: Corentin Labbe > > Series applied. > > Please provide a proper "[PATCH 0/n] " header posting next time. Sorry could you wait for applying, there are a parallel thread (http://www.spinics.net/lists/devicetree/msg183520.html) and it seems finaly that internal could not be the good way to do it. Regards Sorry again, I should have sent a comment for waiting. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Corentin Labbe Subject: Re: [PATCH 1/6] net: stmmac: support future possible different internal phy mode Date: Thu, 29 Jun 2017 19:02:38 +0200 Message-ID: <20170629170238.GA2606@Red> References: <20170627092806.28181-1-clabbe.montjoie@gmail.com> <20170629.122349.2265868886957558079.davem@davemloft.net> Reply-To: clabbe.montjoie-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Return-path: Sender: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org Content-Disposition: inline In-Reply-To: <20170629.122349.2265868886957558079.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org> List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: David Miller Cc: robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, mark.rutland-5wv7dgnIgG8@public.gmane.org, linux-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org, maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org, wens-jdAy2FN1RRM@public.gmane.org, peppe.cavallaro-qxv4g6HH51o@public.gmane.org, alexandre.torgue-qxv4g6HH51o@public.gmane.org, andre.przywara-5wv7dgnIgG8@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org List-Id: devicetree@vger.kernel.org On Thu, Jun 29, 2017 at 12:23:49PM -0400, David Miller wrote: > From: Corentin Labbe > Date: Tue, 27 Jun 2017 11:28:01 +0200 >=20 > > The current way to find if the phy is internal is to compare DT phy-mod= e > > and emac_variant/internal_phy. > > But it will negate a possible future SoC where an external PHY use the > > same phy mode than the internal one. > >=20 > > By using phy-mode =3D "internal" we permit to have an external PHY with > > the same mode than the internal one. > >=20 > > Reported-by: Andr=C3=A9 Przywara > > Signed-off-by: Corentin Labbe >=20 > Series applied. >=20 > Please provide a proper "[PATCH 0/n] " header posting next time. Sorry could you wait for applying, there are a parallel thread (http://www.= spinics.net/lists/devicetree/msg183520.html) and it seems finaly that inter= nal could not be the good way to do it. Regards Sorry again, I should have sent a comment for waiting. --=20 You received this message because you are subscribed to the Google Groups "= linux-sunxi" group. To unsubscribe from this group and stop receiving emails from it, send an e= mail to linux-sunxi+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org For more options, visit https://groups.google.com/d/optout. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752942AbdF2RC4 (ORCPT ); Thu, 29 Jun 2017 13:02:56 -0400 Received: from mail-wr0-f193.google.com ([209.85.128.193]:33326 "EHLO mail-wr0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751690AbdF2RCs (ORCPT ); Thu, 29 Jun 2017 13:02:48 -0400 Date: Thu, 29 Jun 2017 19:02:38 +0200 From: Corentin Labbe To: David Miller Cc: robh+dt@kernel.org, mark.rutland@arm.com, linux@armlinux.org.uk, maxime.ripard@free-electrons.com, wens@csie.org, peppe.cavallaro@st.com, alexandre.torgue@st.com, andre.przywara@arm.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-sunxi@googlegroups.com Subject: Re: [PATCH 1/6] net: stmmac: support future possible different internal phy mode Message-ID: <20170629170238.GA2606@Red> References: <20170627092806.28181-1-clabbe.montjoie@gmail.com> <20170629.122349.2265868886957558079.davem@davemloft.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20170629.122349.2265868886957558079.davem@davemloft.net> User-Agent: Mutt/1.7.2 (2016-11-26) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 29, 2017 at 12:23:49PM -0400, David Miller wrote: > From: Corentin Labbe > Date: Tue, 27 Jun 2017 11:28:01 +0200 > > > The current way to find if the phy is internal is to compare DT phy-mode > > and emac_variant/internal_phy. > > But it will negate a possible future SoC where an external PHY use the > > same phy mode than the internal one. > > > > By using phy-mode = "internal" we permit to have an external PHY with > > the same mode than the internal one. > > > > Reported-by: André Przywara > > Signed-off-by: Corentin Labbe > > Series applied. > > Please provide a proper "[PATCH 0/n] " header posting next time. Sorry could you wait for applying, there are a parallel thread (http://www.spinics.net/lists/devicetree/msg183520.html) and it seems finaly that internal could not be the good way to do it. Regards Sorry again, I should have sent a comment for waiting.