From: Andrew Lunn <andrew@lunn.ch>
To: Franklin S Cooper Jr <fcooper@ti.com>
Cc: linux-can@vger.kernel.org, netdev@vger.kernel.org,
wg@grandegger.com, mkl@pengutronix.de,
devicetree@vger.kernel.org
Subject: Re: CAN-FD Transceiver Limitations
Date: Thu, 29 Jun 2017 19:19:00 +0200 [thread overview]
Message-ID: <20170629171900.GA17008@lunn.ch> (raw)
In-Reply-To: <c0d3d772-6939-d22c-b954-3ba6486a9ede@ti.com>
> Also I agree that attempting to make this optional property/subnode
> generic to all of CAN would be preferable. Another not sure if its
> feasible yet without standardization being first forced across all CAN
> drivers.
It should be. All you need to do is add an
of_get_can_maxspeed(struct device_node *np)
for drivers to call.
If it finds the property, return its value, otherwise return the
standardised 1Mbps.
And you probably want to do the verify in can_changelink(), by adding
the max speed into the can_priv structure somewhere.
Andrew
next prev parent reply other threads:[~2017-06-29 17:19 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-28 22:14 CAN-FD Transceiver Limitations Franklin S Cooper Jr
2017-06-28 22:14 ` Franklin S Cooper Jr
2017-06-29 14:21 ` Andrew Lunn
2017-06-29 14:49 ` Franklin S Cooper Jr
2017-06-29 14:49 ` Franklin S Cooper Jr
2017-06-29 15:41 ` Andrew Lunn
2017-06-29 16:36 ` Franklin S Cooper Jr
2017-06-29 16:36 ` Franklin S Cooper Jr
2017-06-29 17:19 ` Andrew Lunn [this message]
2017-06-29 22:36 ` Kurt Van Dijck
[not found] ` <20170629223551.GA6568-W3bwb+3xS1LIj2mJfgo99rBP9FGTfoIhIWnq8iejnXE@public.gmane.org>
2017-06-29 23:14 ` Franklin S Cooper Jr
2017-06-29 23:14 ` Franklin S Cooper Jr
[not found] ` <d5c2e2f2-8b74-58e1-0cc8-727ba39bd14c-l0cyMroinI0@public.gmane.org>
2017-06-30 8:09 ` Kurt Van Dijck
[not found] ` <20170630080906.GA26712-W3bwb+3xS1LIj2mJfgo99rBP9FGTfoIhIWnq8iejnXE@public.gmane.org>
2017-06-30 17:51 ` Franklin S Cooper Jr
2017-06-30 17:51 ` Franklin S Cooper Jr
2017-07-10 14:58 ` Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170629171900.GA17008@lunn.ch \
--to=andrew@lunn.ch \
--cc=devicetree@vger.kernel.org \
--cc=fcooper@ti.com \
--cc=linux-can@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.