From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 4/4] drm/i915: Add support for CCS modifiers Date: Thu, 29 Jun 2017 23:02:08 +0300 Message-ID: <20170629200208.GI12629@intel.com> References: <20170623164544.7362-1-ben@bwidawsk.net> <20170623164544.7362-5-ben@bwidawsk.net> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20170623164544.7362-5-ben@bwidawsk.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Ben Widawsky Cc: Intel GFX , Daniel Stone , DRI Development List-Id: dri-devel@lists.freedesktop.org T24gRnJpLCBKdW4gMjMsIDIwMTcgYXQgMDk6NDU6NDRBTSAtMDcwMCwgQmVuIFdpZGF3c2t5IHdy b3RlOgo+IHYyOgo+IFN1cHBvcnQgc3ByaXRlIHBsYW5lLgo+IFN1cHBvcnQgcGlwZSBDL0QgbGlt aXRhdGlvbiBvbiBHRU45Lgo+IAo+IFRoaXMgcmVxdWlyZXMgcmViYXNlIG9uIHRoZSBjb3JyZWN0 IFZpbGxlIHBhdGNoZXMKPiAKPiBDYzogRGFuaWVsIFN0b25lIDxkYW5pZWxzQGNvbGxhYm9yYS5j b20+Cj4gQ2M6IEtyaXN0aWFuIEjDuGdzYmVyZyA8a3JoQGJpdHBsYW5ldC5uZXQ+Cj4gU2lnbmVk LW9mZi1ieTogQmVuIFdpZGF3c2t5IDxiZW5AYndpZGF3c2submV0Pgo+IC0tLQo+ICBkcml2ZXJz L2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMgfCAzNCArKysrKysrKysrKysrKysrKysrKysr KysrLS0tLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3Nwcml0ZS5jICB8IDM5ICsr KysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrLQo+ICAyIGZpbGVzIGNoYW5nZWQsIDY2 IGluc2VydGlvbnMoKyksIDcgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVs X2Rpc3BsYXkuYwo+IGluZGV4IDg3N2E1MTUxNGM2MS4uMmEwZTVjZDI2MDU5IDEwMDY0NAo+IC0t LSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+ICsrKyBiL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+IEBAIC05Myw3ICs5MywxNyBAQCBzdGF0aWMg Y29uc3QgdWludDMyX3Qgc2tsX3ByaW1hcnlfZm9ybWF0c1tdID0gewo+ICAJRFJNX0ZPUk1BVF9W WVVZLAo+ICB9Owo+ICAKPiArc3RhdGljIGNvbnN0IHVpbnQ2NF90IHNrbF9mb3JtYXRfbW9kaWZp ZXJzX25vY2NzW10gPSB7Cj4gKwlJOTE1X0ZPUk1BVF9NT0RfWWZfVElMRUQsCj4gKwlJOTE1X0ZP Uk1BVF9NT0RfWV9USUxFRCwKPiArCUk5MTVfRk9STUFUX01PRF9YX1RJTEVELAo+ICsJRFJNX0ZP Uk1BVF9NT0RfTElORUFSLAo+ICsJRFJNX0ZPUk1BVF9NT0RfSU5WQUxJRAo+ICt9Owo+ICsKPiAg c3RhdGljIGNvbnN0IHVpbnQ2NF90IHNrbF9mb3JtYXRfbW9kaWZpZXJzW10gPSB7CgpNYXliZSBj YWxscyB0aGlzIF9jY3NbXSB0aGVuPwoKPiArCUk5MTVfRk9STUFUX01PRF9ZZl9USUxFRF9DQ1Ms Cj4gKwlJOTE1X0ZPUk1BVF9NT0RfWV9USUxFRF9DQ1MsCj4gIAlJOTE1X0ZPUk1BVF9NT0RfWWZf VElMRUQsCj4gIAlJOTE1X0ZPUk1BVF9NT0RfWV9USUxFRCwKPiAgCUk5MTVfRk9STUFUX01PRF9Y X1RJTEVELAo+IEBAIC0xMzg3MiwxNyArMTM4ODIsMTMgQEAgc3RhdGljIGJvb2wgc2tsX21vZF9z dXBwb3J0ZWQodWludDMyX3QgZm9ybWF0LCB1aW50NjRfdCBtb2RpZmllcikKPiAgCQkJcmV0dXJu IGZhbHNlOwo+ICAJCX0KPiAgCWNhc2UgRFJNX0ZPUk1BVF9SR0I1NjU6Cj4gLQljYXNlIERSTV9G T1JNQVRfWFJHQjg4ODg6Cj4gLQljYXNlIERSTV9GT1JNQVRfWEJHUjg4ODg6Cj4gLQljYXNlIERS TV9GT1JNQVRfQVJHQjg4ODg6Cj4gLQljYXNlIERSTV9GT1JNQVRfQUJHUjg4ODg6Cj4gIAljYXNl IERSTV9GT1JNQVRfWFJHQjIxMDEwMTA6Cj4gIAljYXNlIERSTV9GT1JNQVRfWEJHUjIxMDEwMTA6 Cj4gIAljYXNlIERSTV9GT1JNQVRfWVVZVjoKPiAgCWNhc2UgRFJNX0ZPUk1BVF9ZVllVOgo+ICAJ Y2FzZSBEUk1fRk9STUFUX1VZVlk6Cj4gIAljYXNlIERSTV9GT1JNQVRfVllVWToKPiAtCQkvKiBB bGwgaTkxNSBtb2RpZmllcnMgYXJlIGZpbmUgKi8KPiArCQkvKiBBbGwgbm9uLWNjcyBpOTE1IG1v ZGlmaWVycyBhcmUgZmluZSAqLwo+ICAJCXN3aXRjaCAobW9kaWZpZXIpIHsKPiAgCQljYXNlIERS TV9GT1JNQVRfTU9EX0xJTkVBUjoKPiAgCQljYXNlIEk5MTVfRk9STUFUX01PRF9YX1RJTEVEOgo+ IEBAIC0xMzg5Miw2ICsxMzg5OCwxMiBAQCBzdGF0aWMgYm9vbCBza2xfbW9kX3N1cHBvcnRlZCh1 aW50MzJfdCBmb3JtYXQsIHVpbnQ2NF90IG1vZGlmaWVyKQo+ICAJCWRlZmF1bHQ6Cj4gIAkJCXJl dHVybiBmYWxzZTsKPiAgCQl9Cj4gKwljYXNlIERSTV9GT1JNQVRfWFJHQjg4ODg6Cj4gKwljYXNl IERSTV9GT1JNQVRfWEJHUjg4ODg6Cj4gKwljYXNlIERSTV9GT1JNQVRfQVJHQjg4ODg6Cj4gKwlj YXNlIERSTV9GT1JNQVRfQUJHUjg4ODg6Cj4gKwkJLyogQWxsIGk5MTUgbW9kaWZpZXJzIGFyZSBm aW5lICovCj4gKwkJcmV0dXJuIHRydWU7Cj4gIAlkZWZhdWx0Ogo+ICAJCXJldHVybiBmYWxzZTsK PiAgCX0KPiBAQCAtMTQxMjMsMTMgKzE0MTM1LDIzIEBAIGludGVsX3ByaW1hcnlfcGxhbmVfY3Jl YXRlKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwgZW51bSBwaXBlIHBpcGUpCj4g IAlwcmltYXJ5LT5mcm9udGJ1ZmZlcl9iaXQgPSBJTlRFTF9GUk9OVEJVRkZFUl9QUklNQVJZKHBp cGUpOwo+ICAJcHJpbWFyeS0+Y2hlY2tfcGxhbmUgPSBpbnRlbF9jaGVja19wcmltYXJ5X3BsYW5l Owo+ICAKPiAtCWlmIChJTlRFTF9HRU4oZGV2X3ByaXYpID49IDkpIHsKPiArCWlmIChJTlRFTF9H RU4oZGV2X3ByaXYpID49IDEwKSB7Cj4gIAkJaW50ZWxfcHJpbWFyeV9mb3JtYXRzID0gc2tsX3By aW1hcnlfZm9ybWF0czsKPiAgCQludW1fZm9ybWF0cyA9IEFSUkFZX1NJWkUoc2tsX3ByaW1hcnlf Zm9ybWF0cyk7Cj4gIAkJaW50ZWxfZm9ybWF0X21vZGlmaWVycyA9IHNrbF9mb3JtYXRfbW9kaWZp ZXJzOwo+ICAKPiAgCQlwcmltYXJ5LT51cGRhdGVfcGxhbmUgPSBza3lsYWtlX3VwZGF0ZV9wcmlt YXJ5X3BsYW5lOwo+ICAJCXByaW1hcnktPmRpc2FibGVfcGxhbmUgPSBza3lsYWtlX2Rpc2FibGVf cHJpbWFyeV9wbGFuZTsKPiArCX0gZWxzZSBpZiAoSU5URUxfR0VOKGRldl9wcml2KSA+PSA5KSB7 Cj4gKwkJaW50ZWxfcHJpbWFyeV9mb3JtYXRzID0gc2tsX3ByaW1hcnlfZm9ybWF0czsKPiArCQlu dW1fZm9ybWF0cyA9IEFSUkFZX1NJWkUoc2tsX3ByaW1hcnlfZm9ybWF0cyk7Cj4gKwkJaWYgKHBp cGUgPj0gUElQRV9DKQoKSSB0aGluayBJJ2Qga2VlcCB0aGUgZ2VuMTAgc3R1ZmYgaW4gdGhlIHNh bWUgYnJhbmNoIHN0aWxsLiBBbHNvIHRoaXMKbWlzc2VzIEdMSy4gU28gbWF5YmUgc29tZXRoaW5n IGxpa2UgdGhpczoKCmlmIChHRU4gPj0gMTAgfHwgSVNfR0xLIHx8IHBpcGUgIT0gUElQRV9DKQoK PiArCQkJaW50ZWxfZm9ybWF0X21vZGlmaWVycyA9IHNrbF9mb3JtYXRfbW9kaWZpZXJzOwo+ICsJ CWVsc2UKPiArCQkJaW50ZWxfZm9ybWF0X21vZGlmaWVycyA9IHNrbF9mb3JtYXRfbW9kaWZpZXJz X25vY2NzOwo+ICsKPiArCQlwcmltYXJ5LT51cGRhdGVfcGxhbmUgPSBza3lsYWtlX3VwZGF0ZV9w cmltYXJ5X3BsYW5lOwo+ICsJCXByaW1hcnktPmRpc2FibGVfcGxhbmUgPSBza3lsYWtlX2Rpc2Fi bGVfcHJpbWFyeV9wbGFuZTsKPiAgCX0gZWxzZSBpZiAoSU5URUxfR0VOKGRldl9wcml2KSA+PSA0 KSB7Cj4gIAkJaW50ZWxfcHJpbWFyeV9mb3JtYXRzID0gaTk2NV9wcmltYXJ5X2Zvcm1hdHM7Cj4g IAkJbnVtX2Zvcm1hdHMgPSBBUlJBWV9TSVpFKGk5NjVfcHJpbWFyeV9mb3JtYXRzKTsKPiBkaWZm IC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfc3ByaXRlLmMgYi9kcml2ZXJzL2dw dS9kcm0vaTkxNS9pbnRlbF9zcHJpdGUuYwo+IGluZGV4IGU4MDgzNGNiMWY0Yy4uZGU0NDU0YThl ZjllIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3Nwcml0ZS5jCj4g KysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfc3ByaXRlLmMKPiBAQCAtMTA4NSw3ICsx MDg1LDE3IEBAIHN0YXRpYyB1aW50MzJfdCBza2xfcGxhbmVfZm9ybWF0c1tdID0gewo+ICAJRFJN X0ZPUk1BVF9WWVVZLAo+ICB9Owo+ICAKPiArc3RhdGljIGNvbnN0IHVpbnQ2NF90IHNrbF9wbGFu ZV9mb3JtYXRfbW9kaWZpZXJzX25vY2NzW10gPSB7Cj4gKwlJOTE1X0ZPUk1BVF9NT0RfWWZfVElM RUQsCj4gKwlJOTE1X0ZPUk1BVF9NT0RfWV9USUxFRCwKPiArCUk5MTVfRk9STUFUX01PRF9YX1RJ TEVELAo+ICsJRFJNX0ZPUk1BVF9NT0RfTElORUFSLAo+ICsJRFJNX0ZPUk1BVF9NT0RfSU5WQUxJ RAo+ICt9Owo+ICsKPiAgc3RhdGljIGNvbnN0IHVpbnQ2NF90IHNrbF9wbGFuZV9mb3JtYXRfbW9k aWZpZXJzW10gPSB7CgpBZ2FpbiBfY2NzW10gbWF5YmU/Cgo+ICsJSTkxNV9GT1JNQVRfTU9EX1lm X1RJTEVEX0NDUywKPiArCUk5MTVfRk9STUFUX01PRF9ZX1RJTEVEX0NDUywKPiAgCUk5MTVfRk9S TUFUX01PRF9ZZl9USUxFRCwKPiAgCUk5MTVfRk9STUFUX01PRF9ZX1RJTEVELAo+ICAJSTkxNV9G T1JNQVRfTU9EX1hfVElMRUQsCj4gQEAgLTExMDgsNiArMTExOCwyMCBAQCBzdGF0aWMgYm9vbCBp bnRlbF9zcHJpdGVfcGxhbmVfZm9ybWF0X21vZF9zdXBwb3J0ZWQoc3RydWN0IGRybV9wbGFuZSAq cGxhbmUsCj4gIAkgICAgbW9kaWZpZXIgIT0gRFJNX0ZPUk1BVF9NT0RfTElORUFSKQo+ICAJCXJl dHVybiBmYWxzZTsKPiAgCj4gKwlzd2l0Y2ggKG1vZGlmaWVyKSB7Cj4gKwljYXNlIEk5MTVfRk9S TUFUX01PRF9ZZl9USUxFRF9DQ1M6Cj4gKwljYXNlIEk5MTVfRk9STUFUX01PRF9ZX1RJTEVEX0ND UzoKPiArCQlzd2l0Y2ggKGZvcm1hdCkgewo+ICsJCWNhc2UgRFJNX0ZPUk1BVF9BQkdSODg4ODoK PiArCQljYXNlIERSTV9GT1JNQVRfQVJHQjg4ODg6Cj4gKwkJY2FzZSBEUk1fRk9STUFUX1hCR1I4 ODg4Ogo+ICsJCWNhc2UgRFJNX0ZPUk1BVF9YUkdCODg4ODoKPiArCQkJcmV0dXJuIHRydWU7Cj4g KwkJZGVmYXVsdDoKPiArCQkJcmV0dXJuIGZhbHNlOwo+ICsJCX0KPiArCX0KPiArCj4gIAlzd2l0 Y2ggKGZvcm1hdCkgewo+ICAJCWNhc2UgRFJNX0ZPUk1BVF9YQkdSMjEwMTAxMDoKPiAgCQljYXNl IERSTV9GT1JNQVRfQUJHUjIxMDEwMTA6Cj4gQEAgLTExNzMsNyArMTE5Nyw3IEBAIGludGVsX3Nw cml0ZV9wbGFuZV9jcmVhdGUoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LAo+ICAJ fQo+ICAJaW50ZWxfcGxhbmUtPmJhc2Uuc3RhdGUgPSAmc3RhdGUtPmJhc2U7Cj4gIAo+IC0JaWYg KElOVEVMX0dFTihkZXZfcHJpdikgPj0gOSkgewo+ICsJaWYgKElOVEVMX0dFTihkZXZfcHJpdikg Pj0gMTApIHsKPiAgCQlpbnRlbF9wbGFuZS0+Y2FuX3NjYWxlID0gdHJ1ZTsKPiAgCQlzdGF0ZS0+ c2NhbGVyX2lkID0gLTE7Cj4gIAo+IEBAIC0xMTgzLDYgKzEyMDcsMTkgQEAgaW50ZWxfc3ByaXRl X3BsYW5lX2NyZWF0ZShzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsCj4gIAkJcGxh bmVfZm9ybWF0cyA9IHNrbF9wbGFuZV9mb3JtYXRzOwo+ICAJCW51bV9wbGFuZV9mb3JtYXRzID0g QVJSQVlfU0laRShza2xfcGxhbmVfZm9ybWF0cyk7Cj4gIAkJbW9kaWZpZXJzID0gc2tsX3BsYW5l X2Zvcm1hdF9tb2RpZmllcnM7Cj4gKwl9IGVsc2UgaWYgKElOVEVMX0dFTihkZXZfcHJpdikgPj0g OSkgewo+ICsJCWludGVsX3BsYW5lLT5jYW5fc2NhbGUgPSB0cnVlOwo+ICsJCXN0YXRlLT5zY2Fs ZXJfaWQgPSAtMTsKPiArCj4gKwkJaW50ZWxfcGxhbmUtPnVwZGF0ZV9wbGFuZSA9IHNrbF91cGRh dGVfcGxhbmU7Cj4gKwkJaW50ZWxfcGxhbmUtPmRpc2FibGVfcGxhbmUgPSBza2xfZGlzYWJsZV9w bGFuZTsKPiArCj4gKwkJcGxhbmVfZm9ybWF0cyA9IHNrbF9wbGFuZV9mb3JtYXRzOwo+ICsJCW51 bV9wbGFuZV9mb3JtYXRzID0gQVJSQVlfU0laRShza2xfcGxhbmVfZm9ybWF0cyk7Cj4gKwkJaWYg KHBpcGUgPj0gUElQRV9DKQo+ICsJCQltb2RpZmllcnMgPSBza2xfcGxhbmVfZm9ybWF0X21vZGlm aWVyc19ub2NjczsKPiArCQllbHNlCj4gKwkJCW1vZGlmaWVycyA9IHNrbF9wbGFuZV9mb3JtYXRf bW9kaWZpZXJzOwo+ICAJfSBlbHNlIGlmIChJU19WQUxMRVlWSUVXKGRldl9wcml2KSB8fCBJU19D SEVSUllWSUVXKGRldl9wcml2KSkgewo+ICAJCWludGVsX3BsYW5lLT5jYW5fc2NhbGUgPSBmYWxz ZTsKPiAgCQlpbnRlbF9wbGFuZS0+bWF4X2Rvd25zY2FsZSA9IDE7Cj4gLS0gCj4gMi4xMy4xCj4g Cj4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPiBkcmkt ZGV2ZWwgbWFpbGluZyBsaXN0Cj4gZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+IGh0 dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCgot LSAKVmlsbGUgU3lyasOkbMOkCkludGVsIE9UQwpfX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0 cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9s aXN0aW5mby9pbnRlbC1nZngK