From mboxrd@z Thu Jan 1 00:00:00 1970 From: gregkh@linuxfoundation.org (Greg KH) Date: Fri, 30 Jun 2017 07:55:57 +0200 Subject: [RESEND PATCH] drm/hisilicon: Ensure LDI regs are properly configured. In-Reply-To: <1498769678-12155-1-git-send-email-peter.griffin@linaro.org> References: <1498769678-12155-1-git-send-email-peter.griffin@linaro.org> Message-ID: <20170630055557.GA23014@kroah.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thu, Jun 29, 2017 at 09:54:38PM +0100, Peter Griffin wrote: > This patch fixes the following soft lockup: > BUG: soft lockup - CPU#0 stuck for 23s! [weston:307] > > On weston idle-timeout the IP is powered down and reset > asserted. On weston resume we get a massive vblank > IRQ storm due to the LDI registers having lost some state. > > This state loss is caused by ade_crtc_atomic_begin() not > calling ade_ldi_set_mode(). With this patch applied > resuming from Weston idle-timeout works well. > > Signed-off-by: Peter Griffin > --- > drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c | 3 +++ > 1 file changed, 3 insertions(+) > This is not the correct way to submit patches for inclusion in the stable kernel tree. Please read: https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html for how to do this properly. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Subject: Re: [RESEND PATCH] drm/hisilicon: Ensure LDI regs are properly configured. Date: Fri, 30 Jun 2017 07:55:57 +0200 Message-ID: <20170630055557.GA23014@kroah.com> References: <1498769678-12155-1-git-send-email-peter.griffin@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0268F6E770 for ; Fri, 30 Jun 2017 05:55:59 +0000 (UTC) Content-Disposition: inline In-Reply-To: <1498769678-12155-1-git-send-email-peter.griffin@linaro.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Peter Griffin Cc: puck.chen@hisilicon.com, linux-kernel@vger.kernel.org, stable@vger.kernel.org, z.liuxinliang@hisilicon.com, kong.kongxinwei@hisilicon.com, dri-devel@lists.freedesktop.org, zourongrong@gmail.com, fathi.boudra@linaro.org, andrey.konovalov@linaro.org, linux-arm-kernel@lists.infradead.org List-Id: dri-devel@lists.freedesktop.org T24gVGh1LCBKdW4gMjksIDIwMTcgYXQgMDk6NTQ6MzhQTSArMDEwMCwgUGV0ZXIgR3JpZmZpbiB3 cm90ZToKPiBUaGlzIHBhdGNoIGZpeGVzIHRoZSBmb2xsb3dpbmcgc29mdCBsb2NrdXA6Cj4gICBC VUc6IHNvZnQgbG9ja3VwIC0gQ1BVIzAgc3R1Y2sgZm9yIDIzcyEgW3dlc3RvbjozMDddCj4gCj4g T24gd2VzdG9uIGlkbGUtdGltZW91dCB0aGUgSVAgaXMgcG93ZXJlZCBkb3duIGFuZCByZXNldAo+ IGFzc2VydGVkLiBPbiB3ZXN0b24gcmVzdW1lIHdlIGdldCBhIG1hc3NpdmUgdmJsYW5rCj4gSVJR IHN0b3JtIGR1ZSB0byB0aGUgTERJIHJlZ2lzdGVycyBoYXZpbmcgbG9zdCBzb21lIHN0YXRlLgo+ IAo+IFRoaXMgc3RhdGUgbG9zcyBpcyBjYXVzZWQgYnkgYWRlX2NydGNfYXRvbWljX2JlZ2luKCkg bm90Cj4gY2FsbGluZyBhZGVfbGRpX3NldF9tb2RlKCkuIFdpdGggdGhpcyBwYXRjaCBhcHBsaWVk Cj4gcmVzdW1pbmcgZnJvbSBXZXN0b24gaWRsZS10aW1lb3V0IHdvcmtzIHdlbGwuCj4gCj4gU2ln bmVkLW9mZi1ieTogUGV0ZXIgR3JpZmZpbiA8cGV0ZXIuZ3JpZmZpbkBsaW5hcm8ub3JnPgo+IC0t LQo+ICBkcml2ZXJzL2dwdS9kcm0vaGlzaWxpY29uL2tpcmluL2tpcmluX2RybV9hZGUuYyB8IDMg KysrCj4gIDEgZmlsZSBjaGFuZ2VkLCAzIGluc2VydGlvbnMoKykKPiAKCjxmb3JtbGV0dGVyPgoK VGhpcyBpcyBub3QgdGhlIGNvcnJlY3Qgd2F5IHRvIHN1Ym1pdCBwYXRjaGVzIGZvciBpbmNsdXNp b24gaW4gdGhlCnN0YWJsZSBrZXJuZWwgdHJlZS4gIFBsZWFzZSByZWFkOgogICAgaHR0cHM6Ly93 d3cua2VybmVsLm9yZy9kb2MvaHRtbC9sYXRlc3QvcHJvY2Vzcy9zdGFibGUta2VybmVsLXJ1bGVz Lmh0bWwKZm9yIGhvdyB0byBkbyB0aGlzIHByb3Blcmx5LgoKPC9mb3JtbGV0dGVyPgpfX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGlu ZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVl ZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751878AbdF3F4C (ORCPT ); Fri, 30 Jun 2017 01:56:02 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:42594 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751494AbdF3F4A (ORCPT ); Fri, 30 Jun 2017 01:56:00 -0400 Date: Fri, 30 Jun 2017 07:55:57 +0200 From: Greg KH To: Peter Griffin Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, z.liuxinliang@hisilicon.com, zourongrong@gmail.com, kong.kongxinwei@hisilicon.com, puck.chen@hisilicon.com, airlied@linux.ie, stable@vger.kernel.org, john.stultz@linaro.org, dri-devel@lists.freedesktop.org, andrey.konovalov@linaro.org, fathi.boudra@linaro.org Subject: Re: [RESEND PATCH] drm/hisilicon: Ensure LDI regs are properly configured. Message-ID: <20170630055557.GA23014@kroah.com> References: <1498769678-12155-1-git-send-email-peter.griffin@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1498769678-12155-1-git-send-email-peter.griffin@linaro.org> User-Agent: Mutt/1.8.3 (2017-05-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 29, 2017 at 09:54:38PM +0100, Peter Griffin wrote: > This patch fixes the following soft lockup: > BUG: soft lockup - CPU#0 stuck for 23s! [weston:307] > > On weston idle-timeout the IP is powered down and reset > asserted. On weston resume we get a massive vblank > IRQ storm due to the LDI registers having lost some state. > > This state loss is caused by ade_crtc_atomic_begin() not > calling ade_ldi_set_mode(). With this patch applied > resuming from Weston idle-timeout works well. > > Signed-off-by: Peter Griffin > --- > drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c | 3 +++ > 1 file changed, 3 insertions(+) > This is not the correct way to submit patches for inclusion in the stable kernel tree. Please read: https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html for how to do this properly.