From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48575) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dQpJy-00038L-Uh for qemu-devel@nongnu.org; Fri, 30 Jun 2017 02:22:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dQpJv-0001mv-Qn for qemu-devel@nongnu.org; Fri, 30 Jun 2017 02:22:26 -0400 Received: from mx1.redhat.com ([209.132.183.28]:49362) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dQpJv-0001mV-Jx for qemu-devel@nongnu.org; Fri, 30 Jun 2017 02:22:23 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 90F1B40F38 for ; Fri, 30 Jun 2017 06:22:22 +0000 (UTC) Date: Fri, 30 Jun 2017 14:22:16 +0800 From: Peter Xu Message-ID: <20170630062216.GC24859@pxdev.xzpeter.org> References: <1498536619-14548-1-git-send-email-peterx@redhat.com> <1498536619-14548-11-git-send-email-peterx@redhat.com> <20170628171244.GA5167@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20170628171244.GA5167@localhost.localdomain> Subject: Re: [Qemu-devel] [PATCH v6 10/10] migration: hmp: dump globals List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost Cc: qemu-devel@nongnu.org, Laurent Vivier , Eric Blake , Markus Armbruster , Juan Quintela , "Dr . David Alan Gilbert" On Wed, Jun 28, 2017 at 02:12:44PM -0300, Eduardo Habkost wrote: > On Tue, Jun 27, 2017 at 12:10:19PM +0800, Peter Xu wrote: > > Now we have some globals that can be configured for migration. Dump them > > in HMP info migration for better debugging. > > > > (we can also use this to monitor whether COMPAT fields are applied > > correctly on compatible machines) > > > > Reviewed-by: Juan Quintela > > Signed-off-by: Peter Xu > [...] > > +void migration_global_dump(Monitor *mon) > > +{ > > + MigrationState *ms = migrate_get_current(); > > + > > + monitor_printf(mon, "globals: store-global-state=%d, only_migratable=%d, " > > + "send-configuration=%d, send-section-footer=%d\n", > > + ms->store_global_state, ms->only_migratable, > > + ms->send_configuration, ms->send_section_footer); > > I wouldn't call them "globals", I would just call them "properties" (or > maybe just "settings"). They happen to be affected by global properties > if the accel/machine/user sets them, but they are just plain old QOM > properties. Yes, "properties" seems better. Considering that the patch is already merged, I am just afraid it's too trivial to send a single patch to fix this, so I'll just temporarily skip this one. Anyway, please let me know if you still want me to do this, I'd be glad to. Thanks, -- Peter Xu