From: Johannes Thumshirn <jthumshirn@suse.de>
To: Heinz Mauelshagen <heinzm@redhat.com>
Cc: dm-devel@redhat.com
Subject: Re: [PATCH RESEND] dm-raid: Do not call BUG() in __rdev_sectors()
Date: Fri, 30 Jun 2017 09:33:11 +0200 [thread overview]
Message-ID: <20170630073310.GD5236@linux-x5ow.site> (raw)
In-Reply-To: <17f4e017-f3f8-01dd-d305-dae30f93ae06@redhat.com>
On Thu, Jun 29, 2017 at 04:09:38PM +0200, Heinz Mauelshagen wrote:
>
> Hi Hannes,
>
> thanks for your patch.
>
> BUG() is intentional there to catch what I've already fixed with patch
>
> "[dm-devel] [PATCH] dm raid: fix oops on upgrading to extended superblock
> format"
>
> on 06/23/2017.
>
> IOW: returning 0 is never right and would hide bugs like that one fixed.
OTOH panicing systems to catch errors which could've been mitigted is
never right as well. Not a single time. Never. BUG() and BUG_ON() are not
for error handling.
--
Johannes Thumshirn Storage
jthumshirn@suse.de +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
next prev parent reply other threads:[~2017-06-30 7:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-28 8:04 [PATCH RESEND] dm-raid: Do not call BUG() in __rdev_sectors() Hannes Reinecke
2017-06-28 17:18 ` Mike Snitzer
2017-06-29 14:09 ` Heinz Mauelshagen
2017-06-30 7:33 ` Johannes Thumshirn [this message]
2017-06-30 12:33 ` Heinz Mauelshagen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170630073310.GD5236@linux-x5ow.site \
--to=jthumshirn@suse.de \
--cc=dm-devel@redhat.com \
--cc=heinzm@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.