Re: 1131482629 ("posix-timers: Use get_timepsec64() and .."): BUG: unable to handle kernel NULL pointer dereference at 0000000000000008

[Al Viro <viro@ZenIV.linux.org.uk>]

[-- Attachment #1: Type: text/plain, Size: 1309 bytes --]

On Fri, Jun 30, 2017 at 03:57:35PM +0800, kernel test robot wrote:
> Greetings,
> 
> 0day kernel testing robot got the below dmesg and the first bad commit is
> 
> git://internal_merge_and_test_tree devel-catchup-201706292032
> 
> commit 11314826298445e447cc52df284d55f1e1137519
> Author:     Deepa Dinamani <deepa.kernel@gmail.com>
> AuthorDate: Sat Jun 24 11:45:05 2017 -0700
> Commit:     Al Viro <viro@zeniv.linux.org.uk>
> CommitDate: Sun Jun 25 21:58:46 2017 -0400
> 
>     posix-timers: Use get_timepsec64() and put_timespec64()
>     
>     Usage of these apis and their compat versions makes
>     the syscalls: clock_gettime, clock_settime, clock_getres
>     and their compat implementations simpler.
>     
>     This is a preparatory patch to isolate data conversions to
>     struct timespec64 at userspace boundaries. This helps contain
>     the changes needed to transition to new y2038 safe types.
>     
>     Signed-off-by: Deepa Dinamani <deepa.kernel@gmail.com>
>     Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>

... caused by this:
-       if (!kc || !kc->clock_set)
-               return -EINVAL;
-
without anything to replace it.  Similar bug in compat clock_getres().
Incidentally, it's 'timespec', not 'timepsec' ;-)

Fixed and force-pushed.