From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 3/4] drm/i915: Make i915_gem_object_phys_attach() use obj->mm.lock more appropriately Date: Fri, 30 Jun 2017 14:40:08 +0300 Message-ID: <20170630114008.GQ12629@intel.com> References: <20170615082509.23820-1-chris@chris-wilson.co.uk> <20170615082509.23820-3-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTPS id DFF866E194 for ; Fri, 30 Jun 2017 11:40:11 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20170615082509.23820-3-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCBKdW4gMTUsIDIwMTcgYXQgMDk6MjU6MDhBTSArMDEwMCwgQ2hyaXMgV2lsc29uIHdy b3RlOgo+IEFjdHVhbGx5IHRyYW5zZmVycmluZyBmcm9tIHNobWVtZnMgdG8gdGhlIHBoeXNpY2Fs bHkgY29udGlndW91cyBzZXQgb2YKPiBwYWdlcyBzaG91bGQgYmUgd2hvbGx5IGd1YXJkZWQgYnkg aXRzIG9iai0+bW0ubG9jayEKPiAKPiB2MjogUmVtZW1iZXIgdG8gZnJlZSB0aGUgb2xkIHBhZ2Vz Lgo+IAo+IFNpZ25lZC1vZmYtYnk6IENocmlzIFdpbHNvbiA8Y2hyaXNAY2hyaXMtd2lsc29uLmNv LnVrPgo+IENjOiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwuY29t Pgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbS5jIHwgNDQgKysrKysrKysr KysrKysrKysrKysrKysrKysrLS0tLS0tLS0tLS0tLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDI5IGlu c2VydGlvbnMoKyksIDE1IGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dw dS9kcm0vaTkxNS9pOTE1X2dlbS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW0uYwo+ IGluZGV4IDMxY2JlNzgxNzFhOS4uN2YzYmU1ZGVlYjVlIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2k5MTVfZ2VtLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1 X2dlbS5jCj4gQEAgLTU3NCw3ICs1NzQsOCBAQCBpbnQKPiAgaTkxNV9nZW1fb2JqZWN0X2F0dGFj aF9waHlzKHN0cnVjdCBkcm1faTkxNV9nZW1fb2JqZWN0ICpvYmosCj4gIAkJCSAgICBpbnQgYWxp Z24pCj4gIHsKPiAtCWludCByZXQ7Cj4gKwlzdHJ1Y3Qgc2dfdGFibGUgKnBhZ2VzOwo+ICsJaW50 IGVycjsKPiAgCj4gIAlpZiAoYWxpZ24gPiBvYmotPmJhc2Uuc2l6ZSkKPiAgCQlyZXR1cm4gLUVJ TlZBTDsKPiBAQCAtNTgyLDMyICs1ODMsNDUgQEAgaTkxNV9nZW1fb2JqZWN0X2F0dGFjaF9waHlz KHN0cnVjdCBkcm1faTkxNV9nZW1fb2JqZWN0ICpvYmosCj4gIAlpZiAob2JqLT5vcHMgPT0gJmk5 MTVfZ2VtX3BoeXNfb3BzKQo+ICAJCXJldHVybiAwOwo+ICAKPiAtCWlmIChvYmotPm1tLm1hZHYg IT0gSTkxNV9NQURWX1dJTExORUVEKQo+IC0JCXJldHVybiAtRUZBVUxUOwo+IC0KPiAtCWlmIChv YmotPmJhc2UuZmlscCA9PSBOVUxMKQo+ICsJaWYgKG9iai0+b3BzICE9ICZpOTE1X2dlbV9vYmpl Y3Rfb3BzKQo+ICAJCXJldHVybiAtRUlOVkFMOwo+ICAKPiAtCXJldCA9IGk5MTVfZ2VtX29iamVj dF91bmJpbmQob2JqKTsKPiAtCWlmIChyZXQpCj4gLQkJcmV0dXJuIHJldDsKPiArCWVyciA9IGk5 MTVfZ2VtX29iamVjdF91bmJpbmQob2JqKTsKPiArCWlmIChlcnIpCj4gKwkJcmV0dXJuIGVycjsK PiArCj4gKwltdXRleF9sb2NrKCZvYmotPm1tLmxvY2spOwo+ICsKPiArCWlmIChvYmotPm1tLnF1 aXJrZWQpIHsKPiArCQllcnIgPSAtRUZBVUxUOwo+ICsJCWdvdG8gZXJyX3VubG9jazsKPiArCX0K PiAgCj4gLQlfX2k5MTVfZ2VtX29iamVjdF9wdXRfcGFnZXMob2JqLCBJOTE1X01NX05PUk1BTCk7 Cj4gLQlpZiAob2JqLT5tbS5wYWdlcykKPiAtCQlyZXR1cm4gLUVCVVNZOwo+ICsJaWYgKG9iai0+ bW0ubWFwcGluZykgewo+ICsJCWVyciA9IC1FQlVTWTsKPiArCQlnb3RvIGVycl91bmxvY2s7Cj4g Kwl9Cj4gIAo+IC0JR0VNX0JVR19PTihvYmotPm9wcyAhPSAmaTkxNV9nZW1fb2JqZWN0X29wcyk7 Cj4gKwlwYWdlcyA9IG9iai0+bW0ucGFnZXM7Cj4gIAlvYmotPm9wcyA9ICZpOTE1X2dlbV9waHlz X29wczsKPiAgCj4gLQlyZXQgPSBpOTE1X2dlbV9vYmplY3RfcGluX3BhZ2VzKG9iaik7Cj4gLQlp ZiAocmV0KQo+ICsJZXJyID0gX19pOTE1X2dlbV9vYmplY3RfZ2V0X3BhZ2VzKG9iaik7Cj4gKwlp ZiAoZXJyKQo+ICAJCWdvdG8gZXJyX3hmZXI7Cj4gIAo+ICsJLyogUGVybWEtcGluICh1bnRpbCBy ZWxlYXNlKSB0aGUgcGh5c2ljYWwgc2V0IG9mIHBhZ2VzICovCj4gKwlfX2k5MTVfZ2VtX29iamVj dF9waW5fcGFnZXMob2JqKTsKPiArCj4gKwlpOTE1X2dlbV9vYmplY3Rfb3BzLnB1dF9wYWdlcyhv YmosIHBhZ2VzKTsKCkxlYWsgc29ydGVkLCBzbyB0aGlzIGxndG0uCgpSZXZpZXdlZC1ieTogVmls bGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4KCj4gKwltdXRleF91 bmxvY2soJm9iai0+bW0ubG9jayk7Cj4gIAlyZXR1cm4gMDsKPiAgCj4gIGVycl94ZmVyOgo+ICAJ b2JqLT5vcHMgPSAmaTkxNV9nZW1fb2JqZWN0X29wczsKPiAtCXJldHVybiByZXQ7Cj4gKwlvYmot Pm1tLnBhZ2VzID0gcGFnZXM7Cj4gK2Vycl91bmxvY2s6Cj4gKwltdXRleF91bmxvY2soJm9iai0+ bW0ubG9jayk7Cj4gKwlyZXR1cm4gZXJyOwo+ICB9Cj4gIAo+ICBzdGF0aWMgaW50Cj4gLS0gCj4g Mi4xMS4wCgotLSAKVmlsbGUgU3lyasOkbMOkCkludGVsIE9UQwpfX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVs LWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcv bWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK