Re: [PATCH] Btrfs-progs: convert: do not clear header rev

[Lu Fengqi <lufq.fnst@cn.fujitsu.com>]

On Fri, Jun 30, 2017 at 04:52:54PM +0200, David Sterba wrote:
>On Tue, Jun 27, 2017 at 12:07:13PM -0700, Liu Bo wrote:
>> On Mon, Jun 26, 2017 at 05:55:02PM -0600, Liu Bo wrote:
>> > So btrfs_set_header_flags() vs btrfs_set_header_flag, the difference is sort of
>> > similar to "=" vs "|=", when creating and initialising a new extent buffer,
>> > convert uses the former one which clears header_rev by accident.
>> >
>> 
>> Here is the regression test script,
>> 
>> mkfs.ext4 -F /disk
>> btrfs-convert -d /disk
>> mount /disk /mnt
>> xfs_io -f -c "pwrite 0 4K" /mnt/foobar
>> umount /disk
>> 
>> ---------------
>> It'd end up with 'unable to find ref blabla" shown in dmesg log.
>
>I can't reproduce it, is there something else needed? Tested kernel is
>4.11.6. Check does not complain either.

Excuse me, is your btrfs-progs already applied this patch?

I'm sure that I can reproduce it in my test environment.
1. kernel 4.11.6
2. btrfs-progs kdave/devel(drop this patch)

-- 
Thanks,
Lu