From: keith.busch@intel.com (Keith Busch)
Subject: [PATCHv2] nvme: Remove SCSI translations
Date: Fri, 30 Jun 2017 15:38:41 -0400 [thread overview]
Message-ID: <20170630193840.GA12428@localhost.localdomain> (raw)
In-Reply-To: <AT5PR84MB00825BA1A84C313BE26C1099ABD30@AT5PR84MB0082.NAMPRD84.PROD.OUTLOOK.COM>
On Fri, Jun 30, 2017@12:44:11PM +0000, Elliott, Robert (Persistent Memory) wrote:
>
> As Linda and Micah mentioned, this violates a cardinal linux kernel rule -
> it breaks user space.
>
> Please:
> 1. Incorporate the TEST UNIT READY bug fix now.
> 2. Add a WARN_ONCE printing a message that the interface that was just
> used is deprecated and will go away, and modify the CONFIG description
> to include that warning too.
> 3. Wait a few kernel cycles before really removing it.
I really want to emphasize a few points here:
The linux nvme driver support for SG_IO was never really working in the
first place. We can't break what's broken.
We're not making any nvme features unreachable by deleting broken
interfaces. The driver has supported a real NVMe management interface
since day 1, and open source tooling for it is freely available. These
tools are also part of many distribution's package repositories.
The NVMe translation for TUR has been broken for years and you didn't
notice. Your WARN proposal won't do you any good in that case, but
it certainly puts a burden on the developers trying to progress and
enhance NVMe.
The distributions supporting SCSI translations for NVMe are already
applying out of tree patches to enable them.
next prev parent reply other threads:[~2017-06-30 19:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-20 19:33 [PATCHv2] nvme: Remove SCSI translations Keith Busch
2017-06-21 7:30 ` Johannes Thumshirn
2017-06-21 8:19 ` Guan Junxiong
2017-06-30 2:00 ` Yang Feng
2017-06-30 13:48 ` Keith Busch
2017-06-30 12:44 ` Elliott, Robert (Persistent Memory)
2017-06-30 19:38 ` Keith Busch [this message]
2017-06-30 20:31 ` Linda Knippers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170630193840.GA12428@localhost.localdomain \
--to=keith.busch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.