From: Jonathan Cameron <jic23@kernel.org>
To: Angelo Compagnucci <angelo.compagnucci@gmail.com>
Cc: linux-iio@vger.kernel.org, Maarten Brock <m.brock@vanmierlo.com>
Subject: Re: [PATCH 1/3] iio: adc: mcp3422: Changing initial channel
Date: Sat, 1 Jul 2017 11:06:56 +0100 [thread overview]
Message-ID: <20170701110656.3ff5b462@kernel.org> (raw)
In-Reply-To: <1498687088-28529-1-git-send-email-angelo.compagnucci@gmail.com>
On Wed, 28 Jun 2017 23:53:09 +0200
Angelo Compagnucci <angelo.compagnucci@gmail.com> wrote:
> Initial channel should be the first available channel on
> all configurations, so changing to channel 0 available on
> all supported chips.
>
> Signed-off-by: Angelo Compagnucci <angelo.compagnucci@gmail.com>
I'm going to apply these the 'slow' route as the failure case in
patch 2 is reasonably uncommon. Maarten if you want to request
a back port to stable after these have merged (will probably
be a while given where we are in the cycle) then that's fine
with me.
Applied to the togreg branch of iio.git and pushed out as
testing for the autobuilders to play with it.
Thanks,
Jonathan
> ---
> drivers/iio/adc/mcp3422.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/adc/mcp3422.c b/drivers/iio/adc/mcp3422.c
> index 254135e..6737df8 100644
> --- a/drivers/iio/adc/mcp3422.c
> +++ b/drivers/iio/adc/mcp3422.c
> @@ -379,7 +379,7 @@ static int mcp3422_probe(struct i2c_client *client,
>
> /* meaningful default configuration */
> config = (MCP3422_CONT_SAMPLING
> - | MCP3422_CHANNEL_VALUE(1)
> + | MCP3422_CHANNEL_VALUE(0)
> | MCP3422_PGA_VALUE(MCP3422_PGA_1)
> | MCP3422_SAMPLE_RATE_VALUE(MCP3422_SRATE_240));
> mcp3422_update_config(adc, config);
prev parent reply other threads:[~2017-07-01 10:07 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-28 21:53 [PATCH 1/3] iio: adc: mcp3422: Changing initial channel Angelo Compagnucci
2017-06-28 21:53 ` [PATCH 2/3] iio: adc: mcp3422: Checking for error on probe Angelo Compagnucci
2017-07-01 10:07 ` Jonathan Cameron
2017-07-03 8:42 ` Maarten Brock
2017-07-03 11:10 ` jic23
2017-07-03 12:01 ` Maarten Brock
2017-07-03 12:11 ` Mike Looijmans
2017-07-03 12:25 ` jic23
2017-07-03 21:04 ` Angelo Compagnucci
2017-07-04 19:57 ` Jonathan Cameron
2017-06-28 21:53 ` [PATCH 3/3] iio: adc: mcp3422: cosmetic fixes Angelo Compagnucci
2017-07-01 10:12 ` Jonathan Cameron
2017-07-01 10:06 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170701110656.3ff5b462@kernel.org \
--to=jic23@kernel.org \
--cc=angelo.compagnucci@gmail.com \
--cc=linux-iio@vger.kernel.org \
--cc=m.brock@vanmierlo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.