From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.kernel.org ([198.145.29.99]:40570 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751753AbdGAKMU (ORCPT ); Sat, 1 Jul 2017 06:12:20 -0400 Date: Sat, 1 Jul 2017 11:12:16 +0100 From: Jonathan Cameron To: Angelo Compagnucci Cc: linux-iio@vger.kernel.org Subject: Re: [PATCH 3/3] iio: adc: mcp3422: cosmetic fixes Message-ID: <20170701111216.25943e98@kernel.org> In-Reply-To: <1498687088-28529-3-git-send-email-angelo.compagnucci@gmail.com> References: <1498687088-28529-1-git-send-email-angelo.compagnucci@gmail.com> <1498687088-28529-3-git-send-email-angelo.compagnucci@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-iio-owner@vger.kernel.org List-Id: linux-iio@vger.kernel.org On Wed, 28 Jun 2017 23:53:11 +0200 Angelo Compagnucci wrote: > This patch fixes some cosmetics in source code, it uniforms > tabs after carriage return on methods and fixes formatting. > > Signed-off-by: Angelo Compagnucci It's not a hard and fast rule, but, where possible, parameters should be aligned after the opening bracket. A few of these already did this. It would be nice to make the others follow that convention as well. Thanks, Jonathan > --- > drivers/iio/adc/mcp3422.c | 15 +++++++-------- > 1 file changed, 7 insertions(+), 8 deletions(-) > > diff --git a/drivers/iio/adc/mcp3422.c b/drivers/iio/adc/mcp3422.c > index 63de705..866d02f 100644 > --- a/drivers/iio/adc/mcp3422.c > +++ b/drivers/iio/adc/mcp3422.c > @@ -135,7 +135,7 @@ static int mcp3422_read(struct mcp3422 *adc, int *value, u8 *config) > } > > static int mcp3422_read_channel(struct mcp3422 *adc, > - struct iio_chan_spec const *channel, int *value) > + struct iio_chan_spec const *channel, int *value) > { > int ret; > u8 config; > @@ -157,14 +157,14 @@ static int mcp3422_read_channel(struct mcp3422 *adc, > } > > static int mcp3422_read_raw(struct iio_dev *iio, > - struct iio_chan_spec const *channel, int *val1, > - int *val2, long mask) > + struct iio_chan_spec const *channel, int *val1, > + int *val2, long mask) > { > struct mcp3422 *adc = iio_priv(iio); > int err; > > u8 sample_rate = MCP3422_SAMPLE_RATE(adc->config); > - u8 pga = MCP3422_PGA(adc->config); > + u8 pga = MCP3422_PGA(adc->config); > > switch (mask) { > case IIO_CHAN_INFO_RAW: > @@ -174,7 +174,6 @@ static int mcp3422_read_raw(struct iio_dev *iio, > return IIO_VAL_INT; > > case IIO_CHAN_INFO_SCALE: > - > *val1 = 0; > *val2 = mcp3422_scales[sample_rate][pga]; > return IIO_VAL_INT_PLUS_NANO; > @@ -191,8 +190,8 @@ static int mcp3422_read_raw(struct iio_dev *iio, > } > > static int mcp3422_write_raw(struct iio_dev *iio, > - struct iio_chan_spec const *channel, int val1, > - int val2, long mask) > + struct iio_chan_spec const *channel, int val1, > + int val2, long mask) > { > struct mcp3422 *adc = iio_priv(iio); > u8 temp; > @@ -331,7 +330,7 @@ static const struct iio_info mcp3422_info = { > }; > > static int mcp3422_probe(struct i2c_client *client, > - const struct i2c_device_id *id) > + const struct i2c_device_id *id) > { > struct iio_dev *indio_dev; > struct mcp3422 *adc;