From: "Marek Marczykowski-Górecki" <marmarek@invisiblethingslab.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: xen-devel <xen-devel@lists.xen.org>
Subject: Re: offtopic: handling patches
Date: Sun, 2 Jul 2017 11:24:28 +0200 [thread overview]
Message-ID: <20170702092428.GP1095@mail-itl> (raw)
In-Reply-To: <850278fd-5198-cb99-bc3f-50019645071c@citrix.com>
[-- Attachment #1.1: Type: text/plain, Size: 2431 bytes --]
On Fri, Jun 30, 2017 at 06:18:11PM +0100, Andrew Cooper wrote:
> On 30/06/17 17:57, Marek Marczykowski-Górecki wrote:
> > Hi,
> >
> > How you guys handle patches with emails? I know git am and git
> > format-patch/send-email, but those tools are quite limited, especially
> > when handling patch series, subsequent versions etc.
> > What I miss there:
> > - patch versioning (git notes could be used, but it doesn't survive git
> > commit --amend, nor git rebase)
> > - keeping/versioning cover email
> > - collecting Cc: from all patches in series into cover email
> > - adding Reviewed-by, Acked-by etc tags
> >
> > I can't believe you all do this all manually ;)
> > Is there any commonly available tool I can't find, or everyone have own
> > scripts?
>
> Manually, I'm afraid. I've never found anything more automatic which works.
>
> My general workflow is a single git branch which is always rebased onto
> staging.
>
> Patch version information lives in the commit message under a --- line,
This is excellent idea! I don't know why never thought of it...
> and I am frequent user of `git commit --fixup/--squash` and `git rebase
> --interactive`.
Me too :)
> I've a separate directory tree where I format patch series including
> cover letters, before using `git send-email --dry-run *.patch` to send
> them. These get recycled in a lazy fashon, typically once the series
> has been committed, but the old cover letters generally available in an
> adjacent directory when sending a newer series.
I've found git-series[1] tool. From the above list it allow you to diff
between series versions, and more importantly - keep cover letter in
git!
> For collecting and reviewing tags, look at the PatchWork `pwclient`
> utility. Its `git-am` mode automagically collects tags, which is
> fantastically useful for applying a patch for committing. (Then again,
> I do always manually check the conversation on list before actually
> committing the series.)
Thanks, indeed looks interesting.
BTW is this[2] the right instance? It doesn't looks to notice applied
patches.
[1] https://github.com/git-series/git-series
[2] https://patchwork.kernel.org/project/xen-devel/list
--
Best Regards,
Marek Marczykowski-Górecki
Invisible Things Lab
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
[-- Attachment #2: Type: text/plain, Size: 127 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
prev parent reply other threads:[~2017-07-02 9:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-30 16:57 offtopic: handling patches Marek Marczykowski-Górecki
2017-06-30 17:18 ` Andrew Cooper
2017-07-02 9:24 ` Marek Marczykowski-Górecki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170702092428.GP1095@mail-itl \
--to=marmarek@invisiblethingslab.com \
--cc=andrew.cooper3@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.